From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.71]) by mx.groups.io with SMTP id smtpd.web09.43133.1636366688519593164 for ; Mon, 08 Nov 2021 02:18:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=5dq7URd3; spf=pass (domain: arm.com, ip: 40.107.7.71, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hOebhK10ku/jEmUbPycVRJ1QdwobF9jXdBOu+NNEWzA=; b=5dq7URd3LBp1/R0rcvmg2Z5X7trPbx5UYiB6QOwt/p8dJfmlQxhZi6jbMExt1Lv0MMGdnek/CoRA0DT4hlaTkoes8gKrtrX6/KIUZti7owGsEiIb2a22OkTgWwZZOOHE9U+CmRLg80aP/j4xyvKiUWo+FM/r4enaLs+gvANmbjA= Received: from DB6PR07CA0117.eurprd07.prod.outlook.com (2603:10a6:6:2c::31) by HE1PR0801MB1737.eurprd08.prod.outlook.com (2603:10a6:3:81::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Mon, 8 Nov 2021 10:18:04 +0000 Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::f8) by DB6PR07CA0117.outlook.office365.com (2603:10a6:6:2c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.5 via Frontend Transport; Mon, 8 Nov 2021 10:18:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Mon, 8 Nov 2021 10:18:04 +0000 Received: ("Tessian outbound 7b0bcc4a550a:v108"); Mon, 08 Nov 2021 10:18:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 79f07092c5850ca6 X-CR-MTA-TID: 64aa7808 Received: from c65ccdb9fd7c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83B62D2B-3B49-428B-B32F-DC0516B3E842.1; Mon, 08 Nov 2021 10:17:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c65ccdb9fd7c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 08 Nov 2021 10:17:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuSKs79n8sGN7E+c4jbSdY844CHCBZYAZcocn4GQIHm06kY0QrQSWODGti6s5APpqIERIuv686E1iLEPh3R09Gl1280G2HyhSoQmhtFyPUZl6g/mlrjlmo+vUdI8QmIxExbJgdS7gYqLXVBZEYAmw7uiNyY5CVXKIE1jYnnyvzSSxwdfrcaD7kDuya8ccaz9hrOlzNGY4+zVzpd4WawfzDn1OdRNKvNykA8r5hJoFakOO1/TDFpCUw3BM/DzJKX7R6W1sDtQUnPolUY60XcvFCnYxMddnJToRyVJY+52lGRmM/SsiMygbGGucC/ZzHY99SaWsI3B5aIgD4mpxMLgRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hOebhK10ku/jEmUbPycVRJ1QdwobF9jXdBOu+NNEWzA=; b=FmksSG9q+tS1UTLOenYBiWPVb5Ff+xqmZmz03i+ffKLoNxkCKD7g4mVF6FYU7VwW26uXTZ+iPzToF/Jv26MTGNEHaIhnb3vgq0bLyOGa/sw90XJVCwbAHe/fxATs3uYzoUm/tc1MamJuBQw5JDh1ZwwDVm/3M+BKR1h88SVyVhq79cOvPNlyiO3OLFo6rGpaW8A6yW2YObfPFf7IPhF8oIMTUvsXHdeiQ9gbC+OMwnDPHw8cMieIZXYZPNFKVhM9iiwDLCqlICx1XILy2SdiDG36avvo99DuFiWLTkYouikieqy4fvuuLdaLkQ4Ui+gvaqH+wxU2g7ZA/BNNOyEmMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hOebhK10ku/jEmUbPycVRJ1QdwobF9jXdBOu+NNEWzA=; b=5dq7URd3LBp1/R0rcvmg2Z5X7trPbx5UYiB6QOwt/p8dJfmlQxhZi6jbMExt1Lv0MMGdnek/CoRA0DT4hlaTkoes8gKrtrX6/KIUZti7owGsEiIb2a22OkTgWwZZOOHE9U+CmRLg80aP/j4xyvKiUWo+FM/r4enaLs+gvANmbjA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3031.eurprd08.prod.outlook.com (2603:10a6:209:45::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Mon, 8 Nov 2021 10:17:47 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4669.010; Mon, 8 Nov 2021 10:17:47 +0000 Subject: Re: [edk2-devel] [PATCH v5 3/7] Platform/ARM/N1Sdp: Introduce platform DXE driver To: devel@edk2.groups.io, khasim.mohammed@arm.com Cc: nd@arm.com, Deepak Pandey References: <20211105142127.21616-1-khasim.mohammed@arm.com> <20211105142127.21616-3-khasim.mohammed@arm.com> From: "Sami Mujawar" Message-ID: <052dff17-0485-30b3-4722-45763e52b14e@arm.com> Date: Mon, 8 Nov 2021 10:17:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211105142127.21616-3-khasim.mohammed@arm.com> X-ClientProxiedBy: LO2P265CA0150.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0150.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Mon, 8 Nov 2021 10:17:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 710b4767-b046-42cb-1edb-08d9a2a10d53 X-MS-TrafficTypeDiagnostic: AM6PR08MB3031:|HE1PR0801MB1737: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SPTDFhT7/RWfIewJCchp1Px0sxGvxKrGolM7ptAd47Tr8qztCDiQwYK9lVxzGw27Sk8K55LzbuhM3q3dPQLClQh+k4KHZ4m8m4pE6eJGnZqshc8QzgDo7SDhkdJj9vZFYYmrrMu4F9JV1KCPrZgdb+ho6tbYPtFcglb773KD3ZYGAqMZCKsrwmOW3rcELlEgzMNZsoTKv919Ajflt6sa09TZmLZLYsIkzSye8dzRM0CSlA6PPWN5npkHHGyKtc+j/5qES6rgDFm3DkZA0rFw0xWwwurypr7tc8ytZqfUaDvOgihVWI3+63OZnV6snD4DYpFTLhZya1RQU4AxVeFAAr8XQoOwCT61jxjvrMgc4xPq8WjvotMZEowjrAzKZJ54K8Ka3IvblL0F1ykz/lo5pSeAIbOnP54PN+l5pCa2jt5KVfW8ygBbu5xLnpxMPlneT6hsCVZcmBvmU6sZOlnda5UhzSBc5oQFgrQeOHMD2F3VPaYyumpcOAL/3gbZX00Jvsyq73C5B7YJlk9czZ/UE1HCLX7BJWmQ0QOEX1eSNy+5zzPXersRZVxM1V/vjsMY/aXjiPIU1xkvXMDp8knGEa/uqE1i+SlDJiygGoyQ3uTYg2sOhnyhVXFqoO3VTT0UvE7i6pjjTm6FHVMIYC1cu4NeHAvMVonocof8oCV5q1gSnH6zjTixcNANNQM/Glo60/+RAdoLtvPcnD4kXWmg/tmRAW+3PG50YdZaEh2Q8paA+l0o8jE6ju6Vc/XF4JEM1TcvOOnuSmaiONzwCwlleA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31686004)(956004)(8676002)(6666004)(508600001)(2616005)(31696002)(8936002)(316002)(19627235002)(2906002)(16576012)(5660300002)(6636002)(26005)(38100700002)(38350700002)(4326008)(53546011)(52116002)(6486002)(186003)(83380400001)(44832011)(86362001)(66556008)(66946007)(36756003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3031 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 582c7c84-a12d-4d67-638b-08d9a2a102a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lCRM2Axq3Tgy4DUh63cA4cUstumhQ6298k6OCs9VPUSOBpZj+WgMfpwQ7BzgcviPVYxVvlxCB0QzVYhO20k463+FYK2nONGNC9ywab1SJed+jjD/p0dGmv2eDrquyTVvWJo5MNS61+a0+/RU9wXTdq6DHktRMqQmfdjrplbXTsdgI9MO94UKsx1uCtWH1olEP+LSpbWfrEXI06+97FnjQ4ym/3h0eBWtC5Um7c+hox7eVLJ/DnDJb6JwDMCCecH4zrvvLvrAfKhlXzoSFxrzAt1keSWey27htM0CoFiTy294p0zsbTPhO6+khSm3uf1XwXx94wH8qrGFzXigpE4NEFwLXkbmTkADzPtXFgNJq8lmuCfjJZgvVZr3Dc1zg9ET71FQF8tiKCwDES1Zm3mYuPZSisGmHfrfK+c5MvoB2P+nWJPl13QK6HlbFns9TCfziy8Pg+USvNuGrkaFFVWbkyxu3vE8a5A0TcMN4iVZydjAcPgcxvsykqUdFx7bTK0D4aiUHGxu5pblgaIag5jIzwgw8TDpBI/58FNw0os40ZSDnfYOF8HaOAjbldMvIkmkA+HlPnL/BkA9lehzmCE4kOQmkbOrSSKxC1sT2oiKRjrV74aXdvdwPkMdn4K5Qcn+VpZDM3m+MYB8lyBtFU5b3lOJFLwDJcNjAc2qsjWVgtFjyYPxpj7c48s9FFpigEd/jY/dBR1bbGe9ONRbpA5t82PIdCv1M+g05u7Fzn93zPQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(2616005)(83380400001)(186003)(70206006)(336012)(6636002)(4326008)(36756003)(70586007)(8936002)(31696002)(956004)(508600001)(8676002)(86362001)(2906002)(5660300002)(81166007)(16576012)(356005)(31686004)(26005)(316002)(47076005)(6666004)(53546011)(19627235002)(82310400003)(36860700001)(44832011)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 10:18:04.6546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 710b4767-b046-42cb-1edb-08d9a2a10d53 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1737 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Khasim, Other than a few minor code alignment issues (which I will fix before pushing), this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/11/2021 02:21 PM, Khasim Mohammed via groups.io wrote: > Add an initial platform DXE driver and support for ramdisk devices. > > Signed-off-by: Deepak Pandey > Signed-off-by: Khasim Syed Mohammed > --- > .../N1Sdp/Drivers/PlatformDxe/PlatformDxe.c | 59 +++++++++++++++++++ > .../N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf | 47 +++++++++++++++ > 2 files changed, 106 insertions(+) > create mode 100644 Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c > create mode 100644 Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > > diff --git a/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c > new file mode 100644 > index 0000000000..3f975fa5ac > --- /dev/null > +++ b/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c > @@ -0,0 +1,59 @@ > +/** @file > + > + Copyright (c) 2021, ARM Limited. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > + > +/** > + Entrypoint of Platform Dxe Driver > + > + @param ImageHandle[in] The firmware allocated handle for the EFI image. > + @param SystemTable[in] A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The RAM disk has been registered. > + @retval EFI_NOT_FOUND No RAM disk protocol instances were found. > + @retval EFI_UNSUPPORTED The ImageType is not supported. > + @retval Others Unexpected error happened. > + > +**/ > +EFI_STATUS > +EFIAPI > +ArmN1SdpEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + EFI_RAM_DISK_PROTOCOL *RamDisk; > + EFI_DEVICE_PATH_PROTOCOL *DevicePath; > + > + Status = EFI_UNSUPPORTED; > + if (FeaturePcdGet (PcdRamDiskSupported)) { > + Status = gBS->LocateProtocol (&gEfiRamDiskProtocolGuid, NULL, > + (VOID**) &RamDisk); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Couldn't find the RAM Disk protocol - %r\n", > + __FUNCTION__, Status)); > + return Status; > + } > + > + Status = RamDisk->Register ( > + (UINTN)PcdGet32 (PcdRamDiskBase), > + (UINTN)PcdGet32 (PcdRamDiskSize), > + &gEfiVirtualCdGuid, > + NULL, > + &DevicePath > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: Failed to register RAM Disk - %r\n", > + __FUNCTION__, Status)); > + } > + } > + return Status; > +} > diff --git a/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > new file mode 100644 > index 0000000000..d74f09b46c > --- /dev/null > +++ b/Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > @@ -0,0 +1,47 @@ > +## @file > +# Platform DXE driver for N1Sdp > +# > +# Copyright (c) 2021, ARM Limited. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001B > + BASE_NAME = PlatformDxe > + FILE_GUID = 116dcefb-aa53-46aa-81cd-49581684db55 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = ArmN1SdpEntryPoint > + > +[Sources.common] > + PlatformDxe.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + ArmPlatformPkg/ArmPlatformPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + Platform/ARM/N1Sdp/N1SdpPlatform.dec > + > +[LibraryClasses] > + HobLib > + UefiDriverEntryPoint > + > +[Protocols] > + gEfiRamDiskProtocolGuid > + > +[Guids] > + gEfiVirtualCdGuid ## SOMETIMES_CONSUMES ## GUID > + > +[FeaturePcd] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSupported > + > +[FixedPcd] > + gArmN1SdpTokenSpaceGuid.PcdRamDiskBase > + gArmN1SdpTokenSpaceGuid.PcdRamDiskSize > + > +[Depex] > + gEfiRamDiskProtocolGuid