From: "Laszlo Ersek" <lersek@redhat.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
devel@edk2.groups.io,
'Michael Kinney' <michael.d.kinney@intel.com>,
'Sean Brogan' <sean.brogan@microsoft.com>,
"'Ard Biesheuvel (ARM address)'" <ard.biesheuvel@arm.com>,
"'Leif Lindholm (Nuvia address)'" <leif@nuviainc.com>,
'Andrew Fish' <afish@apple.com>
Subject: Re: 回复: [edk2-devel] please let's disable the ECC plugin in CI, in its current form
Date: Thu, 10 Dec 2020 09:52:20 +0100 [thread overview]
Message-ID: <0542f7cd-0e0b-7324-018f-aa432019a1b5@redhat.com> (raw)
In-Reply-To: <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn>
Hi Liming,
On 12/08/20 16:38, gaoliming wrote:
> Laszlo:
> ECC tool is not perfect. It is still helpful. I am OK to disable ECC plugin in CI. But, I request to expose the option to enable it per package. If the package maintainer thinks ECC is valuable, he can enable ECC plugin in one package. As MdePkg maintainer, I can help to resolve ECC issue in MdePkg patch. So, I would keep ECC plugin in MdePkg.
the "skip trick" in Sean's patch at
<https://github.com/tianocore/edk2/pull/1201/commits/3a6b58f06cc33e78ba66b297013dd3d5bfb5f962>:
"EccCheck": {
## Exception sample looks like below:
## "ExceptionList": [
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
],
"skip": True <------ this
},
looks nice. While it is not as dynamic as a PR label, it is
package-level, and it needs no change when we add a new directory under
the package directory (because, the exception list would need a new
entry then).
Thanks
Laszlo
next prev parent reply other threads:[~2020-12-10 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 2:04 please let's disable the ECC plugin in CI, in its current form Laszlo Ersek
2020-12-08 7:03 ` Ard Biesheuvel
2020-12-08 15:38 ` 回复: [edk2-devel] " gaoliming
2020-12-08 18:37 ` Sean
2020-12-10 1:34 ` 回复: " gaoliming
2020-12-10 3:39 ` Sean
2020-12-11 1:10 ` 回复: " gaoliming
[not found] ` <164ED1ABFE90B1B0.9298@groups.io>
2020-12-09 10:24 ` Sean
2020-12-10 8:12 ` Laszlo Ersek
2020-12-10 8:52 ` Laszlo Ersek [this message]
2020-12-11 1:13 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0542f7cd-0e0b-7324-018f-aa432019a1b5@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox