From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web08.10331.1607590349881830282
 for <devel@edk2.groups.io>;
 Thu, 10 Dec 2020 00:52:30 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gRBh71/+;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1607590349;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WGJNuUcAbJBTyj9ic+xea2tjlVZvr0A0w70T8KPBYrw=;
	b=gRBh71/+GE5i10xRcgJlFWllW0+0K9/ARLX96hFvrbCaMZBcqKKgyE+nldZ5aQyrttnwvS
	MPVWqPXvjasIWbNa09NrwNXoE2G/Qsw9h6ECWIRuCL5Y4Yt3KZD7hTNTSpT8YOCvRpGwLX
	KzwkgRsiwYxdlrcdVsu4RjoDpcoDR0U=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-568-2PtpZsmAN3a7o0VeJk8yyw-1; Thu, 10 Dec 2020 03:52:25 -0500
X-MC-Unique: 2PtpZsmAN3a7o0VeJk8yyw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B783659;
	Thu, 10 Dec 2020 08:52:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-52.ams2.redhat.com [10.36.113.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E30A52BFE9;
	Thu, 10 Dec 2020 08:52:21 +0000 (UTC)
Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIHBsZWFzZSBsZXQncyBkaXNhYmxlIHRoZSBFQ0MgcGx1Z2luIGluIENJLCBpbiBpdHMgY3VycmVudCBmb3Jt?=
To: gaoliming <gaoliming@byosoft.com.cn>, devel@edk2.groups.io,
 'Michael Kinney' <michael.d.kinney@intel.com>,
 'Sean Brogan' <sean.brogan@microsoft.com>,
 "'Ard Biesheuvel (ARM address)'" <ard.biesheuvel@arm.com>,
 "'Leif Lindholm (Nuvia address)'" <leif@nuviainc.com>,
 'Andrew Fish' <afish@apple.com>
References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com>
 <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <0542f7cd-0e0b-7324-018f-aa432019a1b5@redhat.com>
Date: Thu, 10 Dec 2020 09:52:20 +0100
MIME-Version: 1.0
In-Reply-To: <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Liming,

On 12/08/20 16:38, gaoliming wrote:
> Laszlo:
>   ECC tool is not perfect. It is still helpful. I am OK to disable ECC plugin in CI. But, I request to expose the option to enable it per package. If the package maintainer thinks ECC is valuable, he can enable ECC plugin in one package. As MdePkg maintainer, I can help to resolve ECC issue in MdePkg patch. So, I would keep ECC plugin in MdePkg.

the "skip trick" in Sean's patch at
<https://github.com/tianocore/edk2/pull/1201/commits/3a6b58f06cc33e78ba66b297013dd3d5bfb5f962>:

    "EccCheck": {
        ## Exception sample looks like below:
        ## "ExceptionList": [
        ##     "<ErrorID>", "<KeyWord>"
        ## ]
        "ExceptionList": [
        ],
        ## Both file path and directory path are accepted.
        "IgnoreFiles": [
        ],
        "skip": True <------ this
    },

looks nice. While it is not as dynamic as a PR label, it is
package-level, and it needs no change when we add a new directory under
the package directory (because, the exception list would need a new
entry then).

Thanks
Laszlo