From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web10.5557.1590584932249917027
 for <devel@edk2.groups.io>;
 Wed, 27 May 2020 06:08:52 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KKRRU1d/;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1590584931;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3bNEc3Q00ep9iHshwBje8z1GuA1ztVlwJzmCIECBOcY=;
	b=KKRRU1d/HGWiQnkxQM+gYbfcTtHj+dmYwOPy7p1aI9WZlRpA+zferQf75NrF1b447NLEbB
	ZQugXd9woV6rpGm7dGVp03DxQL/zYK1foWuf+oHYIzkgo5KZpTxs0iGZI1O3AzzxdW/YaF
	zMi16VmXjqA+i+ZJ0iPZQz1QF3Qg9n8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-136-oiLspu_hPmKfpML-kHaaAA-1; Wed, 27 May 2020 09:08:36 -0400
X-MC-Unique: oiLspu_hPmKfpML-kHaaAA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3B93835B42;
	Wed, 27 May 2020 13:08:34 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-77.ams2.redhat.com [10.36.113.77])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 4DD755D9E5;
	Wed, 27 May 2020 13:08:33 +0000 (UTC)
Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005
To: Bret Barkelew <Bret.Barkelew@microsoft.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 "liming.gao" <liming.gao@intel.com>,
 "announce@edk2.groups.io" <announce@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>, "afish@apple.com" <afish@apple.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
References: <SN6PR11MB3197FC887F4BF880C5A0E33F80B40@SN6PR11MB3197.namprd11.prod.outlook.com>
 <CY4PR21MB0743F7D4F86167A9D4140B9BEFB40@CY4PR21MB0743.namprd21.prod.outlook.com>
 <6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com>
 <MWHPR21MB075042B77573074341D0FD38EFB00@MWHPR21MB0750.namprd21.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <0552f7d6-4216-d000-157a-9593b2a77763@redhat.com>
Date: Wed, 27 May 2020 15:08:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <MWHPR21MB075042B77573074341D0FD38EFB00@MWHPR21MB0750.namprd21.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 05/27/20 00:11, Bret Barkelew wrote:
> I just looked into it, and I think that AsciiStrCpyS() was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters.
> AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop seems to expect.
> 
> The bug stands and we should try to get that bug fix into the stable tag. Thanks!

OK, I'm down with that.

Thanks
Laszlo