From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.8108.1671584482652578656 for ; Tue, 20 Dec 2022 17:01:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=m5R9M/i6; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id C5409CD1F660 for ; Wed, 21 Dec 2022 09:01:19 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1671584479; bh=EleU6ePOOZlu1r84kvgnX6bX7b1av7cQhua2WTb4sro=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=m5R9M/i6lelseFTd9400v0XcdyEtQIjrq6qmVsBPEngKDoOeYdjAH4ct6MY+gq749 28ECSxxDyuX3DHn+dHoAtySNNVL1GSEMccIdJHCCqZsgdleQXEvrVK3DDVl4hVt6eq tTQuL0c/V4sOtZFcqlTjedPu+dY76he9OnV1YKsY= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id C086ECD1F65C for ; Wed, 21 Dec 2022 09:01:19 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 8871ACD1F657 for ; Wed, 21 Dec 2022 09:01:19 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 2988DCD1F677 for ; Wed, 21 Dec 2022 09:01:17 +0800 (CST) Received: from DESKTOPS6D0PVI ([101.86.145.41]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 21 Dec 2022 09:01:08 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.86.145.41 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Ard Biesheuvel'" , "'Jiewen Yao'" , "'Jordan Justen'" , "'Gerd Hoffmann'" , "'Brijesh Singh'" , "'Erdem Aktas'" , "'James Bottomley'" , "'Min Xu'" , "'Tom Lendacky'" References: <20221201023521.10028-1-aik@amd.com> <20221201023521.10028-2-aik@amd.com> <001101d909e1$84079000$8c16b000$@byosoft.com.cn> <9581bf9d-3e3c-f2f4-7967-a31799eb8f01@amd.com> In-Reply-To: <9581bf9d-3e3c-f2f4-7967-a31799eb8f01@amd.com> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0ggb3ZtZiAxLzVdIE1kZVBrZy9SZWdpc3Rlci9BbWQ6IERlZmluZSBhbGwgYml0cyBmcm9tIE1TUl9TRVZfU1RBVFVTX1JFR0lTVEVS?= Date: Wed, 21 Dec 2022 09:01:09 +0800 Message-ID: <057701d914d7$b663ac90$232b05b0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHz9TSNfqLjJbqtNrhjTCelWEpymQMk2n0QAd+GLhMDC7x3fK4BQ8bQ Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Alexey > Kardashevskiy via groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B412=E6=9C=887=E6=97=A5 = 20:25 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@= edk2.groups.io > =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; 'Jiewen= Yao' > ; 'Jordan Justen' ; 'Ger= d > Hoffmann' ; 'Brijesh Singh' ; > 'Erdem Aktas' ; 'James Bottomley' > ; 'Min Xu' ; 'Tom Lendacky' > > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH ovmf 1/5]= MdePkg/Register/Amd: > Define all bits from MSR_SEV_STATUS_REGISTER >=20 >=20 >=20 > On 7/12/22 13:13, gaoliming wrote: > > Alexey: > > > > > >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Alexey > >> Kardashevskiy via groups.io > >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B412=E6=9C=881=E6=97= =A5 10:35 > >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > >> =E6=8A=84=E9=80=81: Ard Biesheuvel ; Jiewen= Yao > >> ; Jordan Justen ; Ger= d > >> Hoffmann ; Brijesh Singh ; > >> Erdem Aktas ; James Bottomley > >> ; Min Xu ; Tom Lendacky > >> ; Alexey Kardashevskiy > >> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH ovmf 1/5] MdePkg/Register/Amd:= Define all > bits > >> from MSR_SEV_STATUS_REGISTER > >> > >> We will need soon DebugSwap but others likely too. > >> > >> Signed-off-by: Alexey Kardashevskiy > >> --- > >> MdePkg/Include/Register/Amd/Fam17Msr.h | 57 > +++++++++++++++++++- > >> 1 file changed, 56 insertions(+), 1 deletion(-) > >> > >> diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h > >> b/MdePkg/Include/Register/Amd/Fam17Msr.h > >> index bb4e143e2456..f9474e6776f2 100644 > >> --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > >> +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > >> @@ -121,7 +121,62 @@ typedef union { > >> /// > >> UINT32 SevSnpBit : 1; > >> > >> - UINT32 Reserved2 : 29; > >> + /// > >> + /// [Bit 3] The guest was run with the Virtual TOM feature enable= d > in > >> SEV_FEATURES[1] > >> + /// > >> + UINT32 vTOM_Enabled : 1; > >> + > > This name doesn't follow name convention. You can create pull request t= o > see > > CI test result. >=20 >=20 > It is though what 40332.pdf ("AMD64 Architecture Programmer=E2=80=99s Man= ual: > Volumes 1-5") uses and I find it _extremely_ useful when searching for a > feature in 3000+ pages PDF. >=20 > What is the preferred way? >=20 If CI reports this issue, you can add it into exception in MdePkg.ci.yaml. Please create pull request to see CI result.=20 Thanks Liming > Thanks, >=20 >=20 > > > > Thanks > > Liming > >> + /// > >> + /// [Bit 4] The guest was run with the ReflectVC feature enabled = in > >> SEV_FEATURES[2] > >> + /// > >> + UINT32 ReflectVC : 1; > >> + > >> + /// > >> + /// [Bit 5] The guest was run with the Restricted Injection featu= re > >> enabled in SEV_FEATURES[3] > >> + /// > >> + UINT32 RestrictedInjection : 1; > >> + > >> + /// > >> + /// [Bit 6] The guest was run with the Alternate Injection featur= e > >> enabled in SEV_FEATURES[4] > >> + /// > >> + UINT32 AlternateInjection : 1; > >> + > >> + /// > >> + /// [Bit 7] This guest was run with debug register swapping enabl= ed > > in > >> SEV_FEATURES[5] > >> + /// > >> + UINT32 DebugSwap : 1; > >> + > >> + /// > >> + /// [Bit 8] This guest was run with the PreventHostIBS feature > >> enabled in SEV_FEATURES[6] > >> + /// > >> + UINT32 PreventHostIBS : 1; > >> + > >> + /// > >> + /// [Bit 9] The guest was run with the BTB isolation feature enab= led > > in > >> SEV_FEATURES[7] > >> + /// > >> + UINT32 SNPBTBIsolation : 1; > >> + > >> + /// > >> + /// [Bit 10] > >> + /// > >> + UINT32 Reserved0 : 1; > >> + > >> + /// > >> + /// [Bit 11] The guest was run with the Secure TSC feature enable= d > in > >> SEV_FEATURES[9] > >> + /// > >> + UINT32 SecureTsc : 1; > >> + > >> + /// > >> + /// [Bits 12 13 14 15] > >> + /// > >> + UINT32 Reserved1 : 4; > >> + > >> + /// > >> + /// [Bit 16] The guest was run with the VMSA Register Protection > >> feature enabled in SEV_FEATURES[14] > >> + /// > >> + UINT32 VmsaRegProt_Enabled : 1; > >> + > >> + UINT32 Reserved2 : 15; > >> } Bits; > >> /// > >> /// All bit fields as a 32-bit value > >> -- > >> 2.38.1 > >> > >> > >> > >> > >> > > > > > > >=20 > -- > Alexey >=20 >=20 >=20 >=20