From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3DA79740040 for ; Wed, 5 Jun 2024 09:38:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PShPZylzuvcE8Rz3O6BEfbWMOXgnGmP+Pu6A6d/bcDA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1717580307; v=1; b=qP8j/WlY/RctRQ8igm1ukmb0EEVvuWZzj18V0exDthM2iW3TiXRDYiIC2Pk1ChXVgIA04Eml 6mFRIfKNLHw9AczERRDTuQW43fKDiMjPcsy8wtZmce5mgHBsCqEDrdf0Y6fXV/iUuW4KzP0lVHY UCqWIFmvoMn08qImr2I5GLJTSMEa/AXUmuowdGcyqCFSDuzdZJIxYI9TewQFWneUmq4YILq/BX4 FGqy6X/dvVWOG/+RtPtDgbAgARUqGsFrglsAgJGv0PCiFEYTKHaINZRBA4Pr04JxHcEAHJE65SA LoM7XS4+w+f/6mUHeawOncP4VK2CIfxB1Yv0Sk9/Iz7Rw== X-Received: by 127.0.0.2 with SMTP id jNmpYY7687511xZnQClh8wfx; Wed, 05 Jun 2024 02:38:25 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.11045.1717580303274393343 for ; Wed, 05 Jun 2024 02:38:25 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id CD30EA32E00E for ; Wed, 5 Jun 2024 17:38:19 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id B224BA32E018 for ; Wed, 5 Jun 2024 17:38:19 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id DA6C2A32E090 for ; Wed, 5 Jun 2024 17:38:16 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([36.21.130.137]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Wed, 05 Jun 2024 17:38:09 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 36.21.130.137 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Hsueh, Hong-Chih \(Neo\)'" , , "'Chang, Abner'" Cc: , , "'He, Jiangang'" References: <044b01daa72d$9a0819c0$ce184d40$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVQa2c6IFJlbW92ZSBub24tQVNDSUkgY2hhcmFjdGVycyBmcm9tIGhlYWRlciBmaWxlIChCWiMgNDc3NSk=?= Date: Wed, 5 Jun 2024 17:38:12 +0800 Message-ID: <057801dab72c$160325c0$42097140$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQEeBUMzCvflZbkY0utEgdYnciNLGAKy/EL/AfFShdgB60Dl0bL90PoA Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Jun 2024 02:38:25 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Wl4r0quVhxnCcdIKqmlMHANUx7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0579_01DAB76F.2428AFB0" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="qP8j/WlY"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io ------=_NextPart_000_0579_01DAB76F.2428AFB0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable I just add push label for it.=20 =20 =B7=A2=BC=FE=C8=CB: Hsueh, Hong-Chih (Neo) =20 =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA6=D4=C24=C8=D5 23:46 =CA=D5=BC=FE=C8=CB: gaoliming ; devel@edk2.groups= .io; Chang, Abner =B3=AD=CB=CD: michael.d.kinney@intel.com; zhiguang.liu@intel.com; He, Jiang= ang =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters = from header file (BZ# 4775) =20 [AMD Official Use Only - AMD Internal Distribution Only] =20 Hi Liming, =20 Sorry for the late response. I already created a pull request for it. https://github.com/tianocore/edk2/pull/5737 =20 Regards, Neo _____ =20 From: gaoliming > Sent: Wednesday, May 15, 2024 8:08 PM To: devel@edk2.groups.io >; Chang, Abner >; Hsueh, Hong-Chih (Neo) > Cc: michael.d.kinney@intel.com >; zhiguang= . liu@intel.com >; He, Jiangang > Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII charac= ters from header file (BZ# 4775)=20 =20 Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Abner: This change is good to me. Reviewed-by: Liming Gao > But, this is not critical issue. So, I suggest to merge it after the stable tag. Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io > =B4=FA=B1=ED Chang, A= bner via > groups.io > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA5=D4=C216=C8=D5 8:50 > =CA=D5=BC=FE=C8=CB: Hsueh, Hong-Chih (Neo) >; > devel@edk2.groups.io =20 > =B3=AD=CB=CD: michael.d.kinney@intel.com ; gaoliming@byosoft.com.cn ; > zhiguang.liu@intel.com ; He, Jiangang > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII character= s from > header file (BZ# 4775) > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, Liming and Zhiguang, > Could you please check this patch sent two weeks ago? The corresponding B= Z > ticket is 4775. We overlooked tracking this issue and missed the 202405 stable > release. As this impacts the build, do you think we can have a quick review and > approve it; having this change pulled in 202405 stable release? Otherwise we will > have to wait until next stable release. > > Thanks > Abner > > > -----Original Message----- > > From: Hsueh, Hong-Chih (Neo) > > > Sent: Thursday, May 2, 2024 3:31 AM > > To: devel@edk2.groups.io =20 > > Cc: michael.d.kinney@intel.com ; gaoliming@byosoft.com.cn ; > > zhiguang.liu@intel.com ; He, Jiangang >; Chang, > > Abner >; Hsueh, Hong-Chih (Neo) > Chih.Hsueh@amd.com > > > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > > > Cc: Jiangang He > > > Signed-off-by: Neo Hsueh > > > --- > > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > > b/MdePkg/Include/Register/Amd/Cpuid.h > > index add43c40aa..51fa9f235c 100644 > > --- a/MdePkg/Include/Register/Amd/Cpuid.h > > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > > @@ -46,9 +46,9 @@ CPUID Signature Information > > CPUID Extended Topology Enumeration > > > > @note > > - Reference: AMD64 Architecture Programmer=A1=AFs Manual Volume 3: Gen= eral- > > Purpose and System Instructions, > > + Reference: AMD64 Architecture Programmer's Manual Volume 3: General- > > Purpose and System Instructions, > > Revision 3.35 Appendix E, > > - E.4.24 Function 8000_0026=A1=AAExtended CPU Topology: > > + E.4.24 Function 8000_0026-Extended CPU Topology: > > CPUID Fn8000_0026 reports extended topology information for logica= l > > processors, including > > asymmetric and heterogenous topology descriptions. Individual logical > > processors may report > > different values in systems with asynchronous and heterogeneous > > topologies. > > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > index 756e7c86ec..4715c59dc4 100644 > > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > @@ -5733,9 +5733,9 @@ typedef union { > > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms > enumerated > > in > > /// IA32_TME_CAPABILITY are allowed. > > /// For example: > > - /// 0000 =A8C AES-XTS-128. > > - /// 0001 =A8C AES-XTS-128 with integrity. > > - /// 0010 =A8C AES-XTS-256. > > + /// 0000 - AES-XTS-128. > > + /// 0001 - AES-XTS-128 with integrity. > > + /// 0010 - AES-XTS-256. > > /// Other values are invalid. > > /// > > UINT32 TmePolicy : 4; > > @@ -5756,7 +5756,7 @@ typedef union { > > /// Similar to enumeration, this is an encoded value. > > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > > #GP. > > /// Writing a non-zero value to this field will #GP if bit 1 of EA= X (Hardware > > - /// Encryption Enable) is not also set to =A1=AE1, as encryption hardware must > be > > + /// Encryption Enable) is not also set to 1, as encryption hardwar= e must > be > > /// enabled to use MKTME. > > /// Example: To support 255 keys, this field would be set to a value of 8. > > /// > > -- > > 2.40.0.windows.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119469): https://edk2.groups.io/g/devel/message/119469 Mute This Topic: https://groups.io/mt/106500097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0579_01DAB76F.2428AFB0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

I just add push label for it.

 

= =B7=A2=BC=FE= =C8=CB: Hsueh, Hong-Chih (Neo) <Hong-Ch= ih.Hsueh@amd.com>
=B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4= =EA6=D4=C24=C8=D5 23:46
=CA=D5=BC=FE=C8=CB: gaoliming <gaoliming@byosoft.com.cn>; deve= l@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
=B3= =AD=CB=CD: michael.d.kinne= y@intel.com; zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.com&g= t;
=D6=F7=CC=E2: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from heade= r file (BZ# 4775)

 

[AMD Official Use Only - AMD Internal Distribution Only]

 

Hi Liming,

 

Sorry for the late response. I already created a pull request for= it.

 

Regards,

Neo

From: gaolim= ing <gaoliming@byosoft.com.c= n>
Sent: Wednesday, May 15, 2024 8:08 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner= <Abner.Chang@amd.com>; Hs= ueh, Hong-Chih (Neo) <Hong-Ch= ih.Hsueh@amd.com>
Cc: michael.d.kinney@intel.com <michael.d.kinney@intel.com>; zhiguang.liu@intel.com <zhiguang.liu@intel.com>; He, Jiangang <Jiangang.He@amd.com>
Subject:<= /b> =BB=D8=B8=B4= : [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters = from header file (BZ# 4775)

 

<= /div>

Caution: This message originate= d from an External Source. Use proper caution when opening attachments, cli= cking links, or responding.


Abner:
  This change is good= to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

  But, this is not critic= al issue. So, I suggest to merge it after the stable tag.

Thanks
= Liming
> -----=D3=CA=BC=FE=D4= =AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io>= =B4=FA=B1=ED Chang, Abner via
> groups.io<= br>> =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4= =EA5=D4=C216=C8=D5 8:50
> =CA=D5=BC=FE=C8=CB: H= sueh, Hong-Chih (Neo) <Hong-C= hih.Hsueh@amd.com>;
> = devel@edk2.groups.io
> =B3=AD=CB=CD: michael.d.kinney@intel.com;= gaoliming@byosoft.com.cn;<= br>> zhiguang.liu@intel.com; He, Jiangang <Jiangang.He@amd.= com>
> =D6=F7=CC=E2: Re: [edk2-devel= ] [PATCH] MdePkg: Remove non-ASCII characters from
> header file (BZ#= 4775)
>
> [AMD Official Use Only - AMD Internal Distribution O= nly]
>
> Hi Mike, Liming and Zhiguang,
> Could you please= check this patch sent two weeks ago? The corresponding BZ
> ticket i= s 4775. We overlooked tracking this issue and missed the 202405 stable
&= gt; release. As this impacts the build, do you think we can have a quick re= view and
> approve it; having this change pulled in 202405 stable rel= ease? Otherwise we will
> have to wait until next stable release.
= >
> Thanks
> Abner
>
> > -----Original Messag= e-----
> > From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
> > Sent: Thu= rsday, May 2, 2024 3:31 AM
> > To: devel@edk2.groups.io
> > Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > zhiguang.liu@intel.com; He, Jiangang= <Jiangang.He@amd.com>; Ch= ang,
> > Abner <Abner.Ch= ang@amd.com>; Hsueh, Hong-Chih (Neo) <Hong-
> > Chih.Hsueh@amd.com>
> > Subj= ect: [PATCH] MdePkg: Remove non-ASCII characters from header file
> &= gt;
> > Cc: Jiangang He <jiangang.he@amd.com>
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
&= gt; > ---
> >  MdePkg/Include/Register/Amd/Cpuid.h &n= bsp;            | 4 = ++--
> >  MdePkg/Include/Register/Intel/ArchitecturalMsr.h | = 8 ++++----
> >  2 files changed, 6 insertions(+), 6 deletions= (-)
> >
> > diff --git a/MdePkg/Include/Register/Amd/Cpui= d.h
> > b/MdePkg/Include/Register/Amd/Cpuid.h
> > index a= dd43c40aa..51fa9f235c 100644
> > --- a/MdePkg/Include/Register/Amd= /Cpuid.h
> > +++ b/MdePkg/Include/Register/Amd/Cpuid.h
> >= ; @@ -46,9 +46,9 @@ CPUID Signature Information
> >  &nb= sp; CPUID Extended Topology Enumeration
> >
> > &nbs= p;  @note
> > -  Reference: AMD64 Architecture Programme= r=A1=AFs Manual Volume 3: General-
> > Purpose and System Instruct= ions,
> > +  Reference: AMD64 Architecture Programmer's Manua= l Volume 3: General-
> > Purpose and System Instructions,
> = >            = ;   Revision 3.35 Appendix E,
> > -  E.4.24 Functio= n 8000_0026=A1=AAExtended CPU Topology:
> > +  E.4.24 Functio= n 8000_0026-Extended CPU Topology:
> >    &nbs= p; CPUID Fn8000_0026 reports extended topology information for logical
&= gt; > processors, including
> >      a= symmetric and heterogenous topology descriptions. Individual logical
>= ; > processors may report
> >      dif= ferent values in systems with asynchronous and heterogeneous
> > t= opologies.
> > diff --git a/MdePkg/Include/Register/Intel/Architec= turalMsr.h
> > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h<= br>> > index 756e7c86ec..4715c59dc4 100644
> > --- a/MdePkg/= Include/Register/Intel/ArchitecturalMsr.h
> > +++ b/MdePkg/Include= /Register/Intel/ArchitecturalMsr.h
> > @@ -5733,9 +5733,9 @@ typed= ef union {
> >      /// [Bit 7:4] TME Pol= icy/Encryption Algorithm: Only algorithms
> enumerated
> > i= n
> >      /// IA32_TME_CAPABILITY are al= lowed.
> >      /// For example:
> = > -    ///   0000 =A8C AES-XTS-128.
> >= ; -    ///   0001 =A8C AES-XTS-128 with integrity.=
> > -    ///   0010 =A8C AES-XTS-256.> > +    ///   0000 - AES-XTS-128.
> = > +    ///   0001 - AES-XTS-128 with integrity.=
> > +    ///   0010 - AES-XTS-256.
&g= t; >      ///   Other values are inva= lid.
> >      ///
> >  = ;    UINT32    TmePolicy : 4;
> > @@= -5756,7 +5756,7 @@ typedef union {
> >    &nb= sp; /// Similar to enumeration, this is an encoded value.
> > = ;     /// Writing a value greater than MK_TME_MAX_KEYID= _BITS will result in
> > #GP.
> >    =   /// Writing a non-zero value to this field will #GP if bit 1 of EAX = (Hardware
> > -    /// Encryption Enable) is not al= so set to =A1=AE1, as encryption hardware must
> be
> > +&nb= sp;   /// Encryption Enable) is not also set to 1, as encryption = hardware must
> be
> >      /// ena= bled to use MKTME.
> >      /// Example: = To support 255 keys, this field would be set to a value of 8.
> >&= nbsp;     ///
> > --
> > 2.40.0.windo= ws.1
>
>
>
>
>


=

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119469) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_0579_01DAB76F.2428AFB0--