From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.8567.1671585933844460249 for ; Tue, 20 Dec 2022 17:25:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=iNqQZSQZ; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 98CC3CD1F66F for ; Wed, 21 Dec 2022 09:25:31 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1671585931; bh=tTY+NggNrVQDuUvpROxBJhvUWZr8aH6Aqql2cg8Wvzc=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=iNqQZSQZxgdPemZXoInTRpBHOoHy1bRc94T7ACbPOiwnYpRITUlhNGh5P5DgMcBDE eXm1Ri4AHwwmD9QcbbhVzWOlFWe/G6Nf5S+PI21JRwy+PeIbweIDfPtqzNwfRICzty C+7r/FI3vhBRtij/ib0VYYIkwusN+H2TYIR4W9xc= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 94881CD1F6D0 for ; Wed, 21 Dec 2022 09:25:31 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6139BCD1F671 for ; Wed, 21 Dec 2022 09:25:31 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id A49DBCD1F657 for ; Wed, 21 Dec 2022 09:25:28 +0800 (CST) Received: from DESKTOPS6D0PVI ([101.86.145.41]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 21 Dec 2022 09:25:26 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.86.145.41 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Pedro Falcato'" , Cc: =?UTF-8?Q?'Marvin_H=C3=A4user'?= , "'Bob Feng'" , "'Yuwei Chen'" References: <20221216195020.1044915-1-pedro.falcato@gmail.com> In-Reply-To: <20221216195020.1044915-1-pedro.falcato@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggMS8xXSBCYXNlVG9vbHM6IEZpeCBJQTMyIFVJTlQ2NCBhbGlnbm1lbnQgZm9yIENMQU5HIHRvb2xjaGFpbnM=?= Date: Wed, 21 Dec 2022 09:25:26 +0800 Message-ID: <058001d914db$1b3e4780$51bad680$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGgDU3pnHMWQszHOyo0NG9vrDYAWa7pm4Bw Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn This change is good to me. Reviewed-by: Liming Gao = > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Pedro Falcato > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2022=E5=B9=B412=E6=9C=8817=E6=97=A5 3:50 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Pedro Falcato ; Marvin = H=C3=A4user > ; Bob Feng ; Liming Gao > ; Yuwei Chen > =E4=B8=BB=E9=A2=98: [PATCH 1/1] BaseTools: Fix IA32 UINT64 alignment = for CLANG > toolchains >=20 > Currently, UINT64 is not 8-byte aligned for CLANG* toolchains on IA32, > which causes ABI differences between IA32 and X64 in such simple = examples > as: >=20 > struct S {UINT32 A; UINT64 B;}; >=20 > Pass -malign-double to align it to 8 bytes, as is done for GCC = already. >=20 > Signed-off-by: Pedro Falcato > Cc: Marvin H=C3=A4user > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > BaseTools/Conf/tools_def.template | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index c4e4c7ded0af..2c66a11ae31f 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2618,15 +2618,15 @@ DEFINE CLANG38_ALL_CC_FLAGS =3D > DEF(GCC48_ALL_CC_FLAGS) DEF(CLANG38_WARNIN > *_CLANG38_IA32_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) > DEF(CLANG38_IA32_TARGET) > *_CLANG38_IA32_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) > DEF(CLANG38_IA32_TARGET) >=20 > -DEBUG_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g > +DEBUG_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g -malign-double > DEBUG_CLANG38_IA32_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 > -Wl,--oformat=3Delf32-i386 > DEBUG_CLANG38_IA32_DLINK2_FLAGS =3D > DEF(GCC5_IA32_DLINK2_FLAGS) -O3 >=20 > -RELEASE_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) > +RELEASE_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) -malign-double > RELEASE_CLANG38_IA32_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 > -Wl,--oformat=3Delf32-i386 > RELEASE_CLANG38_IA32_DLINK2_FLAGS =3D > DEF(GCC5_IA32_DLINK2_FLAGS) -O3 >=20 > -NOOPT_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g > +NOOPT_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g -malign-double > NOOPT_CLANG38_IA32_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386 > -Wl,--oformat=3Delf32-i386 > NOOPT_CLANG38_IA32_DLINK2_FLAGS =3D > DEF(GCC5_IA32_DLINK2_FLAGS) -O0 >=20 > @@ -2806,15 +2806,15 @@ DEFINE CLANGPDB_ALL_CC_FLAGS =3D > DEF(GCC48_ALL_CC_FLAGS) DEF(CLANGPDB_WARN > *_CLANGPDB_IA32_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) > DEF(CLANGPDB_IA32_TARGET) > *_CLANGPDB_IA32_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) > DEF(CLANGPDB_IA32_TARGET) >=20 > -DEBUG_CLANGPDB_IA32_CC_FLAGS =3D > DEF(CLANGPDB_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANGPDB_IA32_TARGET) -gcodeview > +DEBUG_CLANGPDB_IA32_CC_FLAGS =3D > DEF(CLANGPDB_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANGPDB_IA32_TARGET) -gcodeview -malign-double > DEBUG_CLANGPDB_IA32_DLINK_FLAGS =3D /NOLOGO > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT:ICF=3D10 /ALIGN:32 > /FILEALIGN:32 /SECTION:.xdata,D /SECTION:.pdata,D /MACHINE:X86 /DLL > /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER > /SAFESEH:NO /BASE:0 /DEBUG:GHASH /MLLVM:-exception-model=3Dwineh > /lldmap > DEBUG_CLANGPDB_IA32_DLINK2_FLAGS =3D >=20 > -RELEASE_CLANGPDB_IA32_CC_FLAGS =3D > DEF(CLANGPDB_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANGPDB_IA32_TARGET) > +RELEASE_CLANGPDB_IA32_CC_FLAGS =3D > DEF(CLANGPDB_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANGPDB_IA32_TARGET) -malign-double > RELEASE_CLANGPDB_IA32_DLINK_FLAGS =3D /NOLOGO /NODEFAULTLIB > /IGNORE:4001 /IGNORE:4254 /OPT:REF /OPT:ICF=3D10 /ALIGN:32 > /FILEALIGN:32 /SECTION:.xdata,D /SECTION:.pdata,D /MACHINE:X86 /DLL > /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER > /SAFESEH:NO /BASE:0 /MERGE:.rdata=3D.data > /MLLVM:-exception-model=3Dwineh /lldmap > RELEASE_CLANGPDB_IA32_DLINK2_FLAGS =3D >=20 > -NOOPT_CLANGPDB_IA32_CC_FLAGS =3D > DEF(CLANGPDB_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 > DEF(CLANGPDB_IA32_TARGET) -gcodeview > +NOOPT_CLANGPDB_IA32_CC_FLAGS =3D > DEF(CLANGPDB_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 > DEF(CLANGPDB_IA32_TARGET) -gcodeview -malign-double > NOOPT_CLANGPDB_IA32_DLINK_FLAGS =3D /NOLOGO > /NODEFAULTLIB /IGNORE:4001 /OPT:REF /OPT:ICF=3D10 /ALIGN:32 > /FILEALIGN:32 /SECTION:.xdata,D /SECTION:.pdata,D /MACHINE:X86 /DLL > /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER > /SAFESEH:NO /BASE:0 /DEBUG:GHASH /MLLVM:-exception-model=3Dwineh > /lldmap > NOOPT_CLANGPDB_IA32_DLINK2_FLAGS =3D >=20 > @@ -2907,15 +2907,15 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS > =3D -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x22 > *_CLANGDWARF_IA32_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) > DEF(CLANG38_IA32_TARGET) > *_CLANGDWARF_IA32_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) > DEF(CLANG38_IA32_TARGET) >=20 > -DEBUG_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g > +DEBUG_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g -malign-double > DEBUG_CLANGDWARF_IA32_DLINK_FLAGS =3D > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386 > -Wl,--oformat,elf32-i386 > DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =3D > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld >=20 > -RELEASE_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) > +RELEASE_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 > DEF(CLANG38_IA32_TARGET) -malign-double > RELEASE_CLANGDWARF_IA32_DLINK_FLAGS =3D > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386 > -Wl,--oformat,elf32-i386 > RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =3D > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld >=20 > -NOOPT_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g > +NOOPT_CLANGDWARF_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 > DEF(CLANG38_IA32_TARGET) -g -malign-double > NOOPT_CLANGDWARF_IA32_DLINK_FLAGS =3D > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386 > -Wl,--oformat,elf32-i386 > NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =3D > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=3Dlld >=20 > -- > 2.39.0