回复: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

["gaoliming" <gaoliming@byosoft.com.cn>]

Gerd:
  I will merge these two changes in tools_def.txt. Is it OK to you?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
> groups.io
> 发送时间: 2022年12月7日 9:36
> 收件人: devel@edk2.groups.io; brian.johnson@hpe.com; kraxel@redhat.com
> 抄送: 'Alexey Kardashevskiy' <aik@ozlabs.ru>; 'Erdem Aktas'
> <erdemaktas@google.com>; 'Pawel Polawski' <ppolawsk@redhat.com>;
> 'Jordan Justen' <jordan.l.justen@intel.com>; 'Ard Biesheuvel'
> <ardb+tianocore@kernel.org>; 'Yuwei Chen' <yuwei.chen@intel.com>; 'Tom
> Lendacky' <thomas.lendacky@amd.com>; 'James Bottomley'
> <jejb@linux.ibm.com>; 'Oliver Steffen' <osteffen@redhat.com>; 'Jiewen Yao'
> <jiewen.yao@intel.com>; 'Min Xu' <min.m.xu@intel.com>; 'Brijesh Singh'
> <brijesh.singh@amd.com>; 'Bob Feng' <bob.c.feng@intel.com>
> 主题: 回复: [edk2-devel] [PATCH v7 2/2] tools_def: add
> -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
> 
> Gerd:
>   I have no comments for this change. Acked-by: Liming Gao
> <gaoliming@byosoft.com.cn>
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brian J.
> > Johnson
> > 发送时间: 2022年12月2日 0:18
> > 收件人: devel@edk2.groups.io; kraxel@redhat.com
> > 抄送: Alexey Kardashevskiy <aik@ozlabs.ru>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Erdem Aktas <erdemaktas@google.com>;
> > Pawel Polawski <ppolawsk@redhat.com>; Jordan Justen
> > <jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> > Yuwei Chen <yuwei.chen@intel.com>; Tom Lendacky
> > <thomas.lendacky@amd.com>; James Bottomley <jejb@linux.ibm.com>;
> > Oliver Steffen <osteffen@redhat.com>; Jiewen Yao
> <jiewen.yao@intel.com>;
> > Min Xu <min.m.xu@intel.com>; Brijesh Singh <brijesh.singh@amd.com>;
> Bob
> > Feng <bob.c.feng@intel.com>
> > 主题: Re: [edk2-devel] [PATCH v7 2/2] tools_def: add
> > -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
> >
> > OK.  Doesn't look like a big impact.
> >
> > Thanks,
> > Brian J. Johnson
> > -------- Original Message --------
> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > Sent: Thursday, December 1, 2022 at 2:38 AM
> > To: Brian J. Johnson <brian.johnson@hpe.com>
> > Cc: devel@edk2.groups.io, Alexey Kardashevskiy <aik@ozlabs.ru>, Liming
> > Gao <gaoliming@byosoft.com.cn>, Erdem Aktas
> <erdemaktas@google.com>,
> > Pawel Polawski <ppolawsk@redhat.com>, Jordan Justen
> > <jordan.l.justen@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>,
> > Yuwei Chen <yuwei.chen@intel.com>, Tom Lendacky
> > <thomas.lendacky@amd.com>, James Bottomley <jejb@linux.ibm.com>,
> > Oliver
> > Steffen <osteffen@redhat.com>, Jiewen Yao <jiewen.yao@intel.com>, Min
> Xu
> > <min.m.xu@intel.com>, Brijesh Singh <brijesh.singh@amd.com>, Bob Feng
> > <bob.c.feng@intel.com>
> > Subject: [edk2-devel] [PATCH v7 2/2] tools_def: add
> > -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
> >
> > On Wed, Nov 30, 2022 at 01:28:42PM -0600, Brian J. Johnson wrote:
> > > Gerd,
> > >
> > > Sorry, gotta ask:  does this make much difference in the size of the
> > > compiled code?  That's a constraint on many real-hardware X64
> platforms,
> > > especially for 32-bit code.
> >
> > Quick test with OvmfPkg/OvmfPkgIa32X64.dsc (sec/pei ia32, dxe x64):
> >
> > master branch:
> >
> > FV Space Information
> > SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264
> > (0x2e350) free
> > PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088
> > (0x92048) free
> > DXEFV [49%Full] 12582912 (0xc00000) total, 6268032 (0x5fa480) used,
> > 6314880 (0x605b80) free
> > FVMAIN_COMPACT [98%Full] 1753088 (0x1ac000) total, 1725328
> (0x1a5390)
> > used, 27760 (0x6c70) free
> >
> > with patch applied:
> >
> > FV Space Information
> > SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264
> > (0x2e350) free
> > PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088
> > (0x92048) free
> > DXEFV [50%Full] 12582912 (0xc00000) total, 6335936 (0x60adc0) used,
> > 6246976 (0x5f5240) free
> > FVMAIN_COMPACT [99%Full] 1753088 (0x1ac000) total, 1738176
> (0x1a85c0)
> > used, 14912 (0x3a40) free
> >
> > So slightly more for 64-bit code.
> >
> > take care,
> >     Gerd
> >
> >
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>