From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
edk2-devel@ml01.01.org, leif.lindholm@linaro.org
Cc: ryan.harkin@linaro.org
Subject: Re: [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib
Date: Thu, 23 Feb 2017 17:19:09 +0100 [thread overview]
Message-ID: <0589ce43-099a-af16-ae44-6060eb60293e@redhat.com> (raw)
In-Reply-To: <1487864885-13485-1-git-send-email-ard.biesheuvel@linaro.org>
On 02/23/17 16:48, Ard Biesheuvel wrote:
> The debug implementation of the UncachedMemoryAllocationLib library
> class relies on the creation of an uncached alias of a memory range,
> while keeping the original cached mapping, but with read-only attributes
> to trap inadvertent write accesses.
>
> This is not a terribly good idea, given that the ARM architecture does
> not allow mismatched attributes, and so creating them deliberately is
> not something we should encourage by doing it in reference code.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPkg/ArmPkg.dsc | 1 -
> ArmPkg/Library/DebugUncachedMemoryAllocationLib/DebugUncachedMemoryAllocationLib.c | 656 --------------------
> ArmPkg/Library/DebugUncachedMemoryAllocationLib/DebugUncachedMemoryAllocationLib.inf | 47 --
> ArmVirtPkg/ArmVirt.dsc.inc | 2 -
> BeagleBoardPkg/BeagleBoardPkg.dsc | 1 -
> Omap35xxPkg/Omap35xxPkg.dsc | 3 +-
> 6 files changed, 1 insertion(+), 709 deletions(-)
Acked-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2017-02-23 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 15:48 [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib Ard Biesheuvel
2017-02-23 15:48 ` [PATCH 2/2] ArmPkg/CpuDxe: remove VirtualUncachedPages protocol and implementation Ard Biesheuvel
2017-02-23 17:50 ` Leif Lindholm
2017-02-23 16:19 ` Laszlo Ersek [this message]
2017-02-23 17:49 ` [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib Leif Lindholm
2017-02-23 17:58 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0589ce43-099a-af16-ae44-6060eb60293e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox