From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8EAF2AC0DDB for ; Sat, 28 Oct 2023 14:03:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=v5XMIC7AA4Et7uYiLahbe0QGUDiHP/E1nTzSTNvkLDw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698501826; v=1; b=H6pS0usJwhoVmTW5qPx/VU7h7ZPu6vYcLFcXIGFkzNjbS8eQHOMxH7gfw/eB/JpDWoJQTZ0W Le34T4gnHuU+6iPYngj6IYLDR0yhlsj18DF3RPTIWEu05rct3Fnyfl39UeQiFQzDGZ98CP6LlTE DdK8XNsKkQu7jk65Zf3MHNo4= X-Received: by 127.0.0.2 with SMTP id LGezYY7687511xYDOWZRgfwr; Sat, 28 Oct 2023 07:03:46 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.18322.1698501825649587970 for ; Sat, 28 Oct 2023 07:03:45 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-7VHKa4-ZMcW0LfHaG-RIQQ-1; Sat, 28 Oct 2023 10:03:43 -0400 X-MC-Unique: 7VHKa4-ZMcW0LfHaG-RIQQ-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F9D91C06913; Sat, 28 Oct 2023 14:03:42 +0000 (UTC) X-Received: from [10.39.192.70] (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86B3E492BE0; Sat, 28 Oct 2023 14:03:41 +0000 (UTC) Message-ID: <05a756e5-63b8-fce9-00de-5e9360fe7760@redhat.com> Date: Sat, 28 Oct 2023 16:03:40 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore To: devel@edk2.groups.io, mikuback@linux.microsoft.com, wei6.xu@intel.com Cc: Ard Biesheuvel , Sami Mujawar , Ray Ni References: <6add8265-f950-404c-be10-8a8bd8763af7@linux.microsoft.com> From: "Laszlo Ersek" In-Reply-To: <6add8265-f950-404c-be10-8a8bd8763af7@linux.microsoft.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: v4i7P01yLaE1Mck6P4s59VmKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=H6pS0usJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/27/23 18:08, Michael Kubacki wrote: > This allows ambiguous "platform" code in the critical path of the MM > core. Is this necessary? > > Do you need this for one feature that others might too and can be > abstracted? Or, do you plan to perform an unknown and arbitrary number > of changes behind the hook over time? Not sure if it's necessary, but it's somewhat "customary". Platform hook libs are not uncommon; for example PiSmmCpuDxeSmm consumes SmmCpuPlatformHookLib and SmmCpuFeaturesLib. My request would be for Wei to file a TianoCore Feature Request bugzilla, with a bit more information than "We need this library to implement our feature". Reference the BZ in the commit messages, then add the BZ to the . Laszlo > > Thanks, > Michael > > On 10/26/2023 11:28 PM, Xu, Wei6 wrote: >> This patch set is to add StandaloneMmCorePlatformHookLib into >> StandaloneMmCore. >> >> This library class defines a set of platform hooks called by the >> Standalone Mm Core. With this library, platform can perform specific >> tasks before and after invoking registered MMI handlers. >> We need this library to implement our feature. >> >> PR: https://github.com/tianocore/edk2/pull/4949 >> >> >> >> Cc: Ard Biesheuvel >> >> Cc: Sami Mujawar >> >> Cc: Ray Ni >> >> >> Wei6 Xu (2): >>    StandaloneMmPkg: Add Standalone Mm Core platform hook lib. >>    StandaloneMmPkg/Core: Consumes Standalone Mm Core Platform Hook Lib. >> >>   StandaloneMmPkg/Core/StandaloneMmCore.c       |  7 ++- >>   .../StandaloneMmCorePlatformHookLibNull.c     | 45 +++++++++++++++++++ >>   StandaloneMmPkg/Core/StandaloneMmCore.h       |  1 + >>   StandaloneMmPkg/Core/StandaloneMmCore.inf     |  1 + >>   .../Library/StandaloneMmCorePlatformHookLib.h | 44 ++++++++++++++++++ >>   .../StandaloneMmCorePlatformHookLibNull.inf   | 30 +++++++++++++ >>   StandaloneMmPkg/StandaloneMmPkg.dec           |  4 ++ >>   StandaloneMmPkg/StandaloneMmPkg.dsc           |  2 + >>   8 files changed, 133 insertions(+), 1 deletion(-) >>   create mode 100644 >> StandaloneMmPkg/Library/StandaloneMmCorePlatformHookLibNull/StandaloneMmCorePlatformHookLibNull.c >>   create mode 100644 >> StandaloneMmPkg/Include/Library/StandaloneMmCorePlatformHookLib.h >>   create mode 100644 >> StandaloneMmPkg/Library/StandaloneMmCorePlatformHookLibNull/StandaloneMmCorePlatformHookLibNull.inf >> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110246): https://edk2.groups.io/g/devel/message/110246 Mute This Topic: https://groups.io/mt/102214566/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-