public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Brijesh Singh" <brijesh.singh@amd.com>
To: Rebecca Cran <quic_rcran@quicinc.com>,
	devel@edk2.groups.io, thomas.lendacky@amd.com,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>
Cc: brijesh.singh@amd.com
Subject: Re: [edk2-devel] OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)
Date: Fri, 4 Feb 2022 09:53:15 -0600	[thread overview]
Message-ID: <05b80c04-d107-2f32-394c-188e640543bf@amd.com> (raw)
In-Reply-To: <8bd5a6c5-4ae6-9744-f038-ce8a013c57d7@quicinc.com>


On 2/2/22 6:16 PM, Rebecca Cran wrote:
> On 2/2/22 14:16, Lendacky, Thomas via groups.io wrote:
>> This looks like the same error that XCODE5 was complaining about. The
>> patch was submitted by Brijesh, but some CI failure occurred. I'm not
>> sure how that is possible from a one line patch like that, maybe it
>> has something to do with the file in general, excluding the patch?
>
> No, the patch is wrong: Uncrustify wants the equals signs to line up.
>
>      XssMsr.Uint64 = 0;
> +    Compacted = FALSE;
>
>
> Should be:
>
>      XssMsr.Uint64 = 0;
> +    Compacted     = FALSE;
>
>
I am a bit occupied with kernel work right now, so feel free to send the
patch. Otherwise, I will get the patch out on Monday or Tuesday.

-Brijesh


      reply	other threads:[~2022-02-04 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 20:54 OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0) Rebecca Cran
2022-02-02 21:16 ` Lendacky, Thomas
2022-02-03  0:16   ` [edk2-devel] " Rebecca Cran
2022-02-04 15:53     ` Brijesh Singh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b80c04-d107-2f32-394c-188e640543bf@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox