From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.57]) by mx.groups.io with SMTP id smtpd.web09.10573.1643989957081332269 for ; Fri, 04 Feb 2022 07:52:37 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=bwU8mqPR; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.57, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhgPLOElP4WgFnyhqngeO3E1tPhi4+TZNJIfRYbFPA1CPvB+p+IlTdb7FrjUCN16UQHR8cwvrQuLD4Nc36R9btI6gXKV5hE3Kzq9MFNs5sXm9zZslxJ6kqo4nGKgl9OYLzHnPqroCAvBpzhKjWvrlK7Y+c7xrXeUnZZlAE7TCngNO8WryRVho44mp+iMf0wYEho7B0bJwJEMDwWq2kyqvC4zaxPEy4/MqD/Tc3yVYnO2h8d1VOwJjw2KDwcpKwMrpa+xdyLPBU6/KcOVGRFZxDH3+87Hj9yGv29LgOR45hU3iknw3jG4R3UfyOZxaKHGzUPenPh5aUnLmM979nLWXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iQF5BP1t6+dueiwHc3Cmq/FyNVmx7A9ofR7ZQRX44tg=; b=gEWuFqjzDJmLiyVMG7m9pzOiLJuwAwZdq7KLnmMfsGUZcZIdZb13E5iXNWJDe1Q/b3NJ1sLBjCNDV9oGytl4H1VNRpjVD2JwHMPDeqsygM2GGwWhgiT7ooAT57rzHN20yypB9WJlugh2EvvQYlUQOoD5HW+4ll1A6A07Fxvl3L1cj1J6VQ7MaxDMgzH0s1a7UEbrhyjFshHH/0ZP0XgDP6v+CT7g0jQ7t32sPgK/pV399aVGdPcEay5D9HxuvSUp5PJAMtDElAHh29F5b/O1z9HIwEA7tGDyG2k5uWQRHVMqXoFZmb2y7aedynBeAQ6uYG4bcEcmOfc/v8m1FCQHhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iQF5BP1t6+dueiwHc3Cmq/FyNVmx7A9ofR7ZQRX44tg=; b=bwU8mqPRYEBkXkPWbRKlGc9KBRp6h5qaBb/cMmaHNKcMrUoF6zwazoFBvfLsQ5Wt7FKSGKzQSXyP2g5pG0IW1Z6CAKzT9S3z1s1TwxQOU5Vh4ezhE0Y3dzQ2J2rcFtgo36u8pX6qIRybcTJMukapWsWyuGjr4sCy+NZtrRujses= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by DM5PR1201MB2475.namprd12.prod.outlook.com (2603:10b6:3:e6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Fri, 4 Feb 2022 15:52:33 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::500e:b264:8e8c:1817]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::500e:b264:8e8c:1817%4]) with mapi id 15.20.4930.023; Fri, 4 Feb 2022 15:52:33 +0000 Message-ID: <05b80c04-d107-2f32-394c-188e640543bf@amd.com> Date: Fri, 4 Feb 2022 09:53:15 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 CC: brijesh.singh@amd.com Subject: Re: [edk2-devel] OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0) To: Rebecca Cran , devel@edk2.groups.io, thomas.lendacky@amd.com, Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu References: <3f4127be-35b1-ec66-25f9-12bdbd5fd0d7@amd.com> <8bd5a6c5-4ae6-9744-f038-ce8a013c57d7@quicinc.com> From: "Brijesh Singh" In-Reply-To: <8bd5a6c5-4ae6-9744-f038-ce8a013c57d7@quicinc.com> X-ClientProxiedBy: MN2PR01CA0013.prod.exchangelabs.com (2603:10b6:208:10c::26) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 065b166c-c9ee-4d94-2073-08d9e7f65b98 X-MS-TrafficTypeDiagnostic: DM5PR1201MB2475:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mn+jqulaOrHvfi7TnySjKJ5GmAP77aLHa+QLlPysF4sadotCVoXpjTpOoQqlZkFmDWdeVOAJ83sv6GlSvss4Z8CfWrvAaX+zNcz5IwDn6GM2Wx7ZrVryQ5QQLozm0G2YdnF/d5lmg70unrs2u3q1qe8etz01v4SyIqJXZlOe22YZH36Zou9c3F3wI7Wggfv0laPrQCXfaLbf4TagmT0rm29hTZr+fFwQRs73+RB/nFOzDc1JOdevMss2XU7tU6Ck+qwe+hGAB96UnHW9BEt1479d0g4waRKlX94FX3avSgTLR5Ypm4AiL+zU7lHcxUgnv1uwOCEhpvlEN3tkSoR6o7Ol5cbTxA99JS1+yLLGvrADW37dhoANERUwOrjf+JHfJtfVNM6wQnFpyhXYwYRs7M1l3xnf/I7xZSwauAUiLW/lYXfr1kV5hDLLhEXCJnhVKNmY5tiyRMH+K2XoJmY6FrV7Zp3PpB/127Z8t0vHsvoeQbBmvcaaM2Zl6PBGG1TEM510R9ilJboafdPMFvyyHyjtyxtVj59bpznyXNJpX5JsEAkoTGBzsyC284OxDg6ufy0Ymx6VuKEg27nimIBy0M+kqyVCRxCk+8Ev9SMQKHdgZAHfMxMuQOvpX+swvHbFw3Ha3p1yKEIM514aLSIlp5YUt7t73oXYFXl8mAojKnLtkp7NmWLilDH4W2VnD4mfOm18V+TmIiG0y2AbpnFCyhLWuyTnKDhv0uYT0Sna2o8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66556008)(66946007)(36756003)(44832011)(31686004)(53546011)(508600001)(4326008)(4744005)(316002)(83380400001)(31696002)(110136005)(8936002)(6486002)(8676002)(86362001)(38100700002)(6666004)(6512007)(6506007)(26005)(2906002)(5660300002)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eSG66X0wAjB9Y62qrCQX5/UQFWAfSVIxnik3hxJQ+0cAndWWRUtLE5h/0REQ?= =?us-ascii?Q?jKBvqhVXMkYZMD5NH+WJO9imODv8oHr/XbDs+kCe6TeTZglvfpP/kKOvpHYd?= =?us-ascii?Q?AyxH9KXRl17cA7HzOWIgg2u4qvxRANKCQk1AVL3kVRdZrIeSj9vZguFhf52a?= =?us-ascii?Q?PFMTMFhIKpfZ8dRGCV/+jPEprLeHCVunFxv+C1+Ewe8LJGpssdF6tOhgThHt?= =?us-ascii?Q?PB/iWUOAhdRcM8kx0/syZp4ycG6clyzcv7cXAKmkDgpMfhSawMjJvIuY7kM4?= =?us-ascii?Q?QwHAzF2HHum+Tpz9b+8Pj7bCjXqHYsY9MwmQLS9sYm/v5PViQNuv1tpNZiB8?= =?us-ascii?Q?Um3J2d+G6uley7ijQAMtQzj4oF1CGVAua1GEwTp4bZYWQkm8B7YGe5Xnzgsk?= =?us-ascii?Q?OLmiOXj/qwUeAOPch8md/PLlbiNd6bLLddXe2vtcLo8jmL1E2GsbHT6woiFy?= =?us-ascii?Q?EAo2iHh7H3uRPOnGI+N/IMPSrWgwH8/o/EYMNiQB1KTH8AypaCJGnr6QdfoA?= =?us-ascii?Q?VSgrzLVeoxj7LxVr0pzK9yhCFIoLtJrnMD0NaLcx5IhN12bdlAKFisnpBMue?= =?us-ascii?Q?Vb4QrIvoEc1kfn+idMjPoMMEFKfVrIY3J/rKX0WpEVcS1f1T2ezplsG/z7gT?= =?us-ascii?Q?dCz8oqME8f/EK5z6uhQVESzbH0GongeORl0jZFnLKDpg/IpnhIMp139+bjAI?= =?us-ascii?Q?4/ax52TDmdPYkfaF+jrWGK+kUlKcErTqmkRWMcIzAaFahtR+lJrmCHqMmCuK?= =?us-ascii?Q?c21xC9UhSX0fUnsoYnLUmvhDnf7t27rjtZ5U1qg3pScG+26AeIZ4MdZUaRj0?= =?us-ascii?Q?b32RHQNmBo7evePT0hR0F3Xl8N3GHHhTF1lO948Wu4gk5DmzbhavhhgcERRj?= =?us-ascii?Q?4FDq/M9+iO2582YzderLc2vd0u2zW/JZArFZgLhBZXmWwH9WTt5/iKWzDHbT?= =?us-ascii?Q?zKxYGU0b2XOAA4H0+hjp1lsSK9aDPgV36J5zLDEN+TdHKOaTteMY0YRzB5np?= =?us-ascii?Q?zMIH4vkA+jd5rOuKGr5zo5JYsR8q1kXeCREd51RzmCLtdz56a19+drGYLrBa?= =?us-ascii?Q?zXQfEFym6aK4NoDw04VGHrUfVS+9kPDkQ9nIusMsPpgG97obRFTPadUiQiqA?= =?us-ascii?Q?xOKVKVB8eVz+F5MbhIcbIXwdpBqGOtBDVJmrrdv31HGjdOCtdIGFvbgGUN4v?= =?us-ascii?Q?MCRCQmb3K58wn3RE/+QHQZHwsXuKth41c5W3y/up6tPGjcVgoXcZaUlinVyu?= =?us-ascii?Q?ploaPj7r0K5XPOtt0vbNCpj2kvydGUjnh2L9yFMLuyQmj85I7/r33CQHDp3p?= =?us-ascii?Q?4EfoTr6+w4S5qtA/VmK6xcyX9sMKB4mH3AG5yB1giw/FOeVUJFq4O+qlPA5U?= =?us-ascii?Q?0t40jEbxpZn7EA8AW5FKtjeplwR7bhyJYzBa4Far6qy+6INLGWrqYl+zgRu3?= =?us-ascii?Q?m3ufJHLyQ+JuidST7dpByO+3LOFDcCf41+GbbYR6BXDAaqXc0YBbnp1NtWRk?= =?us-ascii?Q?R2MldLclIEuYpN5YNGfIWcfYKKKstyZEvMH22zCWCCGtjs62qRbvBu+5EFuV?= =?us-ascii?Q?2aU4pJhszzbm434pGFOGVB4qTfqxZeRFOXhKW0WpXoRwfkD16COYdrlEtz/3?= =?us-ascii?Q?9uAy7YI62TBQXnFbds+tV7Q=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 065b166c-c9ee-4d94-2073-08d9e7f65b98 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 15:52:33.6959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zHqIZifJYJRdcbTnxkJd0d+Li9Fs88igfnh+b8RTfsem1bLD1oyXncQXqep0gb+bxqqfqtMccJjqTDlR+UyVbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2475 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2/2/22 6:16 PM, Rebecca Cran wrote: > On 2/2/22 14:16, Lendacky, Thomas via groups.io wrote: >> This looks like the same error that XCODE5 was complaining about. The >> patch was submitted by Brijesh, but some CI failure occurred. I'm not >> sure how that is possible from a one line patch like that, maybe it >> has something to do with the file in general, excluding the patch? > > No, the patch is wrong: Uncrustify wants the equals signs to line up. > > =C2=A0=C2=A0=C2=A0=C2=A0 XssMsr.Uint64 =3D 0; > +=C2=A0=C2=A0=C2=A0 Compacted =3D FALSE; > > > Should be: > > =C2=A0=C2=A0=C2=A0=C2=A0 XssMsr.Uint64 =3D 0; > +=C2=A0=C2=A0=C2=A0 Compacted=C2=A0=C2=A0=C2=A0=C2=A0 =3D FALSE; > > I am a bit occupied with kernel work right now, so feel free to send the patch. Otherwise, I will get the patch out on Monday or Tuesday. -Brijesh