From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C4D41740058 for ; Tue, 3 Oct 2023 15:53:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=A5AvkqBZU6RbNLKUK5HLCtG49uZ1Bn347QcsH0H69gw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696348421; v=1; b=D4Ibwcvq0MncJZAQDL31GwesjxTe8iPDKrABdW8MWkCUjTmZd6daaK0Xgk4p6Kjh3ApJIB0u qEzZKw9DGNMhgVNtI2abAiHjheXiBPYsF0LRh1B1+8sA2p5FjVKKWY5PCt/LKOFg1Bu3yePk7r+ UWDHbfhV0tHkA2D9hgmzWduk= X-Received: by 127.0.0.2 with SMTP id eP5yYY7687511xurhplP9G9O; Tue, 03 Oct 2023 08:53:41 -0700 X-Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.89315.1696269372597333192 for ; Mon, 02 Oct 2023 10:56:12 -0700 X-Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-406650da82bso329845e9.3 for ; Mon, 02 Oct 2023 10:56:12 -0700 (PDT) X-Gm-Message-State: Kl0getKGD1b0I1EyuTqta8uyx7686176AA= X-Google-Smtp-Source: AGHT+IGKmX+LeY5pwTNnGNw30XRbkCvMmSH0gBKkWwjQFFoG3b9+eIM65KtGYxseNDvosPupTujSvg== X-Received: by 2002:adf:cf0a:0:b0:320:fc:97bc with SMTP id o10-20020adfcf0a000000b0032000fc97bcmr11766263wrj.1.1696269370974; Mon, 02 Oct 2023 10:56:10 -0700 (PDT) X-Received: from [192.168.69.115] (176-131-222-246.abo.bbox.fr. [176.131.222.246]) by smtp.gmail.com with ESMTPSA id u21-20020adfa195000000b00323293bd023sm19753863wru.6.2023.10.02.10.56.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 10:56:10 -0700 (PDT) Message-ID: <05b8497c-91e7-09d5-a263-6b7a87f3ffdf@linaro.org> Date: Mon, 2 Oct 2023 19:56:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump To: Leif Lindholm , devel@edk2.groups.io Cc: Andrei Warkentin , Ard Biesheuvel , Sami Mujawar References: <20230926171523.368706-1-quic_llindhol@quicinc.com> <20230926171523.368706-5-quic_llindhol@quicinc.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230926171523.368706-5-quic_llindhol@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=D4Ibwcvq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 26/9/23 19:15, Leif Lindholm wrote: > Both in SetJump and in InternalLongJump, 32-bit w register views were > used for the UINTN return value. In SetJump, this did not cause errors; > it was only counterintuitive. But in InternalLongJump, it meant the top > 32 bits of Value were stripped off. > > Change all of these to use the 64-bit x register views. > > Signed-off-by: Leif Lindholm > Reanimated-by: Andrei Warkentin =) Reviewed-by: Philippe Mathieu-Daudé > Cc: Ard Biesheuvel > Cc: Sami Mujawar > --- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 8 ++++---- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109288): https://edk2.groups.io/g/devel/message/109288 Mute This Topic: https://groups.io/mt/101600808/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-