Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

["Jeremy Linton" <jeremy.linton@arm.com>]

On 8/27/24 11:37, Ard Biesheuvel wrote:
> On Tue, 6 Aug 2024 at 16:10, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>>
>> On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote:
>>> Hi,
>>>
>>>
>>> On 8/1/24 09:44, Ard Biesheuvel wrote:
>>>> On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel <ardb@kernel.org> wrote:
>>>>>
>>>>> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton <jeremy.linton@arm.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> On 7/31/24 11:33, Ard Biesheuvel wrote:
>>>>>>> Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg
>>>>>>> to the new versions called Sec or PeilessSec - these have been cleaned
>>>>>>> up and stripped of obsolete functionality related to multicore boot,
>>>>>>> which is not something UEFI should concern itself with.
>>>>>>>
>>>>>>> This series can be merged once Tianocore/edk2 PR #5997 is merged first.
>>>>>>> After that, ArmPlatformStackLib and the old PrePi / PrePeiCore drivers
>>>>>>> can be retired.
>>>>>>
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Thanks for cleaning this up, but the rpi4 fails with:
>>>>>>
>>>>>> Decompress GetInfo Failed - Invalid Parameter
>>>>>>
>>>>>> ASSERT_EFI_ERROR (Status = Not Found)
>>>>>> ASSERT [PeilessSec]
>>>>>> /home/jlinton/rpi2/edk2/ArmPlatformPkg/PeilessSec/PeilessSec.c(158):
>>>>>> !(((INTN)(RETURN_STATUS)(Status)) < 0)
>>>>>>
>>>>>
>>>>> Weird. I actually tried RPi4 myself. Maybe I should have tried a clean rebuild.
>>>>>
>>>>> I'll look into it.
>>>>
>>>> The below should fix it - I'll update all DSCs with this if it works
>>>> for you as well.
>>>
>>> That fixes the problem above. Thanks!
>>
>> Can I take that as an R-b on the Rpi changes in this set?
>>
> 
> In the interest of progress on the EDK2 side, I intend to merge the
> remaining 2/2 of this set tomorrow, on the basis that it is primarily
> a code refactoring change that works correctly on the platforms that I
> can readily test (RPi3 / RPi4).
> 
> If anyone objects to this, please leave a reply on the thread.

Ok..

For the rpi4 parts

Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>

and

Tested-by: Jeremy Linton <jeremy.linton@arm.com>

(although EDK doesn't use tested-by does it?)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120421): https://edk2.groups.io/g/devel/message/120421
Mute This Topic: https://groups.io/mt/107649429/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-