From: "Laszlo Ersek" <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Erdem Aktas <erdemaktas@google.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Michael Roth <michael.roth@amd.com>, Min Xu <min.m.xu@intel.com>,
Oliver Steffen <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/ResetVector: send post codes to qemu debug console
Date: Thu, 25 Jan 2024 20:47:56 +0100 [thread overview]
Message-ID: <05f60909-a4ef-7497-5925-775b3ad71797@redhat.com> (raw)
In-Reply-To: <zm76uscj3ie57hipzh3ux6s4mn7yz7j2ojt2xoyhovldtsacxp@it6kmjmw6qvj>
On 1/25/24 08:50, Gerd Hoffmann wrote:
> On Wed, Jan 24, 2024 at 05:43:29PM -0800, Erdem Aktas wrote:
>> Same for TDX, I did not run it but it should cause failure
>> as debugShowPostCode is called OvmfPkg/ResetVector/Ia32/IntelTdx.asm before
>> actually the #VE handlers are installed.
>>
>>> Had a meeting get canceled and so got a chance to test this. As I thought,
>>> this causes SEV-ES/SEV-SNP guest failures.
>
> Hmm, I guess that pretty much kills the idea. The first post code is
> sent before probing for TDX/SEV happens ...
Can we salvage it, but make it depend on a minimal source code tweak
(ungating)? Changing a single line for debugging (non-TDX / non-SEV-ES
guests, anyway) is much easier than coming up with this patch from zero,
whenever needed.
Can we add "DebugCon.asm" to the tree, plus a *comment* near
%include "DebugDisabled.asm"
about "DebugCon.asm"?
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114460): https://edk2.groups.io/g/devel/message/114460
Mute This Topic: https://groups.io/mt/103933942/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-25 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 15:31 [edk2-devel] [PATCH 1/1] OvmfPkg/ResetVector: send post codes to qemu debug console Gerd Hoffmann
2024-01-24 16:47 ` Laszlo Ersek
2024-01-24 19:24 ` Lendacky, Thomas via groups.io
2024-01-24 19:55 ` Lendacky, Thomas via groups.io
2024-01-25 1:43 ` Erdem Aktas via groups.io
2024-01-25 7:50 ` Gerd Hoffmann
2024-01-25 19:47 ` Laszlo Ersek [this message]
2024-01-26 13:25 ` Gerd Hoffmann
2024-01-29 11:22 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f60909-a4ef-7497-5925-775b3ad71797@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox