From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D04FA941B35 for ; Thu, 25 Jan 2024 19:48:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=j4sgCnFxfJRM/Z8rckLVAceDbfxe3eJn+AH8+pAQWVY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706212084; v=1; b=FzE9hbb1Xn6XQ8SSGJLSfQvedAehGYendpSmUkjJBp9xH64so8PQFzLBiYi5sBl2ZciFqWP7 +zJZ5bOsi9ah7Jd3DFSE9j49QE88OY7BaAjwMrl8dV6Z+F1oRcaxC40/QevKE1GM5V5bD65qNri GWlMi5AfGLI1D3Wtz98byBOM= X-Received: by 127.0.0.2 with SMTP id QvpPYY7687511xqFdFiJ9dY4; Thu, 25 Jan 2024 11:48:04 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.28349.1706212083862211590 for ; Thu, 25 Jan 2024 11:48:04 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-G0dDMFnvOF6LoMyUqknI2g-1; Thu, 25 Jan 2024 14:47:59 -0500 X-MC-Unique: G0dDMFnvOF6LoMyUqknI2g-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1191083B872; Thu, 25 Jan 2024 19:47:59 +0000 (UTC) X-Received: from [10.39.195.100] (unknown [10.39.195.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C99992028CD4; Thu, 25 Jan 2024 19:47:57 +0000 (UTC) Message-ID: <05f60909-a4ef-7497-5925-775b3ad71797@redhat.com> Date: Thu, 25 Jan 2024 20:47:56 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/ResetVector: send post codes to qemu debug console To: Gerd Hoffmann , Erdem Aktas Cc: Tom Lendacky , devel@edk2.groups.io, Jiewen Yao , Ard Biesheuvel , Michael Roth , Min Xu , Oliver Steffen References: <20240124153107.2112760-1-kraxel@redhat.com> <67da33f7-5038-6732-455a-2576f641f1c0@redhat.com> <4d8b55a7-0898-4ab3-90d0-394b3bd533de@amd.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZdpTMsRJYVOWLmqHszJytyaDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FzE9hbb1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/25/24 08:50, Gerd Hoffmann wrote: > On Wed, Jan 24, 2024 at 05:43:29PM -0800, Erdem Aktas wrote: >> Same for TDX, I did not run it but it should cause failure >> as debugShowPostCode is called OvmfPkg/ResetVector/Ia32/IntelTdx.asm bef= ore >> actually the #VE handlers are installed. >> >>> Had a meeting get canceled and so got a chance to test this. As I thoug= ht, >>> this causes SEV-ES/SEV-SNP guest failures. >=20 > Hmm, I guess that pretty much kills the idea. The first post code is > sent before probing for TDX/SEV happens ... Can we salvage it, but make it depend on a minimal source code tweak (ungating)? Changing a single line for debugging (non-TDX / non-SEV-ES guests, anyway) is much easier than coming up with this patch from zero, whenever needed. Can we add "DebugCon.asm" to the tree, plus a *comment* near %include "DebugDisabled.asm" about "DebugCon.asm"? Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114460): https://edk2.groups.io/g/devel/message/114460 Mute This Topic: https://groups.io/mt/103933942/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-