From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A124421163DEE for ; Mon, 8 Oct 2018 19:54:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 19:54:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,359,1534834800"; d="scan'208";a="79849475" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 08 Oct 2018 19:54:16 -0700 To: Jim.Dailey@dell.com Cc: michael.d.kinney@intel.com, liming.gao@intel.com, edk2-devel@lists.01.org References: <7a3d9037-6525-32a2-b244-b382d69972e4@Intel.com> From: "Ni, Ruiyu" Message-ID: <060d11fe-ffce-0d7f-00af-bd3353ce990e@Intel.com> Date: Tue, 9 Oct 2018 10:55:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] MdePkg-BaseLib: Fix PathCleanUpDirectories() error involving "\..\.." X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 02:54:24 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/8/2018 9:23 PM, Jim.Dailey@dell.com wrote: >> -----Original Message----- >>> >>> diff --git a/MdePkg/Library/BaseLib/FilePaths.c b/MdePkg/Library/BaseLib/FilePaths.c >>> index d6f3758ecb..5d3de01894 100644 >>> --- a/MdePkg/Library/BaseLib/FilePaths.c >>> +++ b/MdePkg/Library/BaseLib/FilePaths.c >>> @@ -2,6 +2,7 @@ >>> Defines file-path manipulation functions. >>> >>> Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.
>>> + Copyright (c) 2018, Dell Technologies. All rights reserved.
>>> This program and the accompanying materials >>> are licensed and made available under the terms and conditions of the BSD License >>> which accompanies this distribution. The full text of the license may be found at >>> @@ -103,7 +104,9 @@ PathCleanUpDirectories( >>> ) { >>> *(TempString + 1) = CHAR_NULL; >>> PathRemoveLastItem(Path); >>> - CopyMem (Path + StrLen (Path), TempString + 3, StrSize (TempString + 3)); >>> + if (*(TempString + 3)) { >>> + CopyMem (Path + StrLen (Path), TempString + 4, StrSize (TempString + 4)); >>> + } I just setup a debugging environment to trace the code. Finally I understand the issue. I agree to change "TempString + 3" to "TempString + 4". This can eliminate double slash so in next same loop, the pattern "\\..\\" or "\\..\0" can be detected and "last item" can be correctly removed by PathRemoveLastItem(). Can you change "if (*(TempString + 3))" to "if (*(TempString + 3) != CHAR_NULL)"? With the above change, Reviewed-by: Ruiyu Ni If you agree, I can modify your patch and push it for you. >>> } >>> >>> // >>> >> Jim, >> Are you fixing a corner case bug introduced by following commit: >> >>> SHA-1: bb99e3282c9e69fbd6365d117c58d15589e34c5d >> * MdePkg/BaseLib: Fix PathCleanUpDirectories to correctly handle "\.\" >> >>> The old code incorrectly cleans path like "fs0:\abc\.\.." to >>> "fs0:\abc", instead of "fs0:\" >> >>> The patch fixes this bug. > > Honestly, because of the scope of bb99e328, I cannot say for sure, but > my inclination is to answer "No." > > The current fix is strictly related to handling paths that include two > or more references to the previous directory, whether or not one of them > abuts a reference to the current directory (as in the bb99e328 fix). > > Regards, > Jim > -- Thanks, Ray