From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.4208.1587488813015489843
 for <devel@edk2.groups.io>;
 Tue, 21 Apr 2020 10:06:53 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B89C1FB;
	Tue, 21 Apr 2020 10:06:51 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CE853F73D;
	Tue, 21 Apr 2020 10:06:50 -0700 (PDT)
Subject: Re: [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms
To: "Wu, Hao A" <hao.a.wu@intel.com>,
 Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 Laszlo Ersek <lersek@redhat.com>, "Bi, Dandan" <dandan.bi@intel.com>,
 "Gao, Liming" <liming.gao@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200410152925.6119-1-samer@elhajmahmoud.com>
 <20200410152925.6119-2-samer@elhajmahmoud.com>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C9EC3AD@SHSMSX104.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <0610beeb-d0d4-8b33-ca26-e249a29e34b4@arm.com>
Date: Tue, 21 Apr 2020 19:06:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9EC3AD@SHSMSX104.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/21/20 10:54 AM, Wu, Hao A wrote:
>> -----Original Message-----
>> From: Samer El-Haj-Mahmoud [mailto:samer@elhajmahmoud.com]
>> Sent: Friday, April 10, 2020 11:29 PM
>> To: devel@edk2.groups.io
>> Cc: Bi, Dandan; Gao, Liming; Wang, Jian J; Wu, Hao A; Leif Lindholm; Ard
>> Biesheuvel
>> Subject: [edk2][PATCH v2 1/2] MdeModulePkg:
>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>
>> Set the default value of PcdAcpiExposedTableVersions for Aarch64
>> platforms to 0x20. Previously, the default was set to 0x3E for all
>> platforms. The new value removes ACPI 1.0b compatability, which forces
>> the use of XSDT 64-bit pointer, as required by Arm SBBR specification.
>> This also resolves an error reported by acpiview command, as seen on
>> the RPi (see https://github.com/pftf/RPi4/issues/25).
>>
>> Cc: Dandan Bi <dandan.bi@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>
>> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>>   MdeModulePkg/MdeModulePkg.dec | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dec
>> b/MdeModulePkg/MdeModulePkg.dec
>> index 497574cb0870..fac16f262cf8 100644
>> --- a/MdeModulePkg/MdeModulePkg.dec
>> +++ b/MdeModulePkg/MdeModulePkg.dec
>> @@ -1548,6 +1548,9 @@
>>     # @Prompt Console Output Row of Text Setup
>>
>> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
>> 00000e
>>
>> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
>> +
>> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UI
>> NT32|0x0001004c
>> +
> 
> 
> Sorry for the slow response.
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
> 

Series pushed and merged as #535

Thanks all