From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.73225.1675734223566271362 for ; Mon, 06 Feb 2023 17:43:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=JYhs55W/; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6C775CD1F671 for ; Tue, 7 Feb 2023 09:43:40 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1675734220; bh=zL60QdJnnsfGVRlJNpU5OdRyGayQF9azJDrtFXWWePg=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=JYhs55W/Orge3RUeNwsT83fuKwQfgZtNwa2NOH5sO4MeGgEfG34TOtPbptLxssisi rwJdcsf4VJCaNTC0VjM6+ZOj1x3dj3tEQTuW41KpNfANxSvTjj78eLIpb6VwZZLzNm HM/BrI+2ZxbEXoqLjVMoTGr50LbxOgqlzJpEVU20= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 67EF2CD1F663 for ; Tue, 7 Feb 2023 09:43:40 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 3D264CD1F64A for ; Tue, 7 Feb 2023 09:43:40 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id B692ECD1F699 for ; Tue, 7 Feb 2023 09:43:37 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 07 Feb 2023 09:43:35 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Wang, Jian J'" Cc: "'Ni, Ray'" References: <1738869DA53A568A.3916@groups.io> <018a01d936b3$e6716fa0$b3544ee0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVNb2R1bGVQa2c6IERpc2FtYmlndWF0ZSB0aGUgbWVhbmluZyBvZiBQY2REeGVJcGxTd2l0Y2hUb0xvbmdNb2Rl?= Date: Tue, 7 Feb 2023 09:43:35 +0800 Message-ID: <061401d93a95$985892e0$c909b8a0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQE3UZoqHR7j+zTEB7rs4vcjf56A7gLgzOsPAW3KEhEBxGjWN6/V7/AQ Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn OK. I will merge it today.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Zhiguang Liu > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B42=E6=9C=883=E6=97=A5 1= 5:49 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Gao, Liming ; > Wang, Jian J > =E6=8A=84=E9=80=81: Ni, Ray > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate t= he meaning > of PcdDxeIplSwitchToLongMode >=20 > Thanks Liming for reviewing this patch. > Could you help push this change? >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > gaoliming via groups.io > > Sent: Thursday, February 2, 2023 11:10 AM > > To: Liu, Zhiguang ; devel@edk2.groups.io; Wang, > > Jian J > > Cc: Ni, Ray > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH] MdeModulePkg: Disambi= guate the > > meaning of PcdDxeIplSwitchToLongMode > > > > It is good to me. Reviewed-by: Liming Gao > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Liu, Zhiguang > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B42=E6=9C=881=E6=97= =A5 13:28 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Liu, Zhiguang ; > > > Gao, Liming ; Wang, Jian J > > > > > > =E6=8A=84=E9=80=81: Ni, Ray > > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH] MdeModulePkg: Disambigua= te the > > meaning of > > > PcdDxeIplSwitchToLongMode > > > > > > Hi Liming and Jian, > > > > > > What do you think about this patch? > > > > > > Thanks > > > Zhiguang > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > > > Zhiguang Liu > > > > Sent: Monday, January 9, 2023 11:34 AM > > > > To: devel@edk2.groups.io > > > > Cc: Liu, Zhiguang ; Wang, Jian J > > > > ; Gao, Liming ; Ni= , > > > > Ray > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the > > meaning > > > > of PcdDxeIplSwitchToLongMode > > > > > > > > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, > > > > indicating whether need switch to long mode when loading DxeCore. > > > > However, the comments in dec are confusing for the case where PEI > > > > core and DXE core are both in 64-bit. This patch makes it clear. > > > > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and > > switch > > > > to long mode to load 64-bit DXE core. In other cases, this PCD is f= alse. > > > > This also aligns with current usage in OvmfPkg. > > > > > > > > Cc: Jian J Wang > > > > Cc: Liming Gao > > > > Cc: Ray Ni > > > > Signed-off-by: Zhiguang Liu > > > > --- > > > > MdeModulePkg/MdeModulePkg.dec | 4 +--- > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > > > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > > > > 100644 > > > > --- a/MdeModulePkg/MdeModulePkg.dec > > > > +++ b/MdeModulePkg/MdeModulePkg.dec > > > > @@ -922,10 +922,8 @@ > > > > > > > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > > > ## Indicates if DxeIpl should switch to long mode to enter DXE > phase. > > > > - # It is assumed that 64-bit DxeCore is built in firmware if it > > > > is > > true; > > > > otherwise 32-bit DxeCore > > > > - # is built in firmware.

> > > > # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long > > > mode to hand > > > > over to DxeCore.
> > > > - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack > > switch > > > to > > > > hand over to DxeCore.
> > > > + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perf= orm > > > stack > > > > switch to hand over to DxeCore.
> > > > # @Prompt DxeIpl switch to long mode. > > > > > > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > > > > OOLEAN|0x0001003b > > > > > > > > -- > > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20