From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 156D4D8078A for ; Thu, 28 Mar 2024 01:12:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fZ77r3Toh82BbY+VCCJt43khpaBa/zuuQWUT40traWU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1711588363; v=1; b=NZS2IpqW61ogi/ewGwlIKNl1VA+uGRy0ydcgsNV9g+0FSUKvmV9hf/DsPvtd6tYLvR4k2xao dwx+rFnDbL2O3RYfmLxIbghnawDH/Z6wcfCw6LzcAFYOQ/O2kJ00F6Tzve4foEC96QCK5ViXQzH 7BUV+euoti5nay6vUk0x/bkvrYsSNiInxomDI9gJbXJ3X9LCaVSx9csdzVFxw3AFc9OMZl6iWXm XLY2dbIJwKMZxTb0Tojwcyzd6YPRm3aKlFk7Hxd+sjE9BF20AWITWXPOlQimT3BR8i/N/m7YNVv o3QVv/6xOk6HsjIJXVeh9e/AGzrW1J0VAOiMXNtVWzCyg== X-Received: by 127.0.0.2 with SMTP id nCVuYY7687511xUrPGK7eMsV; Wed, 27 Mar 2024 18:12:43 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.4640.1711588362407994533 for ; Wed, 27 Mar 2024 18:12:43 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id B2056A32E15B for ; Thu, 28 Mar 2024 09:12:39 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 8D8CFA32E12B for ; Thu, 28 Mar 2024 09:12:39 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id D7B66A32E0D3 for ; Thu, 28 Mar 2024 09:12:36 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 28 Mar 2024 09:12:33 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Hao A Wu'" , "'Ray Ni'" , "'More Shih'" References: <20240314133945.3018-1-ian.chiu@intel.com> In-Reply-To: <20240314133945.3018-1-ian.chiu@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVNb2R1bGVQa2cvWGhjaUR4ZTogSW5jcmVhc2UgMW1zIGV4dHJhIGRlbGF5IGZvciB4SENJIGlzc3VlIEhDUlNU?= Date: Thu, 28 Mar 2024 09:12:36 +0800 Message-ID: <062801da80ad$05985da0$10c918e0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQF9FtEBwxC0ujmMGO4lPLZ4lqZhKLIHLCQw Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 18:12:43 -0700 Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lLlyWgm1da7rNwuRqvjUDmFyx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=NZS2IpqW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Seemly, this change has no other impact. I agree this change.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Chiu, Ian > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA3=D4=C214=C8=D5 21:40 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Ian Chiu ; Hao A Wu ; Ray > Ni ; More Shih > =D6=F7=CC=E2: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Increase 1ms ext= ra > delay for xHCI issue HCRST >=20 > From: Ian Chiu >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4727 >=20 > More and more XHCI host controllers require to have extra 1ms > delay before accessing any MMIO register during reset. >=20 > Since PHY transition from P3 to P0 can take around 1.3ms and > the xHCI reset can take around 1.5ms. >=20 > Hence, need delay increase between issuing HCRST on xHCI > controller till first MMIO read for reset completion check. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: More Shih > Signed-off-by: Ian Chiu > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > index 40f2f1f227..eafe4b0d11 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > @@ -861,10 +861,11 @@ XhcResetHC ( > XhcSetOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET); >=20 > // >=20 > // Some XHCI host controllers require to have extra 1ms delay before > accessing any MMIO register during reset. >=20 > + // PHY transition from P3 to P0 can take around 1.3ms and the xHCI > reset can take around 1.5ms. >=20 > // Otherwise there may have the timeout case happened. >=20 > - // The below is a workaround to solve such problem. >=20 > + // Stall for 2ms workaround to solve such problem. >=20 > // >=20 > - gBS->Stall (XHC_1_MILLISECOND); >=20 > + gBS->Stall (XHC_1_MILLISECOND*2); >=20 > Status =3D XhcWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET, > XHC_USBCMD_RESET, FALSE, Timeout); >=20 >=20 >=20 > if (!EFI_ERROR (Status)) { >=20 > -- > 2.38.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#116751): > https://edk2.groups.io/g/devel/message/116751 > Mute This Topic: https://groups.io/mt/104926466/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117187): https://edk2.groups.io/g/devel/message/117187 Mute This Topic: https://groups.io/mt/105189543/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-