From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.87]) by mx.groups.io with SMTP id smtpd.web10.21363.1680086988320817208 for ; Wed, 29 Mar 2023 03:49:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=tzLmTT3u; spf=pass (domain: arm.com, ip: 40.107.21.87, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=70JnbsYfLU2J+SCsKH9enUVWy2z69AEbVop0/oHWorw=; b=tzLmTT3u9hMbipccjWkIbwPeguibniiOgfEiJt9WJUn7JbxDWlv/0EOJLtpFkVgfrU0IJI2iZXYxfeqd6fdCprxHkc6qvTpeAyyS444RjOTHZiLvsuVMkDHo2VkE2lFhvah5UmGZ7xnwKMq/FrVVpEnGPEVuLm6LHGaQ8NoJehU= Received: from AS9PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:20b:462::14) by AM0PR08MB5332.eurprd08.prod.outlook.com (2603:10a6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.34; Wed, 29 Mar 2023 10:49:44 +0000 Received: from AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:462:cafe::d5) by AS9PR06CA0022.outlook.office365.com (2603:10a6:20b:462::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.20 via Frontend Transport; Wed, 29 Mar 2023 10:49:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT019.mail.protection.outlook.com (100.127.140.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.20 via Frontend Transport; Wed, 29 Mar 2023 10:49:44 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Wed, 29 Mar 2023 10:49:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a4cf786b5e1b5fb6 X-CR-MTA-TID: 64aa7808 Received: from c2a68e65e590.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5BB7ACDB-7E31-419D-8E0A-6D2A3E053A27.1; Wed, 29 Mar 2023 10:49:37 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2a68e65e590.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 29 Mar 2023 10:49:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IR9A8THc6bW/MTwJc66lq+ybiWg0QDj8uFGyFwV7lze3x4XBSUAySsDMr5tlauCHxmM24KXvfE+de/fzlF7dqXtJ5XRtfJxbSxBHwE2pwQxndiTxIQAsdtp7AGOlprMI1mA+6Lotn1nwn801IeYX8QWqMEaF0LKrUThD8Tzk2iIua8yAH3MIXa7j7WrgxanZlViGgjKX0KkigniSlQ7kUzaXJOKLTCI1m0DmAXReyNN2Oyd31/jyfbnrFv4u2lKrMwCd/AS8yJH50ZuS+ikSFJOqQ5/lHFFzEaBDk5rkmYkvuj45bgOLbMA0I+EocCiHsGmjyu1FoN5KErmHVjxqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=70JnbsYfLU2J+SCsKH9enUVWy2z69AEbVop0/oHWorw=; b=cGFMk48UqACr7cWsx58WJ04KgiQv61dFbweQ+hIFaEW6YBkNafrsL9M5+gBx+kXUsYXrdbYf9opJPhcUC9SFqcDBcN40j8Hv8IkZSwEFRWXHjqGrxSEbl+/2WrBXKd0BBE4m+Bw5Dvrzmxd06veEQ5qfocZXoVah8E3iQWNPr/rO3HGAWpt6XU1nYL3e5OfX9BlGI6XpYw8r9wVYjktibXIpVNRc+N8MPs1VgB5oli9l/UCCJ8jkT7F+cnBAGsHfApqv7Zv5ZhatkOEaCBWFjaj5YRr3iOdz6zlpCTjYLbqjxLWOB1EgUzb1ubwWf9TSXA/VGOJuSXWNXZYnAFwYCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=70JnbsYfLU2J+SCsKH9enUVWy2z69AEbVop0/oHWorw=; b=tzLmTT3u9hMbipccjWkIbwPeguibniiOgfEiJt9WJUn7JbxDWlv/0EOJLtpFkVgfrU0IJI2iZXYxfeqd6fdCprxHkc6qvTpeAyyS444RjOTHZiLvsuVMkDHo2VkE2lFhvah5UmGZ7xnwKMq/FrVVpEnGPEVuLm6LHGaQ8NoJehU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GVXPR08MB7799.eurprd08.prod.outlook.com (2603:10a6:150:3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.41; Wed, 29 Mar 2023 10:49:35 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::c224:ef61:cd4c:7727]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::c224:ef61:cd4c:7727%7]) with mapi id 15.20.6222.035; Wed, 29 Mar 2023 10:49:35 +0000 Message-ID: <06319e3d-9b2b-c92d-7d32-8c569b179b76@arm.com> Date: Wed, 29 Mar 2023 11:49:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool To: devel@edk2.groups.io, ardb+tianocore@kernel.org CC: quic_llindhol@quicinc.com, kraxel@redhat.com, pierre.gondois@arm.com, Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20230320140557.40348-1-sami.mujawar@arm.com> From: "Sami Mujawar" In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> X-ClientProxiedBy: LO2P123CA0087.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::20) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GVXPR08MB7799:EE_|AM7EUR03FT019:EE_|AM0PR08MB5332:EE_ X-MS-Office365-Filtering-Correlation-Id: 62c732f1-4906-4e60-b76a-08db30434eda x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SBevJnsI6jiaigv6mxAydpWdRG5j14R8tBs2v08xXR11p9SzXxzxJy69spMKvcQtoO2nCwseCjcBqbudnqDI2ryTZxe7J5aqOia1MkvRjYouuw/s5MW2n9FGD2lNw5k0Tu/ds6fxFBLvOfGzQA/ug0ix4lqHgRFwVd9dfIJywBXuBiXTz8dJ2NzKQm8NHCUIvvPQKiVmiujbyYZeQfuMlErMFEzZ8uTBIBnvDOmXpRUXKstbhkBfiXHMAkgr7RD3xnlFNCyHnHH81u9yujePOGKuK0t4of27mGt1U4fSfrHRGhwhmXAbwakkivy3QkGXPvqU+MYaTc9DnxTxvNApnAP+HC7wuZtx6o1zyXcKeTSpa7vNgmJuMfEbkST8vsoDTXUihsU8iFxknIHKsvFDdji2E7koe33Z+U6qS3IwduLDszB7eN711NhInTiuLvjXoGn4kzgiUAPS93UMpHEUoOMe2YkEU9XVP7DHjLAF3vVG2uLGSqZwoxgkpwGvOf1rw/Cq/dbjbZJKsByQp5vEZWK87cz8WWin2dVF6pCV4wkaMxpVxVJ76SctW2XNXTv4WFhT3Uh/KSk1uAeUBqroZyR6k1mZy+OUpjgw9KwEb8VBLd0owbDvxKSN+0BqO5jvLfAYzmcIS+ysi3lffwIbPA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199021)(26005)(2906002)(86362001)(83380400001)(31696002)(2616005)(66556008)(8676002)(186003)(5660300002)(66476007)(41300700001)(36756003)(8936002)(6506007)(66946007)(6486002)(4326008)(38100700002)(44832011)(19627235002)(316002)(6512007)(966005)(53546011)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7799 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 334cd9a7-191b-4530-28f4-08db3043490d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0TE020aWQAeLwDCdRQkVDcg42xtNkdR2Rill392+0Ao/y58z5bqFfNbH6FIJW2wYhFHjsiA+ZESaiTCDUL3Ep1wJYlt2Cu8qOaavlmddF0vg4oFVNcu1Mfpcfn72n7uzYaT3UTtuJoeOaqH9XXdibJ518/5I453O7FJi9kfE1PhgXHUZxWqiqC3gNZOE4mowkDCMbwV440C6taJnEewFCLwZQSPMyGC1RqD5KyHTS0dbBkO3sCkC6rvVf0z9fyE9wv3h2J3SQlAgPTZkPgxfZQvRF/2bB1Azc9oMJcxG03+kWPOyPzh8AdQkkwsqMP3UHNuV1gnXrP/YlezX9Iw8iHFTF58sLLMgUBBYHCG4aDbrYUckqw9pXb5AFPtKdW6ksFxtXWB+mOsjjn6T1OOt8r26B6jzuoOsTFRtII4/Jkkkh0aORCP3Cqa+A2mhXcchuOmWsq7SmgIUtfRAhjGHuZULKe3wp7/+pgYghkwTpZCMM4wQ6mvxLYo9yNNbz5PCen7Y/SFjxx3lUr0iI3DWwJoOCj6MHCJ+7X4HAE+en55uOBFRodltIYNGqKwje5JR78Gdzd0811JgP6r082MAAo/JjVoD7JA/hvYEjU5I2BXmm9NqQEX9FamMCg5k/Xnn6lACbQjyjHmmWBRtFoJaSBp3pYjfIG+MBbJWQ8J81wQHRXxbFIzTyipNc1hPdiVjTX33Y69a0uIhT8szUBl2uItS2DUJ2tUOYVO1a7KPZDo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(26005)(966005)(82310400005)(82740400003)(40460700003)(356005)(81166007)(336012)(19627235002)(316002)(2616005)(41300700001)(83380400001)(70206006)(70586007)(36860700001)(8676002)(478600001)(36756003)(4326008)(186003)(6506007)(53546011)(6512007)(8936002)(5660300002)(31696002)(44832011)(86362001)(2906002)(40480700001)(6486002)(31686004)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 10:49:44.6330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62c732f1-4906-4e60-b76a-08db30434eda X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5332 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ard, I am occassionally seeing the following error when trying to run the=20 Kvmtool guest firmware. =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 a= dd-symbol-file=20 w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg= \PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\PcRtc.dll=20 0xBBF80000 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 L= oading driver at 0x000BBF70000 EntryPoint=3D0x000BBF82958=20 PcRtc.efi =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 F= ailed to set memory attributes. Status =3D 00000002 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Failed = to map memory for motorola,mc146818. Status =3D 00000002 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT_= EFI_ERROR (Status =3D 00000002) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ASSERT = [PcRtc]=20 w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg= \PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\AutoGen.c(49= 4):=20 !(((INTN)(RETURN_STATUS)(Status)) < 0) I am not sure why this issue only surfaces sometimes (which is=20 worrying). However, the fix for this is patch 4/4 in this series. Is it possible to review the ArmVirtPkg changes and if I have your=20 approval to merge this series, please? Regards, Sami Mujawar On 20/03/2023 02:05 pm, Sami Mujawar wrote: > This patch series has the following fixes for DynamicTablesPkg and > ArmVirtPkg/Kvmtool: > > 1. Reduces the log output from TableHelperLib in DynamicTablesPkg. > 2. Fixes issue with parsing of the serial port node in > ArmSerialPortParser in DynamicTablesPkg and > EarlyFdt16550SerialPortHookLib in ArmVirtPkg. This issue > was not observed until another entry was added in the 'chosen' > node in the DT when doing some experiments. > 3. Fixes the DEPEX in the Kvmtool guest RTC library as the missing > dependency on CPU Architecture protocol would cause occasional > failures. > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2596_bug_fix_dynamictables_kvmto= ol_v1 > > Sami Mujawar (4): > DynamicTablesPkg: Reduce log output from TableHelperLib > DynamicTablesPkg: Fix parsing of serial port node > ArmVirtPkg: Fix parsing of serial port node > ArmVirtPkg: Fix depex in kvmtool guest Rtc library > > ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHoo= kLib.c | 4 +-- > ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf = | 4 +-- > DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObje= ctParser.c | 28 ++++++++++---------- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.= c | 4 +-- > 4 files changed, 20 insertions(+), 20 deletions(-) >