public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License
Date: Thu, 4 Apr 2019 14:27:58 +0200	[thread overview]
Message-ID: <064b9cca-4fa9-bac2-9cc1-6ac4a5379973@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C78D34@ORSMSX112.amr.corp.intel.com>

Hi Mike,

On 04/04/19 01:42, Michael D Kinney wrote:
> Hello,
> 
> New in V3
> =========
> * Update the base of the patch series from edk2-stable201903 to
>   7ed72121b7 that is after the file add/remove freeze:
> 
>   https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html
> 
> * Replace copyright line in License.txt in root with a single copyright
>   for "TianoCore and contributors".
> * Clarify commit message for changes to License.txt to state the text 
>   differences are larger than expected due to differences in line breaks.
> * There is one less patch in the series than V2 due to the retirement
>   of the EdkCompatibilityPkg.
> * The git feature "git range-diff" can be used to compare the V2 and
>   V3 branches even though they have different bases.  If you have both
>   the V2 and V3 branches in your local repo, you can use the following 
>   command to see the changes.  Most are due to the removal of .S files
>   in March.  If you pipe through grep looking for "diff --git" you will
>   see the list of files with differences.
> 
>   git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2 7ed72121b7..Bug_1373_BsdPatentLicense_V3

Didn't you intend to pick up feedback tags from previous reviews?

Anyway,

> c910bd4e91 ArmVirtPkg: Replace BSD License with BSD+Patent License

This patch has not been changed in v3, so I can repeat, from my v2
review at
<http://mid.mail-archive.com/ea8c496c-882f-aea8-fa07-833f9e42bfaa@redhat.com>:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License

The seven new files under "OvmfPkg/SioBusDxe" are covered now, and the
"create-release.py" hunk has been dropped.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent

Not changed relative to v2, so I can repeat my:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks!
Laszlo

  reply	other threads:[~2019-04-04 12:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 23:42 [edk2] [PATCH V3] Change EDK II to BSD+Patent License Michael D Kinney
2019-04-04 12:27 ` Laszlo Ersek [this message]
2019-04-04 22:27 ` [edk2-devel] " Ma, Maurice
2019-04-05  9:40 ` Ni, Ray
2019-04-05 21:39 ` Michael D Kinney
2019-04-08  1:21   ` [edk2-devel] " Ni, Ray
2019-04-08  1:41   ` Wu, Hao A
2019-04-08  1:44   ` Dong, Eric
2019-04-08  1:50   ` Wu, Hao A
     [not found]   ` <B80AF82E9BFB8E4FBD8C89DA810C6A093C8BCAAE@SHSMSX104.ccr.corp.intel.com>
     [not found]     ` <7CB7EF03E15B5D48981329A508747A9850C4FB75@SHSMSX104.ccr.corp.intel.com>
2019-04-08  5:20       ` yi.qian
2019-04-08  9:01     ` Sun, Zailiang
2019-04-08 20:25   ` Michael D Kinney
2019-04-09  9:46     ` [edk2-devel] " Laszlo Ersek
     [not found]   ` <E92EE9817A31E24EB0585FDF735412F5B9C8A6A3@ORSMSX113.amr.corp.intel.com>
     [not found]     ` <DB6PR0802MB2375A8D702667DC83C2AAC07842D0@DB6PR0802MB2375.eurprd08.prod.outlook.com>
2019-04-09 18:43       ` Michael D Kinney
     [not found]       ` <E92EE9817A31E24EB0585FDF735412F5B9C8D207@ORSMSX113.amr.corp.intel.com>
2019-04-09 18:45         ` Sami Mujawar
2019-04-07 23:35 ` Carsey, Jaben
2019-04-08  1:20 ` [edk2-devel] " Siyuan, Fu
2019-04-08  2:04 ` BobCF
2019-04-08  2:31 ` Wang, Jian J
2019-04-08  3:34 ` [edk2-devel] " chasel.chiu
2019-04-08  4:44 ` Liming Gao
2019-04-08  4:46 ` Wang, Jian J
2019-04-08  5:01 ` [edk2-devel] " yi.qian
2019-04-08  5:10 ` Liming Gao
2019-04-08  5:30   ` [edk2-devel] " chasel.chiu
2019-04-08 12:12 ` Laszlo Ersek
2019-04-08 16:57   ` Michael D Kinney
  -- strict thread matches above, loose matches on Subject: below --
2019-04-08  5:25 zailiang.sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=064b9cca-4fa9-bac2-9cc1-6ac4a5379973@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox