From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Apr 2019 05:28:01 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C4C5A99CDF; Thu, 4 Apr 2019 12:28:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-104.rdu2.redhat.com [10.10.120.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D2A8183FB; Thu, 4 Apr 2019 12:27:59 +0000 (UTC) Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License To: devel@edk2.groups.io, michael.d.kinney@intel.com References: From: "Laszlo Ersek" Message-ID: <064b9cca-4fa9-bac2-9cc1-6ac4a5379973@redhat.com> Date: Thu, 4 Apr 2019 14:27:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 04 Apr 2019 12:28:00 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Mike, On 04/04/19 01:42, Michael D Kinney wrote: > Hello, > > New in V3 > ========= > * Update the base of the patch series from edk2-stable201903 to > 7ed72121b7 that is after the file add/remove freeze: > > https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html > > * Replace copyright line in License.txt in root with a single copyright > for "TianoCore and contributors". > * Clarify commit message for changes to License.txt to state the text > differences are larger than expected due to differences in line breaks. > * There is one less patch in the series than V2 due to the retirement > of the EdkCompatibilityPkg. > * The git feature "git range-diff" can be used to compare the V2 and > V3 branches even though they have different bases. If you have both > the V2 and V3 branches in your local repo, you can use the following > command to see the changes. Most are due to the removal of .S files > in March. If you pipe through grep looking for "diff --git" you will > see the list of files with differences. > > git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2 7ed72121b7..Bug_1373_BsdPatentLicense_V3 Didn't you intend to pick up feedback tags from previous reviews? Anyway, > c910bd4e91 ArmVirtPkg: Replace BSD License with BSD+Patent License This patch has not been changed in v3, so I can repeat, from my v2 review at : Reviewed-by: Laszlo Ersek > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License The seven new files under "OvmfPkg/SioBusDxe" are covered now, and the "create-release.py" hunk has been dropped. Reviewed-by: Laszlo Ersek > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent Not changed relative to v2, so I can repeat my: Reviewed-by: Laszlo Ersek Thanks! Laszlo