From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
edk2-devel@lists.01.org, "Liming Gao" <liming.gao@intel.com>,
"Bob Feng" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET
Date: Tue, 5 Feb 2019 13:06:48 +0100 [thread overview]
Message-ID: <065ddcc9-0817-a653-a4cb-2f53d4f20780@redhat.com> (raw)
In-Reply-To: <54f9b083-3753-e7a9-2329-4094deac63d4@redhat.com>
On 02/05/19 13:02, Philippe Mathieu-Daudé wrote:
> On 2/5/19 10:03 AM, Laszlo Ersek wrote:
>> On 02/05/19 02:23, Philippe Mathieu-Daudé wrote:
>>> Since 9c2d68c0a299 the build tools default to the python version
>>> provided by the ${PYTHON} environment variable.
>>> However the Python3 transition is not effective before d943b0c339fe.
>>
>> (1) Do you mean "functional" rather than "effective"?
>
> Probably :)
>
>> (2) Why is this information relevant for this commit? I see that commit
>> f8d11e5a4aaa, referenced below, falls between the above two, but I'm
>> unsure if that has any special relevance.
>>
>> If the above paragraph is just background info, that's OK with me, of
>> course.
>
> Yes, I'll reword to explain the tree isn't bisectable there, or drop
> that background info.
Ah, great point; so please do keep the paragraph, just point out that
the culprit commit (f8d11e5a4aaa) couldn't be found with bisection,
because between A and B the history isn't bisectable.
Thanks!
Laszlo
prev parent reply other threads:[~2019-02-05 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 1:23 [PATCH] BaseTools: Fix build failure when specifying multiple BUILDTARGET Philippe Mathieu-Daudé
2019-02-05 9:03 ` Laszlo Ersek
2019-02-05 11:47 ` Leif Lindholm
2019-02-05 12:04 ` Laszlo Ersek
2019-02-05 21:20 ` Carsey, Jaben
2019-02-06 16:16 ` Laszlo Ersek
2019-02-05 12:02 ` Philippe Mathieu-Daudé
2019-02-05 12:06 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065ddcc9-0817-a653-a4cb-2f53d4f20780@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox