From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web11.2954.1605307427198244607
 for <devel@edk2.groups.io>;
 Fri, 13 Nov 2020 14:43:47 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Kv2neXXH;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1605307426;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wt3TmHKrXMnTWt191NwBE0rPNWmu4Ss2uminJJTrTXs=;
	b=Kv2neXXHdtn73Q03PMnfh7MOuF7OV0UAOWeMpPKJmSRAq354RL4ENf8W8lJAOxpB+vGflW
	PJZf4Fg9QsivRzgLEH5HsRIX+iccRmT5JZ6XsLIR6fKVPSNEpMPwCSb73KIe4n9AgwTzlE
	GXCQoi6izldS3ExehvQlDqtIHqEgHzI=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-209-zgpxzenVOyKC1W3dXwMF0Q-1; Fri, 13 Nov 2020 17:43:44 -0500
X-MC-Unique: zgpxzenVOyKC1W3dXwMF0Q-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32BA71005E77;
	Fri, 13 Nov 2020 22:43:43 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-113.ams2.redhat.com [10.36.112.113])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 39FB160D11;
	Fri, 13 Nov 2020 22:43:42 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v2 0/1] UefiCpuPkg: Clean up save state boundary checks and comments.
To: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>
References: <20201113000518.338-1-Mark.Wilson@amd.com>
Cc: devel@edk2.groups.io, mark.wilson@amd.com
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <066174e4-1efe-54ad-3b3d-8e558f51e4a9@redhat.com>
Date: Fri, 13 Nov 2020 23:43:41 +0100
MIME-Version: 1.0
In-Reply-To: <20201113000518.338-1-Mark.Wilson@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 11/13/20 01:05, Mark Wilson wrote:
> In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister:
>     * check width > 4 instead of >= 4 when writing upper 32 bytes.
>       - This improves the code but will not affect functionality.
> 
> Mark Wilson (1):
>   UefiCpuPkg: Clean up save state boundary checks and comments.
> 
>  UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Eric, Ray: please review this patch; I'm swamped.

Thanks
Laszlo