From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.15551.1583345407169261384 for ; Wed, 04 Mar 2020 10:10:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O+jTs4no; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583345406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dn+GIDQhm1a9ZCxHFWusynvSgUt1eOHwW8cP59dVZJs=; b=O+jTs4nopNoNSM4nXGeKTv9RbRhWjqqkQKgtDqsqpZnBY9iBQE8VrI4vEjfWZvL8u+rie1 4Q0kgnbpcNsAI+pW6Gbaf5Ha+/4+iFW7nwQYV1SsCEHJJEa5EJ8fRo8zzJaZNhU3ODR5h7 ig40gHsptZ1zoytyIcyl4iWZIGR3q20= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-DcaP6XvGNoyRZV4cnXekzw-1; Wed, 04 Mar 2020 13:09:57 -0500 X-MC-Unique: DcaP6XvGNoyRZV4cnXekzw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 422061137848; Wed, 4 Mar 2020 18:09:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-59.ams2.redhat.com [10.36.117.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66ABD8B777; Wed, 4 Mar 2020 18:09:52 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 00/16] OvmfPkg: support VCPU hotplug with -D SMM_REQUIRE To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io Cc: Ard Biesheuvel , Eric Dong , Hao A Wu , Igor Mammedov , Jian J Wang , Jiewen Yao , Jordan Justen , Michael Kinney , Ray Ni , Boris Ostrovsky References: <20200226221156.29589-1-lersek@redhat.com> <1b3d032c-0a47-e641-bb07-df200a0ca3f0@redhat.com> <5bcd4828-e222-d716-01fe-6689b2eb2328@redhat.com> From: "Laszlo Ersek" Message-ID: <0668a928-be31-8641-03aa-92ddbfc6eaa2@redhat.com> Date: Wed, 4 Mar 2020 19:09:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5bcd4828-e222-d716-01fe-6689b2eb2328@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/20 14:29, Philippe Mathieu-Daud=C3=A9 wrote: > On 3/2/20 8:59 PM, Laszlo Ersek wrote: >> On 02/26/20 23:11, Laszlo Ersek wrote: >>> Supersedes: <20200223172537.28464-1-lersek@redhat.com> >>> Bugzilla:=C2=A0=C2=A0 https://bugzilla.tianocore.org/show_bug.cgi?id=3D= 1512 >>> Repo:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 https://github.com/lersek/edk= 2.git >>> Branch:=C2=A0=C2=A0=C2=A0=C2=A0 vcpu_hotplug_smm_bz_1512_v2 >>> >>> V1 was posted at: >>> >>> * [edk2-devel] [PATCH 00/16] >>> =C2=A0=C2=A0 OvmfPkg: support VCPU hotplug with -D SMM_REQUIRE >>> >>> =C2=A0=C2=A0 https://edk2.groups.io/g/devel/message/54734 >>> =C2=A0=C2=A0 http://mid.mail-archive.com/20200223172537.28464-1-lersek@= redhat.com >>> >>> New in v2: >>> >>> - Document (in patch#11) and implement (in patch#12) the "combined" >>> =C2=A0=C2=A0 approach described here: >>> >>> =C2=A0=C2=A0 >>> http://mid.mail-archive.com/111145fc-be3d-2a9a-a126-c14345a8a8a4@redhat= .com >>> >>> =C2=A0=C2=A0 https://edk2.groups.io/g/devel/message/54754 >>> >>> =C2=A0=C2=A0 The idea is basically to make the SMM Monarch wait not jus= t until the >>> =C2=A0=C2=A0 hot-added CPU hits the normal RAM Post-SMM Pen (which is s= afe wrt. >>> =C2=A0=C2=A0 ordering, but can be attacked by the OS), but *also* until= the >>> =C2=A0=C2=A0 hot-added CPU is just about to execute RSM first (which is= a bit less >>> =C2=A0=C2=A0 safe wrt. ordering, but cannot be attacked by the OS). >>> >>> - Pick up Ard's conditional A-b for the other patches, which have not >>> =C2=A0=C2=A0 been modified. >>> >>> - Rebase to master, and retest. >> >> Thanks everyone for the feedback! >> >> I plan to push this series soon after the hard feature freeze ends, and >> edk2-stable202002 is tagged. I have three questions / remarks regarding >> that: >> >> - Phil, please tell me if you'd like me to hold the series for longer. >> (You seem to have reached the end of the series, and I'm unsure about >> the skipped patches -- maybe you want to skip them, maybe you need more >> time for them.) >=20 > I needed more time when this is too x86 specific, which is not my cup of > tea. Next time! >=20 Thanks for your reviews! Apologies for not waiting any longer -- when I started queueing the patches from this series, for the github pull req, I checked the mailing list archive, to see whether you had followed up since your response at . This was late in the morning today (at ~11:00 or so, in CET), and I didn't see my above question answered either way. I had two more series to merge, and I wanted to handle it all with a single pullreq. I'm happy to give reviewers more time; what I'd like to receive reasonably quickly is the request for more time (especially if the review is not occurring linearly over the series). Thanks! Laszlo