From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=steven.shi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C8EE5203525E4 for ; Tue, 24 Oct 2017 03:58:54 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 04:02:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="1209393777" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2017 04:02:37 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Oct 2017 04:02:37 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 19:02:35 +0800 From: "Shi, Steven" To: Laszlo Ersek , edk2-devel-01 CC: "Ni, Ruiyu" , "Dong, Eric" , Andrew Fish , Leif Lindholm , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer Thread-Index: AQHTTLZb3wzAk8eOtkG+/rYCdENtkKLy1OZQ Date: Tue, 24 Oct 2017 11:02:34 +0000 Message-ID: <06C8AB66E78EE34A949939824ABE2B313B5BBF46@shsmsx102.ccr.corp.intel.com> References: <20171024105312.18143-1-lersek@redhat.com> In-Reply-To: <20171024105312.18143-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWNmYmY2MGUtMGI3MS00YzUzLWJiOGEtNDJkY2ExNTlhZjE3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJRR1VyVWtEaXB3XC9TRHJYUjlhNnloNkRyMXh4SEZnK2dNaSt3cFJSdFJaVDVZa0JJTEhKVTN6U1lIQlpDc1NMVyJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 10:58:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, I happen hope to know how to well test the IOMMU/VT-D feature on OVMF. Can = you give me some hints? Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, October 24, 2017 6:53 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu ; Dong, Eric ; > Andrew Fish ; Leif Lindholm ; > Kinney, Michael D > Subject: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg > reviewer >=20 > UefiCpuPkg hosts a number of modules (SMM infrastructure, > MP-initialization) that may behave differently enough between > virtualization guests and physical boards that they merit regression > testing and review specifically from a virtualization perspective. >=20 > Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd o= n > all UefiCpuPkg patches. >=20 > > R: Package Reviewer: Cc address for patches and questions. Reviewers > > help maintainers review code, but don't have push access. >=20 > Cc: Andrew Fish > Cc: Eric Dong > Cc: Jeff Fan > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > Recently there have been two UefiCpuPkg patches on the list that have > each spent hardly more than 24 hours in review: >=20 > * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 > resume > finished.", 2017-10-11), >=20 > * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP > initialization logic.", 2017-10-23). >=20 > Both times, I was out of office, and didn't get a chance to comment. = The > first commit broke OVMF: >=20 > http://mid.mail-archive.com/8d678707-fb07-0326-acfd- > 878bb7e8c5d6@redhat.com > https://github.com/tianocore/edk2/commit/152e8d7670d5 >=20 > while the second commit has a good chance to break OVMF on at least > some > virt hosts: >=20 > https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html >=20 > I was not CC'd either time. Had I been CC'd, the automated out-of-off= ice > reply that I always set up would have been received on the submitter'= s > side, and I could have tested and/or commented on the patches in > question, before they were pushed. >=20 > My intent as a UefiCpuPkg Reviewer is to be inserted in the patch rev= iew > process for UefiCpuPkg. I should be explicitly CC'd; and my feedback > should please be waited upon. I think I've proved myself reasonably > responsive; I intend to follow up in a few days every time. My review > should definitely not replace Eric's review, but I'd like to get an > *official* chance to raise questions before a patch is pushed. Whenev= er > I have nothing to add, I'll send an Acked-by. Thanks. >=20 > Maintainers.txt | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Maintainers.txt b/Maintainers.txt > index c1a5723af9db..297a9bfd2b56 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -245,6 +245,7 @@ M: Jaben Carsey > UefiCpuPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg > M: Eric Dong > +R: Laszlo Ersek >=20 > UnixPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg > -- > 2.14.1.3.gb7cf6e02401b >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel