From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=steven.shi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4DF921A10986 for ; Wed, 6 Dec 2017 18:01:17 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 18:05:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,370,1508828400"; d="scan'208";a="156692926" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 06 Dec 2017 18:05:49 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Dec 2017 18:05:49 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 10:05:47 +0800 From: "Shi, Steven" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "Gao, Liming" , "Zhu, Yonghong" , "evan.lloyd@arm.com" , "lersek@redhat.com" Thread-Topic: [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM Thread-Index: AQHTbobePC8kvqoLpUic3x7g9xy01aM3IHng Date: Thu, 7 Dec 2017 02:05:46 +0000 Message-ID: <06C8AB66E78EE34A949939824ABE2B313B5E441A@shsmsx102.ccr.corp.intel.com> References: <20171206113917.6166-1-ard.biesheuvel@linaro.org> In-Reply-To: <20171206113917.6166-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDM5NWIxM2EtODQwZC00ZGRjLWFiNTUtNzY5OTI1NmRiMTM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJLbmgreWZcL1A4cmp1RzkzdEk1QTA1MklJdk44dG4rWXlZdjNuZzJoK0lhbHVwZGpLbSs5ZXZkUDJxc2lcL1ZNZmIifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 02:01:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard, I'm OK for the patch. BTW, would you mind to help add the "-Wno-unused-const-variable" in the CLA= NG38_WARNING_OVERRIDES? I happen to need add it in CLANG38 (https://bugzill= a.tianocore.org/show_bug.cgi?id=3D790) and I see it seems a shared flag for= ARM/AARCH64 as well. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Wednesday, December 6, 2017 7:39 PM > To: edk2-devel@lists.01.org > Cc: leif.lindholm@linaro.org; Gao, Liming ; Zhu, > Yonghong ; Shi, Steven ; > evan.lloyd@arm.com; lersek@redhat.com; Ard Biesheuvel > > Subject: [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for > AARCH64 and ARM >=20 > Extend the CLANG38 toolchain definition so it can be used for > ARM and AARCH64 as well. Note that this requires llvm-ar and > the LLVMgold.so linker plugin. >=20 > In preparation of doing the same for GCC5, this toolchain version > also departs from the custom of using -O0 for DEBUG builds, which > makes them needlessly slow. Instead, let's add a NOOPT flavor as > well, and enable optimization for DEBUG like the other architectures > do. (Note that this will require some trivial changes to the platform > description files) >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 98 +++++++++++++++++++- > 1 file changed, 95 insertions(+), 3 deletions(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 91b135c2e569..6ee720d7586e 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -399,8 +399,8 @@ DEFINE DTC_BIN =3D ENV(DTC_PREFIX)dtc > # Intel(r) ACPI Compiler from > # https://acpica.org/downloads > # CLANG38 -Linux- Requires: > -# Clang v3.8, LLVMgold plugin and GNU binuti= ls 2.26 > targeting x86_64-linux-gnu > -# Clang v3.9 or later, LLVMgold plugin and G= NU binutils 2.28 > targeting x86_64-linux-gnu > +# Clang v3.8, LLVMgold plugin and GNU binuti= ls 2.26 > targeting x86_64-linux-gnu, aarch64-linux-gnu or arm-linux-gnueabi > +# Clang v3.9 or later, LLVMgold plugin and G= NU binutils 2.28 > targeting x86_64-linux-gnu, aarch64-linux-gnu or arm-linux-gnueabi > # Optional: > # Required to build platforms or ACPI tables= : > # Intel(r) ACPI Compiler from > @@ -5652,6 +5652,7 @@ RELEASE_CLANG35_AARCH64_CC_FLAGS =3D > DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > *_CLANG38_*_MAKE_PATH =3D make > *_CLANG38_*_*_DLL =3D ENV(CLANG38_DLL) > *_CLANG38_*_ASL_PATH =3D DEF(UNIX_IASL_BIN) > +*_CLANG38_*_DTC_PATH =3D DEF(DTC_BIN) >=20 > *_CLANG38_*_APP_FLAGS =3D > *_CLANG38_*_ASL_FLAGS =3D DEF(IASL_FLAGS) > @@ -5663,7 +5664,8 @@ DEFINE CLANG38_X64_PREFIX =3D > ENV(CLANG38_BIN) > DEFINE CLANG38_IA32_TARGET =3D -target i686-pc-linux-gnu > DEFINE CLANG38_X64_TARGET =3D -target x86_64-pc-linux-gnu >=20 > -DEFINE CLANG38_ALL_CC_FLAGS =3D DEF(GCC44_ALL_CC_FLAGS) -Wno- > empty-body -fno-stack-protector -mms-bitfields -Wno-address -Wno-shift- > negative-value -Wno-parentheses-equality -Wno-unknown-pragmas -Wno- > tautological-constant-out-of-range-compare -Wno-incompatible-library- > redeclaration -fno-asynchronous-unwind-tables -mno-sse -mno-mmx - > msoft-float -mno-implicit-float -ftrap- > function=3Dundefined_behavior_has_been_optimized_away_by_clang - > funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno- > tautological-compare -Wno-unknown-warning-option -Wno-varargs > +DEFINE CLANG38_WARNING_OVERRIDES =3D -Wno-parentheses-equality - > Wno-tautological-compare -Wno-tautological-constant-out-of-range- > compare -Wno-empty-body -Wno-varargs > +DEFINE CLANG38_ALL_CC_FLAGS =3D DEF(GCC44_ALL_CC_FLAGS) > DEF(CLANG38_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields - > Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno- > incompatible-library-redeclaration -fno-asynchronous-unwind-tables -mno- > sse -mno-mmx -msoft-float -mno-implicit-float -ftrap- > function=3Dundefined_behavior_has_been_optimized_away_by_clang - > funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno-unknown- > warning-option >=20 > ########################### > # CLANG38 IA32 definitions > @@ -5739,6 +5741,96 @@ NOOPT_CLANG38_X64_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=3D__ > NOOPT_CLANG38_X64_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_x86_64 -Wl,-- > oformat=3Delf64-x86-64 -Wl,-pie -mcmodel=3Dsmall > NOOPT_CLANG38_X64_DLINK2_FLAGS =3D DEF(GCC5_X64_DLINK2_FLAGS) - > O0 >=20 > +################## > +# CLANG38 ARM definitions > +################## > +DEFINE CLANG38_ARM_TARGET =3D -target arm-linux-gnueabihf > +DEFINE CLANG38_ARM_CC_FLAGS =3D DEF(GCC_ARM_CC_FLAGS) > DEF(CLANG38_ARM_TARGET) DEF(CLANG38_WARNING_OVERRIDES) -mno- > movt > +DEFINE CLANG38_ARM_DLINK_FLAGS =3D DEF(CLANG38_ARM_TARGET) > DEF(GCC_ARM_DLINK_FLAGS) > + > +*_CLANG38_ARM_PP_FLAGS =3D DEF(GCC_PP_FLAGS) > +*_CLANG38_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > +*_CLANG38_ARM_APP_FLAGS =3D > +*_CLANG38_ARM_ASL_FLAGS =3D DEF(IASL_FLAGS) > +*_CLANG38_ARM_ASL_OUTFLAGS =3D DEF(IASL_OUTFLAGS) > +*_CLANG38_ARM_DTCPP_FLAGS =3D DEF(GCC_DTCPP_FLAGS) > + > +*_CLANG38_ARM_CC_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_ASM_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_PP_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_VFRPP_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_ASLCC_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_ASLPP_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_DLINK_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_ARM_ASLDLINK_PATH =3D ENV(CLANG38_BIN)clang > + > +*_CLANG38_ARM_SLINK_PATH =3D ENV(CLANG38_BIN)llvm-ar > +*_CLANG38_ARM_RC_PATH =3D ENV(CLANG38_ARM_PREFIX)objcopy > + > +*_CLANG38_ARM_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > +*_CLANG38_ARM_ASLDLINK_FLAGS =3D DEF(CLANG38_ARM_TARGET) > DEF(GCC_ARM_ASLDLINK_FLAGS) > +*_CLANG38_ARM_ASM_FLAGS =3D DEF(GCC_ASM_FLAGS) > DEF(CLANG38_ARM_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) - > Qunused-arguments > +*_CLANG38_ARM_DLINK2_FLAGS =3D > DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,-- > defsym=3DPECOFF_HEADER_SIZE=3D0x220 > +*_CLANG38_ARM_PLATFORM_FLAGS =3D -march=3Darmv7-a > +*_CLANG38_ARM_PP_FLAGS =3D DEF(GCC_PP_FLAGS) > DEF(CLANG38_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > +*_CLANG38_ARM_RC_FLAGS =3D DEF(GCC_ARM_RC_FLAGS) > +*_CLANG38_ARM_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) > DEF(CLANG38_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > +*_CLANG38_ARM_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) > DEF(CLANG38_ARM_TARGET) > +*_CLANG38_ARM_CC_XIPFLAGS =3D DEF(GCC_ARM_CC_XIPFLAGS) > + > + DEBUG_CLANG38_ARM_CC_FLAGS =3D DEF(CLANG38_ARM_CC_FLAGS) > $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O3 > + DEBUG_CLANG38_ARM_DLINK_FLAGS =3D > DEF(CLANG38_ARM_DLINK_FLAGS) -flto -Wl,-O3 > + NOOPT_CLANG38_ARM_CC_FLAGS =3D DEF(CLANG38_ARM_CC_FLAGS) > $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > + NOOPT_CLANG38_ARM_DLINK_FLAGS =3D > DEF(CLANG38_ARM_DLINK_FLAGS) > +RELEASE_CLANG38_ARM_CC_FLAGS =3D DEF(CLANG38_ARM_CC_FLAGS) > $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O3 > +RELEASE_CLANG38_ARM_DLINK_FLAGS =3D > DEF(CLANG38_ARM_DLINK_FLAGS) -flto -Wl,-O3 > + > +################## > +# CLANG38 AARCH64 definitions > +################## > +DEFINE CLANG38_AARCH64_TARGET =3D -target aarch64-linux-gnu > +DEFINE CLANG38_AARCH64_CC_FLAGS =3D DEF(GCC_AARCH64_CC_FLAGS) > DEF(CLANG38_AARCH64_TARGET) -mcmodel=3Dsmall > DEF(CLANG38_WARNING_OVERRIDES) > +DEFINE CLANG38_AARCH64_DLINK_FLAGS =3D > DEF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH64_DLINK_FLAGS) -z > common-page-size=3D0x1000 > + > +*_CLANG38_AARCH64_PP_FLAGS =3D DEF(GCC_PP_FLAGS) > +*_CLANG38_AARCH64_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > +*_CLANG38_AARCH64_APP_FLAGS =3D > +*_CLANG38_AARCH64_ASL_FLAGS =3D DEF(IASL_FLAGS) > +*_CLANG38_AARCH64_ASL_OUTFLAGS =3D DEF(IASL_OUTFLAGS) > +*_CLANG38_AARCH64_DTCPP_FLAGS =3D DEF(GCC_DTCPP_FLAGS) > + > +*_CLANG38_AARCH64_CC_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_ASM_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_PP_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_VFRPP_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_ASLCC_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_ASLPP_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_DLINK_PATH =3D ENV(CLANG38_BIN)clang > +*_CLANG38_AARCH64_ASLDLINK_PATH =3D ENV(CLANG38_BIN)clang > + > +*_CLANG38_AARCH64_SLINK_PATH =3D ENV(CLANG38_BIN)llvm-ar > +*_CLANG38_AARCH64_RC_PATH =3D > ENV(CLANG38_AARCH64_PREFIX)objcopy > + > +*_CLANG38_AARCH64_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) > +*_CLANG38_AARCH64_ASLDLINK_FLAGS =3D > DEF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH64_ASLDLINK_FLAGS) > +*_CLANG38_AARCH64_ASM_FLAGS =3D DEF(GCC_ASM_FLAGS) > DEF(CLANG38_AARCH64_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) > -Qunused-arguments > +*_CLANG38_AARCH64_DLINK_FLAGS =3D DEF(CLANG38_AARCH64_TARGET) > DEF(GCC_AARCH64_DLINK_FLAGS) -z common-page-size=3D0x1000 > +*_CLANG38_AARCH64_DLINK_XIPFLAGS =3D -z common-page-size=3D0x20 > +*_CLANG38_AARCH64_DLINK2_FLAGS =3D > DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,-- > defsym=3DPECOFF_HEADER_SIZE=3D0x228 > +*_CLANG38_AARCH64_PLATFORM_FLAGS =3D > +*_CLANG38_AARCH64_PP_FLAGS =3D DEF(GCC_PP_FLAGS) > DEF(CLANG38_AARCH64_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > +*_CLANG38_AARCH64_RC_FLAGS =3D DEF(GCC_AARCH64_RC_FLAGS) > +*_CLANG38_AARCH64_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) > DEF(CLANG38_AARCH64_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > +*_CLANG38_AARCH64_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) > DEF(CLANG38_AARCH64_TARGET) > +*_CLANG38_AARCH64_CC_XIPFLAGS =3D DEF(GCC_AARCH64_CC_XIPFLAGS) > + > + DEBUG_CLANG38_AARCH64_CC_FLAGS =3D > DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > -O3 > + DEBUG_CLANG38_AARCH64_DLINK_FLAGS =3D > DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl,-O3 > + NOOPT_CLANG38_AARCH64_CC_FLAGS =3D > DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > -O0 > + NOOPT_CLANG38_AARCH64_DLINK_FLAGS =3D > DEF(CLANG38_AARCH64_DLINK_FLAGS) > +RELEASE_CLANG38_AARCH64_CC_FLAGS =3D > DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) > -O3 > +RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D > DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl,-O3 > + >=20 > ############################################################## > ###################### > # > # Cygwin GCC And Intel ACPI Compiler > -- > 2.11.0