From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=steven.shi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4FB3E221EA0A5 for ; Thu, 7 Dec 2017 17:39:39 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 17:44:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,375,1508828400"; d="scan'208";a="11571035" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 07 Dec 2017 17:44:12 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Dec 2017 17:44:12 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Dec 2017 17:44:11 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 8 Dec 2017 09:44:09 +0800 From: "Shi, Steven" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "Gao, Liming" , "Zhu, Yonghong" , "evan.lloyd@arm.com" , "lersek@redhat.com" Thread-Topic: [PATCH v2 2/3] BaseTools/tools_def CLANG38: add -Wno-unused-const-variable Thread-Index: AQHTbz3nQtM9nK1f20aS3UB7xDH9t6M4q+pA Date: Fri, 8 Dec 2017 01:44:09 +0000 Message-ID: <06C8AB66E78EE34A949939824ABE2B313B5E5258@shsmsx102.ccr.corp.intel.com> References: <20171207092851.2118-1-ard.biesheuvel@linaro.org> <20171207092851.2118-3-ard.biesheuvel@linaro.org> In-Reply-To: <20171207092851.2118-3-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmNkMTZmOWUtYTc1ZS00NDFlLTlmMmItYWI3ZmM5NTE3ZTJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJabHUwSGJtaWlHbWVVeEpqYVwvcW1tQzBrRFZOWkpyTGQ5K1lcL1FNanM1aVwvWGRhY1dZWTJ4blwvdFwvRGJCZ0RtblEifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 2/3] BaseTools/tools_def CLANG38: add -Wno-unused-const-variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 01:39:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you! Reviewed-by: Shi Steven Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, December 7, 2017 5:29 PM > To: edk2-devel@lists.01.org > Cc: leif.lindholm@linaro.org; Gao, Liming ; Zhu, > Yonghong ; Shi, Steven ; > evan.lloyd@arm.com; lersek@redhat.com; Ard Biesheuvel > > Subject: [PATCH v2 2/3] BaseTools/tools_def CLANG38: add -Wno-unused- > const-variable >=20 > Commit 8b6366f87584 ("BaseTools/GCC: set -Wno-unused-const-variable > on RELEASE builds") suppresses warnings about unused constant > variables in RELEASE builds when building with GCC, given that they > break the build under our warnings-as-errors policy. >=20 > Do the same for CLANG38. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D790 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > v2: new patch >=20 > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index c0189d4c8d30..703884fc49a7 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -5664,7 +5664,7 @@ DEFINE CLANG38_X64_PREFIX =3D > ENV(CLANG38_BIN) > DEFINE CLANG38_IA32_TARGET =3D -target i686-pc-linux-gnu > DEFINE CLANG38_X64_TARGET =3D -target x86_64-pc-linux-gnu >=20 > -DEFINE CLANG38_WARNING_OVERRIDES =3D -Wno-parentheses-equality - > Wno-tautological-compare -Wno-tautological-constant-out-of-range- > compare -Wno-empty-body -Wno-varargs > +DEFINE CLANG38_WARNING_OVERRIDES =3D -Wno-parentheses-equality - > Wno-tautological-compare -Wno-tautological-constant-out-of-range- > compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs > DEFINE CLANG38_ALL_CC_FLAGS =3D DEF(GCC44_ALL_CC_FLAGS) > DEF(CLANG38_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields - > Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno- > incompatible-library-redeclaration -fno-asynchronous-unwind-tables -mno- > sse -mno-mmx -msoft-float -mno-implicit-float -ftrap- > function=3Dundefined_behavior_has_been_optimized_away_by_clang - > funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno-unknown- > warning-option >=20 > ########################### > -- > 2.11.0