From: "Shi, Steven" <steven.shi@intel.com>
To: Zenith432 <zenith432@users.sourceforge.net>,
"Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools/GenFw: Add X64 GOTPCREL Support to GenFw
Date: Fri, 8 Jun 2018 00:32:00 +0000 [thread overview]
Message-ID: <06C8AB66E78EE34A949939824ABE2B313B7655FE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1082615057.1616071.1528351716579@mail.yahoo.com>
Next week is OK, take your time. I appreciate the test cases with build steps, thanks!
BTW, I'm not sure where is the right place in edk2 to submit a patch's test cases, but I do welcome the test case contribution.
Steven Shi
Intel\SSG\STO\UEFI Firmware
Tel: +86 021-61166522
iNet: 821-6522
> -----Original Message-----
> From: Zenith432 [mailto:zenith432@users.sourceforge.net]
> Sent: Thursday, June 7, 2018 2:09 PM
> To: Shi, Steven <steven.shi@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [PATCH] BaseTools/GenFw: Add X64 GOTPCREL Support to
> GenFw
>
> As I said in other mailing - I only tested on cases in builld. If you want
> standalone test cases I only have time next week to make some.
>
> --------------------------------------------
> On Thu, 6/7/18, Shi, Steven <steven.shi@intel.com> wrote:
>
> Subject: RE: [PATCH] BaseTools/GenFw: Add X64 GOTPCREL Support to
> GenFw
> To: "Gao, Liming" <liming.gao@intel.com>, "Zenith432"
> <zenith432@users.sourceforge.net>, "edk2-devel@lists.01.org" <edk2-
> devel@lists.01.org>
> Date: Thursday, June 7, 2018, 5:24 AM
>
> Hi Zenith,
> BTW,
> besides the build pass, did you try to run a Uefi binary,
> e.g. a simple shell application, which contain the GOTPCREL
> relocations? If yes. Please send out your test case code as
> well. I appreciate if you could contribute your test cases
> as the patch together.
>
next prev parent reply other threads:[~2018-06-08 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1082615057.1616071.1528351716579.ref@mail.yahoo.com>
2018-06-07 6:08 ` [PATCH] BaseTools/GenFw: Add X64 GOTPCREL Support to GenFw Zenith432
2018-06-08 0:32 ` Shi, Steven [this message]
[not found] <443019651.1678894.1528375563310.ref@mail.yahoo.com>
2018-06-07 12:46 ` Zenith432
[not found] <1501305711.1573406.1528351473858.ref@mail.yahoo.com>
2018-06-07 6:04 ` Zenith432
[not found] <1821667922.1236806.1528308060822.ref@mail.yahoo.com>
2018-06-06 18:01 ` Zenith432
2018-06-07 1:32 ` Gao, Liming
2018-06-07 2:15 ` Shi, Steven
2018-06-07 2:17 ` Shi, Steven
2018-06-07 2:24 ` Shi, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06C8AB66E78EE34A949939824ABE2B313B7655FE@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox