From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: steven.shi@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Tue, 28 May 2019 17:58:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 17:58:54 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 28 May 2019 17:58:54 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 May 2019 17:58:53 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 May 2019 17:58:53 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.249]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Wed, 29 May 2019 08:58:52 +0800 From: "Steven Shi" To: "Rodriguez, Christian" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Feng, Bob C" Subject: Re: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache Thread-Topic: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache Thread-Index: AQHVFS1UV2LuoWg5SkaCzpaanV4TuaaAonKggACl/hA= Date: Wed, 29 May 2019 00:58:51 +0000 Message-ID: <06C8AB66E78EE34A949939824ABE2B313FFDC3C0@shsmsx102.ccr.corp.intel.com> References: <20190528081340.14448-1-steven.shi@intel.com> <3A7DCC9A944C6149BF832E1C9B718ABC01F24593@ORSMSX112.amr.corp.intel.com> In-Reply-To: <3A7DCC9A944C6149BF832E1C9B718ABC01F24593@ORSMSX112.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWM3ZmRhMzUtMTY4NC00YzA4LWIwNTQtZGQ1MTJlYTEwMmFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSnVMazg5c2RiWHhBNDM1b1cxZno4M24xTlQyWTVQaG0yaU13TW5oOUowdkZpSlwvQk55K1AzU0lOU2RTXC9PanpxIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: steven.shi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK, will solve this issue through the fix patch of BZ 1797. Thanks Steven Shi Intel\SSG\FID\Firmware Infrastructure > -----Original Message----- > From: Rodriguez, Christian > Sent: Tuesday, May 28, 2019 11:06 PM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Feng, Bob C > Subject: RE: [edk2-devel] [PATCH] BaseTools:Fix the library dependency > missing in Binary Cache >=20 > Hi Steven, >=20 > The problem isn't that the library dependency is missing. We are missing > library artifacts and therefore cannot build the library. This can be fi= xed with > a snippet of your next patch that adds the libraries artifacts, but with= out the > extra tracking information. >=20 > Thanks, > Christian >=20 > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Steven Shi > >Sent: Tuesday, May 28, 2019 1:14 AM > >To: devel@edk2.groups.io > >Cc: Gao, Liming ; Feng, Bob C > >; Rodriguez, Christian > > > >Subject: [edk2-devel] [PATCH] BaseTools:Fix the library dependency miss= ing > >in Binary Cache > > > >BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1788 > > > >The library dependency of a module is wrongly filtered out by binary ca= che > >implementation which cause all dependent libraries will not been built = prior > to > >the module in the build scheduler and the module build fails if cache m= iss > >happen. > > > >Cc: Liming Gao > >Cc: Bob Feng > >Cc: Christian Rodriguez > >Signed-off-by: Steven Shi > >--- > > BaseTools/Source/Python/build/build.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/BaseTools/Source/Python/build/build.py > >b/BaseTools/Source/Python/build/build.py > >index 80ceb98310..673a9379ba 100644 > >--- a/BaseTools/Source/Python/build/build.py > >+++ b/BaseTools/Source/Python/build/build.py > >@@ -593,7 +593,7 @@ class BuildTask: > > # > > def AddDependency(self, Dependency): > > for Dep in Dependency: > >- if not Dep.BuildObject.IsBinaryModule and not > >Dep.BuildObject.CanSkipbyHash(): > >+ if not Dep.BuildObject.IsBinaryModule: > > self.DependencyList.append(BuildTask.New(Dep)) # Bu= ildTask list > > > > ## The thread wrapper of LaunchCommand function > >-- > >2.17.1.windows.2 > > > > > >