From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: steven.shi@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Wed, 29 May 2019 19:28:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 19:28:55 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 29 May 2019 19:28:55 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 19:28:55 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 19:28:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.134]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.188]) with mapi id 14.03.0415.000; Thu, 30 May 2019 10:28:52 +0800 From: "Steven Shi" To: Leif Lindholm , "devel@edk2.groups.io" CC: "Gao, Liming" , "Feng, Bob C" , "Rodriguez, Christian" , "Fan, ZhijuX" Subject: Re: [edk2-devel] [PATCH v2] BaseTools:Extend the binary cache to support library cache Thread-Topic: [edk2-devel] [PATCH v2] BaseTools:Extend the binary cache to support library cache Thread-Index: AQHVFg+P9DWLHVOeF0aiXwVsOLc9gaaC8oDQ Date: Thu, 30 May 2019 02:28:51 +0000 Message-ID: <06C8AB66E78EE34A949939824ABE2B313FFECB48@shsmsx102.ccr.corp.intel.com> References: <20190529014654.23276-1-steven.shi@intel.com> <20190529111336.5o3yfhzt73s5yohd@bivouac.eciton.net> In-Reply-To: <20190529111336.5o3yfhzt73s5yohd@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzY3NGYxZTEtNGJiMS00MDE0LThiMGEtOTI5OTI1ZjNlNjAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRmZVcDJkU0dCM3h0NVZ3WTg0S3FGOWJLZ3Rwck9QTmhOSmFVc1ZqWkV5U200MjNrSlJaVFwvV2FSM0pIUGhVVU0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: steven.shi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK, will move the change notices from commit message to cover letter. Thanks Steven Shi > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, May 29, 2019 7:14 PM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Feng, Bob C ; > Rodriguez, Christian ; Fan, ZhijuX > > Subject: Re: [edk2-devel] [PATCH v2] BaseTools:Extend the binary cache t= o > support library cache >=20 > On Wed, May 29, 2019 at 09:46:54AM +0800, Steven Shi wrote: > > V2 change: > > Simplify the library cache implementation and remove > > CacheRestored flag based filter. Use the current > > CanSkipbyHash() filter in AddDependency() instead. > > > > V1 change: >=20 > Please don't put change notices in the commit message. These go below > ---, or in a cover letter. >=20 > / > Leif >=20 > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1797 > > > > Current binary cache doesn't support to save and restore > > the library module. If a driver module cache miss happen, > > all its dependency library modules need rebuild which > > is very time-consuming. This patch is to entend the binary > > cache to support library. > > > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Christian Rodriguez > > Signed-off-by: Steven Shi > > --- > > BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > > index a5bef4f7c6..7b35f837f5 100644 > > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > > @@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen): > > ModuleFile =3D path.join(self.OutputDir, self.Name + '.in= f') > > if os.path.exists(ModuleFile): > > shutil.copy2(ModuleFile, FileDir) > > + else: > > + OutputDir =3D self.OutputDir.replace('\\', '/').strip('/'= ) > > + DebugDir =3D self.DebugDir.replace('\\', '/').strip('/') > > + for Item in self.CodaTargetList: > > + File =3D Item.Target.Path.replace('\\', '/').strip('/= ').replace(DebugDir, > '').replace(OutputDir, '').strip('/') > > + self.OutputFile.add(File) > > if not self.OutputFile: > > Ma =3D self.BuildDatabase[self.MetaFile, self.Arch, self.= BuildTarget, > self.ToolChain] > > self.OutputFile =3D Ma.Binaries > > -- > > 2.17.1.windows.2 > > > > > >=20 > >