From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: steven.shi@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 29 May 2019 23:33:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 23:33:13 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 29 May 2019 23:33:13 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 23:33:13 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 23:33:12 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.134]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.247]) with mapi id 14.03.0415.000; Thu, 30 May 2019 14:33:11 +0800 From: "Steven Shi" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Rodriguez, Christian" , "Fan, ZhijuX" Subject: Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache Thread-Topic: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache Thread-Index: AQHVFo/adwkLUYlpa0aDFfmNh0VClKaC9KKggABBAFA= Date: Thu, 30 May 2019 06:33:10 +0000 Message-ID: <06C8AB66E78EE34A949939824ABE2B313FFEE2B9@shsmsx102.ccr.corp.intel.com> References: <20190530023127.23228-1-steven.shi@intel.com> <20190530023127.23228-2-steven.shi@intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16012613D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16012613D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmVkNjc0ZDEtNjQyMS00NWNkLTliMzItYzRjYjcwMmFhMjg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM2h5aU9keExTczZtYk9ITlQ3MjJrSXdnMmFvSXBpQlwvdEdMQlFYRTU5YzNkK1NJSHAydVVBYjBlUDlseVdqZUEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: steven.shi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. The "entend" should be "extend", please help to fix it when pushing. T= hanks! Steven Shi > -----Original Message----- > From: Feng, Bob C > Sent: Thursday, May 30, 2019 10:44 AM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Rodriguez, Christian > ; Fan, ZhijuX > Subject: RE: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cac= he to > support library cache >=20 > The "entend" should be "extend", right? I can fix it when I push this pa= tch. >=20 > Reviewed-by: Bob Feng >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Steven Shi > Sent: Thursday, May 30, 2019 10:31 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Rodriguez, Christian ; Fan, ZhijuX > > Subject: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache t= o > support library cache >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1797 >=20 > Current binary cache doesn't support to save and restore the library mod= ule. > If a driver module cache miss happen, all its dependency library modules > need rebuild which is very time-consuming. This patch is to entend the b= inary > cache to support library. >=20 > Cc: Liming Gao > Cc: Bob Feng > Cc: Christian Rodriguez > Signed-off-by: Steven Shi > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index a5bef4f7c6..7b35f837f5 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen): > ModuleFile =3D path.join(self.OutputDir, self.Name + '.inf'= ) > if os.path.exists(ModuleFile): > shutil.copy2(ModuleFile, FileDir) > + else: > + OutputDir =3D self.OutputDir.replace('\\', '/').strip('/') > + DebugDir =3D self.DebugDir.replace('\\', '/').strip('/') > + for Item in self.CodaTargetList: > + File =3D Item.Target.Path.replace('\\', '/').strip('/')= .replace(DebugDir, > '').replace(OutputDir, '').strip('/') > + self.OutputFile.add(File) > if not self.OutputFile: > Ma =3D self.BuildDatabase[self.MetaFile, self.Arch, self.Bu= ildTarget, > self.ToolChain] > self.OutputFile =3D Ma.Binaries > -- > 2.17.1.windows.2 >=20 >=20 >=20