From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8CBFAD80CF6 for ; Mon, 11 Dec 2023 09:34:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yAUyRPyhmLJg5KcwNZHUjKepkyn0N81XUi4fpjuZDSg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1702287243; v=1; b=u+T7w9hBRHuASCGhe55XnN7U+afhdwdBDiKsDEvUOZzqvdMWGRW5sWnzTa4XanMEHe7kte4U j0LlFjTMCAuFUC33RkycSLiQeyaemcq3iS1pj6fypPKtY6TmFhG1ypGYS/P8e2G5rZBx4bTumUF lI+/SL9UcjL4r7lPFEWrjI1k= X-Received: by 127.0.0.2 with SMTP id YWjeYY7687511xR8X2Strhgr; Mon, 11 Dec 2023 01:34:03 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.4706.1702287241743388503 for ; Mon, 11 Dec 2023 01:34:02 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 32956A32DFC4 for ; Mon, 11 Dec 2023 17:33:58 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 13266A32DFF8 for ; Mon, 11 Dec 2023 17:33:58 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 060FEA32E115 for ; Mon, 11 Dec 2023 17:33:54 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 11 Dec 2023 17:33:47 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Chen, Christine'" , , "'Rebecca Cran'" , "'Zimmer, Vincent'" , "'Kinney, Michael D'" , "'Leif Lindholm'" , "'Andrew Fish'" Cc: "'Feng, Bob C'" , "'Yang, Yuting2'" , "'Hartung, Stephen'" References: <000001da1317$b227a890$1676f9b0$@byosoft.com.cn> <1797076B3E222792.28092@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItc3RhYmxlMjAyMzExXVtQQVRDSF0gQmFzZVRvb2xzOiBQeXRob24gVmZyQ29tcGlsZXIgaW1wbGVtZW50YXRpb24=?= Date: Mon, 11 Dec 2023 17:33:46 +0800 Message-ID: <06d501da2c15$240ce090$6c26a1b0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQFdLrV4TgDgtJ0Sb3dX9pOOW0EiEQKzvgVeAZmPfnOxe2IBwA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Expb4qOhYon9nEEkxMUjhXW5x7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_06D6_01DA2C58.3231F550" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=u+T7w9hB; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none ------=_NextPart_000_06D6_01DA2C58.3231F550 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Christine: Is there the change in Edk2 to apply new VfrCompiler? Can you share your c= ode branch with new VfrCompiler to pass build on Emulator or Ovmf? I would = like to try this tool first.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Chen, Christine =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B412=E6=9C=887=E6=97=A5 17= :08 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Chen, Christine ; Gao, Liming ; 'Rebecca Cran' ; Zimmer, Vincent ; Kinney, Michae= l D ; 'Leif Lindholm' ; 'Andrew Fish' =E6=8A=84=E9=80=81: Feng, Bob C ; Yang, Yuting2 ; Hartung, Stephen =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: = Python VfrCompiler implementation =20 Hi Liming, =20 Is this feature been tested and reviewed these two weeks? =F0=9F=98=8A =20 Thanks, Christine From: devel@edk2.groups.io > On Behalf Of Yuwei Chen Sent: Monday, November 13, 2023 8:32 AM To: Gao, Liming = >; 'Rebecca Cran' >; Gao, Li= ming >; Zimmer,= Vincent >; Kin= ney, Michael D >; 'Leif Lindholm' >; 'Andrew Fish' > Cc: Feng, Bob C >; Yang= , Yuting2 >; devel@= edk2.groups.io ; Hartung, Stephen > Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrC= ompiler implementation =20 Hi Liming, =20 I know your point. Would you like to start reviewing it and give us more fe= edbacks? We really hope it can be merged as soon as possible. We can do the merging after the stable tag, but just like you said, maybe w= e need to review it firstly. =20 Looking forward to your feedbacks, and I think this one is a very big step = for BaseTools. Thanks a lot for your help and contribution on this. I have created a BZ for this feature: https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D4596 Will update the patch with Bugzilla link. (This step should not influence t= he reviewing) =20 Thanks, Christine =20 From: gaoliming = >=20 Sent: Thursday, November 9, 2023 10:19 PM To: 'Rebecca Cran' >; Gao, Li= ming >; Zimmer,= Vincent >; Che= n, Christine >; Kinney,= Michael D = >; 'Leif Lindholm' >; 'Andrew Fish' > Cc: Feng, Bob C >; Yang= , Yuting2 >; devel@= edk2.groups.io ; Hartung, Stephen > Subject: RE: [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler imple= mentation =20 Christine: I can=E2=80=99t directly reply to the original mail because it is too larg= e. This is a new feature to add python version VfrCompiler. I don=E2=80=99t= think we have enough time to review the design and implementation. Althoug= h it has no real impact, its code may have many change in future. So, I sug= gest to merge it after this stable tag.=20 =20 Thanks Liming =20 Below is your request.=20 =20 Hi Liming and Cran,=20 =20 Could you help on quick reviewing this new VfrCompiler python tool, it has = the same functions with origin C version VfrCompiler, meanwhile it supports= more new features such as generated Vfr files config info into Yaml format= .=20 =20 This feature is urgent for us to use, and we really hope it can be merged i= nto this stable tag. This patch is linked to the edk2-basetools PR: https:/= /github.com/tianocore/edk2-basetools/pull/109. We list all the known issues= which will be enhanced in the ReadMe file. And will enhance them one by on= e after the patch merged. =20 For the code quality, in this patch, the new tool is not enabled in build p= rocess, it just saves in the basetools python folder, which will not influe= nce the current edk2 behaviors. We will enable it with a new patch when eve= rything is ready. =20 Many thanks~ =20 Hi Vincent, please help add more information if necessary~ Thanks a lot~ =20 Thanks, Christine =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112278): https://edk2.groups.io/g/devel/message/112278 Mute This Topic: https://groups.io/mt/103105777/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_06D6_01DA2C58.3231F550 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Christine:

=C2=A0Is there the c= hange in Edk2 to apply new VfrCompiler? Can you share your code branch with= new VfrCompiler to pass build on Emulator or Ovmf? I would like to try thi= s tool first.

 

Thanks=

Liming

=E5=8F=91=E4=BB=B6= =E4=BA=BA: Chen, Christine <yuwei.chen@intel.com>
= =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B412=E6=9C=887=E6=97=A5 17:08
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Chen, Christine <yuwei.ch= en@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; 'Rebecca Cr= an' <rebecca@bsdio.com>; Zimmer, Vincent <vincent.zimmer@intel.com= >; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm'= <quic_llindhol@quicinc.com>; 'Andrew Fish' <afish@apple.com>=E6=8A=84=E9=80=81: Feng, Bob C <bob.c.feng@intel.com>; Yang, Yuting2 <yuting2.y= ang@intel.com>; Hartung, Stephen <stephen.hartung@intel.com>
=E4=B8=BB=E9=A2=98: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler= implementation

 

Hi Liming,

 

Is= this feature been tested and reviewed these two weeks? 😊

&= nbsp;

Thanks,

Christine

From:= devel@edk2.groups.io &= lt;devel@edk2.groups.io> = On Behalf Of Yuwei Chen
Sent: Monday, November 13, 2023 8:32 = AM
To: Gao, Liming <gaoliming@byosoft.com.cn>; 'Rebecca Cran' <rebecca@bsdio.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Zimmer, Vinc= ent <vincent.zimmer@intel.co= m>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>; 'Andrew Fi= sh' <afish@apple.com>
Cc= : Feng, Bob C <bob.c.feng@in= tel.com>; Yang, Yuting2 <yuting2.yang@intel.com>; d= evel@edk2.groups.io; Hartung, Stephen <stephen.hartung@intel.com>
Subject: Re: [e= dk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler impleme= ntation

 

Hi Liming,

 

I know your point= . Would you like to start reviewing it and give us more feedbacks? We reall= y hope it can be merged as soon as possible.

We can do the merging after the stable tag, but just like = you said, maybe we need to review it firstly.

 

Looki= ng forward to your feedbacks, and I think this one is a very big step for B= aseTools. Thanks a lot for your help and contribution on this.

I have created a BZ for this feature: https://bugz= illa.tianocore.org/show_bug.cgi?id=3D4596

Will update the patch with Bugzilla link. (This step shoul= d not influence the reviewing)

 

Thanks,

Christine

 

From: gao= liming <gaoliming@byosoft.co= m.cn>
Sent: Thursday, November 9, 2023 10:19 PM
To:= 'Rebecca Cran' <rebecca@bsdio.= com>; Gao, Liming <ga= oliming@byosoft.com.cn>; Zimmer, Vincent <vincent.zimmer@intel.com>; Chen, Christine <= yuwei.chen@intel.com>; Kinne= y, Michael D <michael.d.ki= nney@intel.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>; 'Andrew Fish' <afish@apple.com>
Cc: Feng, Bob= C <bob.c.feng@intel.com>= ; Yang, Yuting2 <yuting2.yang@= intel.com>; devel@edk2.group= s.io; Hartung, Stephen <stephen.hartung@intel.com>
Subject: RE: [edk2-stable20231= 1][PATCH] BaseTools: Python VfrCompiler implementation

 

Christine:

 I can=E2=80=99t directly reply to the origi= nal mail because it is too large. This is a new feature to add python versi= on VfrCompiler. I don=E2=80=99t think we have enough time to r= eview the design and implementation. Although it has no real impact, its co= de may have many change in future. So, I suggest to merge it after this sta= ble tag.

<= o:p> 

Thank= s

Liming

 

Below is your req= uest.

 

Hi Limin= g and Cran,

 

Co= uld you help on quick reviewing this new VfrCompiler python tool, it has th= e same functions with origin C version VfrCompiler, meanwhile it supports m= ore new features such as generated Vfr files config info into Yaml format. =

 

This feature i= s urgent for us to use, and we really hope it can be merged into this stabl= e tag. This patch is linked to the edk2-basetools PR: https://github.com/tianocore/ed= k2-basetools/pull/109. We list all the known issues which will be enhan= ced in the ReadMe file. And will enhance them one by one after the patch me= rged.

=  

For the c= ode quality, in this patch, the new tool is not enabled in build process, i= t just saves in the basetools python folder, which will not influence the c= urrent edk2 behaviors. We will enable it with a new patch when everything i= s ready.

 

Many t= hanks~

 

Hi Vince= nt, please help add more information if necessary~ Thanks a lot~=

 

Thanks,=

Christine<= /p>

 <= /p>

<= /o:p>

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#112278) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_06D6_01DA2C58.3231F550--