From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.52468.1584970438504337124 for ; Mon, 23 Mar 2020 06:33:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) IronPort-SDR: OS9hbomGXYh1ibzdju1qKYGbfIlwxDnQ6k9jTuzghNWOUBTMw1TdAXNfq648gjZdnBixVvbxVR T2D4iB5ZqyBA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 06:33:57 -0700 IronPort-SDR: pHc75VIvmbL2JMdB6ThDnWNJxj+X76FVwE6zIrQ5lVgW5aq9sE70U6cpOjGhwNobh+ErnnAsPN IWvF0LaCdHoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,296,1580803200"; d="scan'208";a="269875243" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 23 Mar 2020 06:33:57 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Mar 2020 06:33:56 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Mar 2020 21:33:55 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 23 Mar 2020 21:33:55 +0800 From: "Liming Gao" To: "Jiang, Guomin" , "devel@edk2.groups.io" , "newexplorerj@gmail.com" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData Thread-Topic: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData Thread-Index: AQHV8rM3hf4MwAyOLkONalpy0VhVdKhVSGeAgAEBTOA= Date: Mon, 23 Mar 2020 13:33:55 +0000 Message-ID: <06db8303487e47dc9d1cd165447bf8f8@intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Guomin: The change is ok to me. Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: Jiang, Guomin > Sent: Monday, March 23, 2020 2:12 PM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Cc: Kinney, Michael D ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check f= or pointer BinData >=20 > Hi Michael, Liming, >=20 > Could you help review the patch. >=20 > Thanks. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > GuoMinJ > > Sent: Thursday, March 5, 2020 1:58 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ ; Kinney, Michael D > > ; Gao, Liming > > Subject: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for > > pointer BinData > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2531 > > > > AllocatePool may fail and BinData may be invalid, check it before use. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: GuoMinJ > > --- > > MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > index 6f7c31cab4..933d2b40e0 100644 > > --- a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > +++ b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > @@ -252,6 +252,9 @@ RfcDecodeTest( > > BinSize =3D AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE); > > > > BinData =3D AllocatePool (BinSize); > > + if (BinData =3D=3D NULL) { > > + return UNIT_TEST_ERROR_TEST_FAILED; } > > Btc->BufferToFree =3D BinData; > > > > ReturnSize =3D BinSize; > > -- > > 2.17.1 > > > > > >=20