public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: <devel@edk2.groups.io>, <hao.a.wu@intel.com>,
	<heng.luo@intel.com>, <ray.ni@intel.com>
Cc: <jbrasen@nvidia.com>
Subject: Re: [PATCH V2] MdeModulePkg/XhciDxe: Retry device slot init on failure
Date: Fri, 23 Oct 2020 10:59:37 +0100	[thread overview]
Message-ID: <06ee5adb-3fbe-709c-da24-2158f67574d5@nvidia.com> (raw)
In-Reply-To: <20201023095820.31673-1-jonathanh@nvidia.com>


On 23/10/2020 10:58, Jon Hunter wrote:
> With some super-speed USB mass storage devices it has been observed
> that a USB transaction error may occur when attempting the set the
> device address during enumeration.
> 
> According the the xHCI specification (section 4.6.5) ...
> 
> "A USB Transaction ErrorCompletion Code for an Address Device Command
>  may be due to a Stall response from a device. Software should issue a
>  Disable Slot Commandfor the Device Slot then an Enable Slot Command
>  to recover from this error."
> 
> To fix this, retry the device slot initialization if it fails due to a
> device error.
> 
> Change-Id: Id1e06057bee518768c7246c4f0b82b6fe06aef35
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>

Sorry I forgot to remove the Change-Id. Ignore this, I will resend.

Jon

-- 
nvpublic

  reply	other threads:[~2020-10-23  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  9:58 [PATCH V2] MdeModulePkg/XhciDxe: Retry device slot init on failure Jon Hunter
2020-10-23  9:59 ` Jon Hunter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-27 16:00 [PATCH v2 ] " Jeff Brasen
2020-10-28  1:21 ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06ee5adb-3fbe-709c-da24-2158f67574d5@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox