From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mx.groups.io with SMTP id smtpd.web08.6510.1603447184519700889 for ; Fri, 23 Oct 2020 02:59:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CvQUHTl4; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 216.228.121.65, mailfrom: jonathanh@nvidia.com) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 23 Oct 2020 02:59:32 -0700 Received: from [10.26.45.125] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 23 Oct 2020 09:59:39 +0000 Subject: Re: [PATCH V2] MdeModulePkg/XhciDxe: Retry device slot init on failure To: , , , CC: References: <20201023095820.31673-1-jonathanh@nvidia.com> From: Jon Hunter Message-ID: <06ee5adb-3fbe-709c-da24-2158f67574d5@nvidia.com> Date: Fri, 23 Oct 2020 10:59:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201023095820.31673-1-jonathanh@nvidia.com> Return-Path: jonathanh@nvidia.com X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603447172; bh=azebZg6ZyMbXcbkF3BCsFpkNehyxQWN8NF4hlNoJ6kk=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=CvQUHTl4UbiHDxBah8i+ucCQ//zV1Iz4xG6DjIGcUpAj+/qhodubEJ6XyzGIzjm78 vBhVBImBtNo4CgfjdCu+hxRQWsZYDi5SojWTC9IEGW/pCKBwrryLEzlhwm7mCsWbne MxLPKFbVRX3wCSA/CQDRfxZP97HRrg/R+OzCia5GP816WsBTrMz0fSaRzo7ND1oTTg oPH79KPGBPgydAFJzMPefKn8PHqgqQeYa89oEQDqpFU1XtnBUB6pmBkhD28nkD+6q8 aGKnwULHVkDnPcOCaf+xX8q9uQP3yqiRLBPQ+rFzLztxT8ow86K/B94vQZ3DVJp8/v G07Vdpe1l1QyA== Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit On 23/10/2020 10:58, Jon Hunter wrote: > With some super-speed USB mass storage devices it has been observed > that a USB transaction error may occur when attempting the set the > device address during enumeration. > > According the the xHCI specification (section 4.6.5) ... > > "A USB Transaction ErrorCompletion Code for an Address Device Command > may be due to a Stall response from a device. Software should issue a > Disable Slot Commandfor the Device Slot then an Enable Slot Command > to recover from this error." > > To fix this, retry the device slot initialization if it fails due to a > device error. > > Change-Id: Id1e06057bee518768c7246c4f0b82b6fe06aef35 > Signed-off-by: Jon Hunter Sorry I forgot to remove the Change-Id. Ignore this, I will resend. Jon -- nvpublic