From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.43]) by mx.groups.io with SMTP id smtpd.web11.9884.1597325299970791034 for ; Thu, 13 Aug 2020 06:28:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=SHHmMua2; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.92.43, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NSWaK7zZXhx/aFvLxYeLvmBIwqoHVq8jit4ZW8yZKbIS4nA6tW7FMVQ1/kdJicK6Oo4l0T1rtnghWjmdPuA1KRI0c64Ig/cpY7Frgs0cplk/7cyuExHmsrEYV3YHnDJ4b8f6dDOABOllh2pY73f19s4mfQZrOo4GONoJNgqhgP7v74q1/J1zJpTyEqVgnmVI1wdmsLlZCEYp9cMzVXsPMIiG9eFcLj37lbajWmT8rpbow029ygOrQgoxGCB5e7fPSQi8zClf6oPjL5Mr7A0MAT6FPa1xMvtEUqtFIx0WtK0EiZcyMhl/r0iqitRPfDPG+zgEHmTkBtZNmQyNYB3Usw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0lS01tXRPeKYydU8t5ls3qf4UZi9aw7Qirlad3oHPTY=; b=HNKVlTd2+nlSJBkZ3x5owu8J8oNt8Bhm9Il9Kawan8UdERC9o3zBTmAjDE4FwCbKf7AptLMwFiErDZebGYIQJK93ggcRC8NP06YyrTgDgrw72fgLmEdXRkxTp1WjOHyABuJ0MDc9WgpMw5o5s5cZ3tm7k6drQjFT8Ps+E+b+jnbkSibjgHV7InJ74RffiwtJ+4TrPJjadY1s59M7teCSoGCswgQYkcqLovF44U3cc6U0Oi8UA/02FQpcCWflkH1VpvYv5Nahp6JOAW4DKaA+X1mwkB3XERsYomG4LOkgk8E6fhxyw0LX/gU8rv/uX7BI+Vpl4GmgzTMLodD6QbwckA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0lS01tXRPeKYydU8t5ls3qf4UZi9aw7Qirlad3oHPTY=; b=SHHmMua2tNz9wuSrsFzksOVN7nNMSN8+q0U7zqTpTcEfcIWPr6HQj6b2awsa0LiGD86xqF8Fc+LIWFtDgu3VBaxXZSCJC1ejiTkgjKUcYyOvs6oedbH6fmYfOzVQURD3ogxWd2hf9z+w4AA73hZuHXgifgZeABQi06ztbiIBVRM= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB4220.namprd12.prod.outlook.com (2603:10b6:5:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Thu, 13 Aug 2020 13:28:18 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0%8]) with mapi id 15.20.3261.025; Thu, 13 Aug 2020 13:28:18 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Laszlo Ersek , Liming Gao , Michael D Kinney , Ray Ni , Anthony Perard , Julien Grall Subject: [PATCH v15 35/46] OvmfPkg/PlatformPei: Reserve SEV-ES work area if S3 is supported Date: Thu, 13 Aug 2020 08:23:22 -0500 Message-ID: <06f0f87708822c3da169ff35ce8ceca2b5091813.1597325013.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: References: X-ClientProxiedBy: DM6PR18CA0003.namprd18.prod.outlook.com (2603:10b6:5:15b::16) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by DM6PR18CA0003.namprd18.prod.outlook.com (2603:10b6:5:15b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16 via Frontend Transport; Thu, 13 Aug 2020 13:28:17 +0000 X-Mailer: git-send-email 2.28.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0daed9f6-6b8c-45ad-be50-08d83f8cbd98 X-MS-TrafficTypeDiagnostic: DM6PR12MB4220: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gq5wDXyJri+SbrzEMoATYTy5fMenvCxtrOYltPky8arUohYBYj2Es4whM7JANoF6bCLwXLn6Q/aUS3Uxn0Z7bb4oiGoHukrsV276A8iyASTpbQmT0K54g6O64fZIgKLzekxKM747W0He7HkGIQzQ3UuU3P+1H1rDGtjiJRM0zPw+b5HAD/4BO9tCwQodAPQaA6AAfYPRD/snQJTSfe/G84xkpFxldM+Vz6oSTG6jEIG0HS2+blcfHghltTPi8Kcdqyiv8tcnFb/kSxn0ESRyHP0/dpnr/w9Az0666kZCgt2kdin4/1O/+fEoqvW9Kj8K20Bw5Wg/pPw1zEmHUM8PayQPYFIywnSnfWkW8F5mwar/z4X9RcqxfQX6ya/ELAl+HgQonzrmB2XbHlWeOYZGuTs+bmHrJUiGVryGd0LlTbZuMFbLNXQhuZ+P8NkaEfsNJR1THwT8UtrJLeVld58o4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(7696005)(52116002)(6486002)(8936002)(83380400001)(4326008)(16526019)(26005)(66946007)(5660300002)(186003)(2616005)(7416002)(966005)(36756003)(2906002)(956004)(86362001)(66556008)(54906003)(66476007)(8676002)(316002)(6666004)(478600001)(6916009)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zUDrTsNcgqBrsVYZ4nle+IAaSG2jIrfBsJ6J8mcf8QoC4AVzyLarDwcVlb4N0fXbw6tIvQMuZcPtAdmc+2fABnjn62zP2F30zIIgMUKexLUbM/QOqLhPTZY1jRiWGtz/d+VXnhvpT7A92soc1Sed39MlSVMEiKZ95//cLnG5GMHDa4b/VAUQHU5KhToUYulRZ7aTeOzWhTL8p6lrfu21e/oRAxu8zNFk6Mp90b+mOIIcYF7zaXK8U88QgSaZUfSvRlGu39EMz9luluOx2EHnScpIUuaRKkZXIo9mZBunk4n7xChyh9Qid3HHP4BA3dzxFVRVHWahkKRyK9tEeMg7wBsd2MGDejz7EJGH6O3TweB+WaPF5oCHd5OvngJVH1VG8ZaRONMOpBZ6OzoE3If4fbiK7jZJMTUqF8NUufSg37nJeZiZSqoCnx159L7Y6YfNQO4pVhT/OjN0vG8FPpQT2SxFzg7Kq9QvmzB0w1VV+3XnhHDLAXcQJEeqjEuXCFyWr8L0cPMai7qKQQ9ixPCWi/ON4Me9VPl0Qns4xdZM3WW2Q2pjGdDMBvKyuo6PTGUppK4qQtNjugvGUtNZI8jiYAw79HWCu5v9IfWnIZH82vWABWgjjVH5gRJDgP5PwGdGMVok5ix3BXOrZuPXg0PnyA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0daed9f6-6b8c-45ad-be50-08d83f8cbd98 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2020 13:28:18.3739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9qkxKMH+TpVWcmSfImQfnvKWa1BA0Ti14cVnj11st+eNixFxM7H7ae2dojJut4s/08uAgW/Dsx1vUIGyJQ6jrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4220 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 Protect the SEV-ES work area memory used by an SEV-ES guest. Regarding the lifecycle of the SEV-ES memory area: PcdSevEsWorkArea (a) when and how it is initialized after first boot of the VM If SEV-ES is enabled, the SEV-ES area is initialized during the SEC phase [OvmfPkg/ResetVector/Ia32/PageTables64.asm]. (b) how it is protected from memory allocations during DXE If SEV-ES is enabled, then InitializeRamRegions() [OvmfPkg/PlatformPei/MemDetect.c] protects the ranges with either an AcpiNVS (S3 enabled) or BootServicesData (S3 disabled) memory allocation HOB, in PEI. (c) how it is protected from the OS If S3 is enabled, then (b) reserves it from the OS too. If S3 is disabled, then the range needs no protection. (d) how it is accessed on the S3 resume path It is rewritten same as in (a), which is fine because (b) reserved it. (e) how it is accessed on the warm reset path It is rewritten same as in (a). Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/PlatformPei.inf | 2 ++ OvmfPkg/PlatformPei/MemDetect.c | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/Plat= formPei.inf index 4742e1bdf42b..c53be2f4925c 100644 --- a/OvmfPkg/PlatformPei/PlatformPei.inf +++ b/OvmfPkg/PlatformPei/PlatformPei.inf @@ -118,6 +118,8 @@ [FixedPcd] gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData + gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase + gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize =20 [FeaturePcd] gUefiOvmfPkgTokenSpaceGuid.PcdCsmEnable diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetec= t.c index 6b5fee166b5d..ffbbef891a11 100644 --- a/OvmfPkg/PlatformPei/MemDetect.c +++ b/OvmfPkg/PlatformPei/MemDetect.c @@ -940,5 +940,25 @@ InitializeRamRegions ( ); } } + +#ifdef MDE_CPU_X64 + if (MemEncryptSevEsIsEnabled ()) { + // + // If SEV-ES is enabled, reserve the SEV-ES work area. + // + // Since this memory range will be used by the Reset Vector on S3 + // resume, it must be reserved as ACPI NVS. + // + // If S3 is unsupported, then various drivers might still write to t= he + // work area. We ought to prevent DXE from serving allocation reques= ts + // such that they would overlap the work area. + // + BuildMemoryAllocationHob ( + (EFI_PHYSICAL_ADDRESS)(UINTN) FixedPcdGet32 (PcdSevEsWorkAreaBase)= , + (UINT64)(UINTN) FixedPcdGet32 (PcdSevEsWorkAreaSize), + mS3Supported ? EfiACPIMemoryNVS : EfiBootServicesData + ); + } +#endif } } --=20 2.28.0