From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64C4E21962301 for ; Wed, 9 Jan 2019 23:17:59 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 23:17:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,460,1539673200"; d="scan'208";a="124903070" Received: from shzintpr02.sh.intel.com (HELO [10.7.209.21]) ([10.239.4.160]) by orsmga002.jf.intel.com with ESMTP; 09 Jan 2019 23:17:56 -0800 To: "Wang, Jian J" , Laszlo Ersek , Ard Biesheuvel , "edk2-devel@lists.01.org" Cc: "Wu, Hao A" , "Gao, Liming" , "Kinney, Michael D" , star.zeng@intel.com References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> <20190103182825.32231-7-ard.biesheuvel@linaro.org> <09818de2-2518-38f7-42ac-8882ecb2ea29@redhat.com> From: "Zeng, Star" Message-ID: <06f8bea1-f371-8011-d93f-66924f79ab77@intel.com> Date: Thu, 10 Jan 2019 15:17:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 5/6] MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 07:17:59 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2019/1/10 10:33, Wang, Jian J wrote: > Laszlo, > > Regards, > Jian > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Tuesday, January 08, 2019 11:38 PM >> To: Ard Biesheuvel ; edk2-devel@lists.01.org >> Cc: Leif Lindholm ; Kinney, Michael D >> ; Gao, Liming ; Wang, >> Jian J ; Wu, Hao A ; Jagadeesh >> Ujja ; Achin Gupta ; >> Thomas Panakamattam Abraham ; Sami Mujawar >> >> Subject: Re: [PATCH 5/6] MdeModulePkg/VariableRuntimeDxe: factor out boot >> service accesses >> >> On 01/03/19 19:28, Ard Biesheuvel wrote: >>> In preparation of providing a standalone MM based variable runtime >>> driver, move the existing SMM driver to the new MM services table, >>> and factor out some pieces that are specific to the traditional >>> driver, mainly related to the use of UEFI boot services, which are >>> not accessible to standalone MM drivers. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >>> --- >>> MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 18 >> +--- >>> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h | 50 >> +++++++++ >>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c | 59 >> ++++------ >>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 5 +- >>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c | >> 114 ++++++++++++++++++++ >>> 5 files changed, 187 insertions(+), 59 deletions(-) >> >> I *vaguely* feel like we should extract the new functions to >> "PrivilegePolymorphic.h", rather than to "Variable.h". >> >> Please see initial commit 00663d047fc9 >> ("MdeModulePkg/Variable/RuntimeDxe: move SecureBootHook() decl to new >> header", 2017-10-10), and other commits that touched that file. >> >> I realize this is not a 100% "constructive" suggestion, and I feel >> appropriately bad about that. It's just that "Variable.h" has so many >> internals that I feel it's not a good dumping ground for these new >> functions. And the other header we have, looks closer in purpose. >> >> For example, MorLockInitAtEndOfDxe() is already declared in >> "PrivilegePolymorphic.h" (see commit f1304280435f, >> "MdeModulePkg/Variable/RuntimeDxe: introduce MorLockInitAtEndOfDxe() >> hook", 2017-10-10). >> >> Admittedly, now that we're going to have three separate builds of this >> driver, dedicating a separate header file to each "shared between A and >> B" relationship is getting a bit too complex. In retrospect, introducing >> "PrivilegePolymorphic.h" may not have been a "scalable" idea, after all, >> and I should have just dumped those functions all in "Variable.h". >> >> IOW, I think >> - targeting "Variable.h" now is inconsistent with earlier code, >> - extending "PrivilegePolymorphic.h" is also suboptimal (although still >> better than the previous option), >> - adding yet another header might be technically correct, but it would >> be over-engineering, >> - asking you to merge "PrivilegePolymorphic.h" back into "Variable.h" >> feels awkward, especially after I argued *for* "PrivilegePolymorphic.h" >> at length, when I originally introduced it. :/ >> >> Sigh. Can the variable driver maintainers comment please? >> >> (I still plan to regression-test this series, but I feel like I should >> force myself to at least skim the variable driver patches, beyond >> testing them. Because, next time I can't avoid working with this very >> complex driver, I wouldn't like to be *completely* lost.) >> > > I agree "PrivilegePolymorphic.h" is more appropriate place for them. > Maybe Star have different opinion. At current situation, I prefer PrivilegePolymorphic.h. :) Some minor feedback will be added in another reply. Thanks, Star > >> Thanks, >> Laszlo