From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.2649.1597182967737556978 for ; Tue, 11 Aug 2020 14:56:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gkXd2goD; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597182966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ii9BVxvudJ5Yd5GY+ZRR+Mv1fPqe5ghhHqEqvU+1Go=; b=gkXd2goDYsBNOuJokeXJHiMNok/J0rsUJ57vkpupAdP5El/HXB6GCLkj7AWzEu7TrB8YLR nxzcIIWKpT6nhjDTfERqn5sjudB2osRuh3jda1i85yk95JLz7z+4IbjsZY737sVbEWGMUN nCSQ+NUbGtJoUpg9aHkFWVoTpmHDnKQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-F4HWkgb0NDK_jGu_WjyG-Q-1; Tue, 11 Aug 2020 17:56:01 -0400 X-MC-Unique: F4HWkgb0NDK_jGu_WjyG-Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4AAB1005504; Tue, 11 Aug 2020 21:56:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-221.ams2.redhat.com [10.36.113.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5E8E19931; Tue, 11 Aug 2020 21:55:59 +0000 (UTC) Subject: Re: [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki To: Cole Robinson , devel@edk2.groups.io Cc: michael.d.kinney@intel.com References: From: "Laszlo Ersek" Message-ID: <06fed550-e96a-4a12-7550-22156cb8a414@redhat.com> Date: Tue, 11 Aug 2020 23:55:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/11/20 20:09, Cole Robinson wrote: > Googling for 'edk2 pull request' did not find this wiki page: > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > > Add it to CONTRIBUTING.md for more discoverability > > Signed-off-by: Cole Robinson > --- > I tried submitting a PR to edk2: https://github.com/tianocore/edk2/pull/854 > > It was auto closed with: `All checks passed. Auto close personal build.` > > That confused me quite a bit. I could not understand what it was trying > to say. I looked at other successfully merged PRs, noticed some hits > about a 'push' label, but on looking to resubmit the PR it didn't seem > like I had permission to set labels. Googling did not turn up any explanatory > hits in the first two pages either. Eventually Laszlo pointed me in the > right direction though > > A couple other suggestions to avoid that confusion > > * Extend the mergify message to clarify PRs are largely only meant for > maintainers to use. Maybe point at the wiki page or CONTRIBUTING.md > > * Add a github new PR template with a comment giving more explanation: > https://docs.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository > > CONTRIBUTING.md | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 CONTRIBUTING.md > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > new file mode 100644 > index 0000000000..212c69ce8b > --- /dev/null > +++ b/CONTRIBUTING.md > @@ -0,0 +1,3 @@ > +# Contributing to EDK2 > + > +Contributor documentation is maintained on the wiki: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > Does github display "CONTRIBUTING.md" automatically? Hm... If I check , there's an explicit reference to "CONTRIBUTING.md" at the bottom of "README.md"; github.com seems to display "README.md" only. Is this patch useful without modifying "ReadMe.rst"? ... Actually, the section at https://github.com/tianocore/edk2/#resources includes "How To Contribute" -> https://github.com/tianocore/tianocore.github.io/wiki/How-To-Contribute Is that unhelpful (or difficult to find)? Thanks! Laszlo