From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8DD3F78003C for ; Tue, 21 May 2024 01:40:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=84haFML/KffmFGjqI2JRfycH4qNJe0zHBqNoP+2HBUo=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716255633; v=1; b=nSZ1Q98ZgG/iaXXguW1U+KHl3A0a8FbzHIwplRSXSUtYM96vr7nBA0xViCUwg+QJgi+pza/u TXGkcUY5DqTOSbb4dqTi0YnS06M68IFumLm4H5niJnv5man5hSTDjb1s93jih9lhcbowgaRI4j+ UP4r0idaObUjpb6AmtspNxJzb/1mY6YAisgLnkO0hbjDRESe3tLpemPto2GOJh1L2u9n+jX0GyU ZBGuthYQNDGqiSBxANJgxHt1ZQTyKKhs70iFqWo0N+8Q/3aBbax7ENur8Du7yQhQ9zPWgsyXOMs 9rbKpbp0GbAxH6ID1/95Tk+0vA2eCV54+BwJ+ug7tjfgQ== X-Received: by 127.0.0.2 with SMTP id zxoGYY7687511xdGvp7tE5LC; Mon, 20 May 2024 18:40:33 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.9683.1716255632248823725 for ; Mon, 20 May 2024 18:40:32 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.14]) by linux.microsoft.com (Postfix) with ESMTPSA id 2A1F7206790F; Mon, 20 May 2024 18:40:31 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2A1F7206790F Message-ID: <0700423e-bf22-42bb-a593-5202c5f649ac@linux.microsoft.com> Date: Mon, 20 May 2024 21:40:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 To: "Kinney, Michael D" , "devel@edk2.groups.io" , Andrew Fish , Leif Lindholm , Liming Gao Cc: "Feng, Bob C" , Joey Vagedes , Rebecca Cran , Sean Brogan , "Chen, Christine" References: <20240517210902.1510-1-mikuback@linux.microsoft.com> <8354dafc-6c4c-4981-9561-bd46f5b6b14d@linux.microsoft.com> <78674f4f-0923-4117-bfa8-61953930c4cf@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 20 May 2024 18:40:32 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jR3GjpFgpS3yK1GxwQbajmoyx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=nSZ1Q98Z; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Just wanted to send a reminder that I recommend=20 https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for=20 those that are currently trying to test changes. Thanks, Michael On 5/17/2024 8:10 PM, Kinney, Michael D wrote: > Approved. I agree there is no impact to FW. >=20 > Mike >=20 >> -----Original Message----- >> From: Michael Kubacki >> Sent: Friday, May 17, 2024 4:28 PM >> To: Kinney, Michael D ; devel@edk2.groups.io= ; >> Andrew Fish ; Leif Lindholm = ; >> Liming Gao >> Cc: Feng, Bob C ; Joey Vagedes >> ; Rebecca Cran ; Sean Brogan >> ; Chen, Christine >> Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 >> >> Forgot about the hard freeze. >> >> Added remaining stewards to consider merging this. It has no impact on >> firmware but is needed to unblock an immediate issue in CI where the >> CodeQL queries being fetched are newer and incompatible with the CodeQL >> CLI being used. >> >> As I mentioned in the release notes, I will follow up in the future for >> a change that should be able to lock the CodeQL query versions against >> the CLI version. >> >> Thanks, >> Michael >> >> On 5/17/2024 7:20 PM, Michael Kubacki wrote: >>> To ensure CI is unblocked, I am going to add the push tag now. >>> >>> On 5/17/2024 6:31 PM, Michael Kubacki wrote: >>>> Thanks Mike. Are you okay with me completing the PR now? >>>> >>>> On 5/17/2024 5:31 PM, Kinney, Michael D wrote: >>>>> Reviewed-by: Michael D Kinney >>>>> >>>>>> -----Original Message----- >>>>>> From: mikuback@linux.microsoft.com >>>>>> Sent: Friday, May 17, 2024 2:09 PM >>>>>> To: devel@edk2.groups.io >>>>>> Cc: Feng, Bob C ; Joey Vagedes >>>>>> ; Liming Gao ; >>>>>> Kinney, >>>>>> Michael D ; Rebecca Cran >>>>>> ; >>>>>> Sean Brogan ; Chen, Christine >>>>>> >>>>>> Subject: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 >>>>>> >>>>>> From: Michael Kubacki >>>>>> >>>>>> This fixes an issue where the CodeQL queries currently fetched in th= e >>>>>> pipeline are incompatible with the current executable used. >>>>>> >>>>>> Update to pick up functional and security fixes. See the following >>>>>> comparison for detailed differences: >>>>>> >>>>>> https://github.com/github/codeql-cli-binaries/compare/v2.16.1...v2.1= 7.3 >>>>>> >>>>>> Cc: Bob Feng >>>>>> Cc: Joey Vagedes >>>>>> Cc: Liming Gao >>>>>> Cc: Michael D Kinney >>>>>> Cc: Rebecca Cran >>>>>> Cc: Sean Brogan >>>>>> Cc: Yuwei Chen >>>>>> Signed-off-by: Michael Kubacki >>>>>> --- >>>>>> >>>>>> Notes: >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 This change fixes an immediate compatibili= ty issue between >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 the latest queries being pulled and the Co= deQL CLI being >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 used. >>>>>> >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 A follow up change will attempt to lock qu= eries against a >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 compatibile version to prevent queries fro= m pulling ahead >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 to incompatible versions in the future. >>>>>> >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 --- >>>>>> >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 This change was tested in edk2 CI: >>>>>> >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0 https://github.com/tianocore/edk2/pull/566= 7 >>>>>> >>>>>> =C2=A0 BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 6 +++--- >>>>>> =C2=A0 BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml=C2=A0= =C2=A0 | 6 +++--- >>>>>> =C2=A0 BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 += ++--- >>>>>> =C2=A0 3 files changed, 9 insertions(+), 9 deletions(-) >>>>>> >>>>>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>>>>> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>>>>> index 5ec56c6bf06f..dbc9c2ba0290 100644 >>>>>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>>>>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml >>>>>> @@ -16,9 +16,9 @@ >>>>>> =C2=A0=C2=A0=C2=A0 "scope": "codeql-ext-dep", >>>>>> =C2=A0=C2=A0=C2=A0 "type": "web", >>>>>> =C2=A0=C2=A0=C2=A0 "name": "codeql_cli", >>>>>> -=C2=A0 "source": "https://github.com/github/codeql-cli- >>>>>> binaries/releases/download/v2.16.1/codeql.zip", >>>>>> -=C2=A0 "version": "2.16.1", >>>>>> -=C2=A0 "sha256": >>>>>> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6", >>>>>> +=C2=A0 "source": "https://github.com/github/codeql-cli- >>>>>> binaries/releases/download/v2.17.3/codeql.zip", >>>>>> +=C2=A0 "version": "2.17.3", >>>>>> +=C2=A0 "sha256": >>>>>> "e5ac1d87ab38e405c9af5db234a338b10dffabc98a648903f1664dd2a566dfd5", >>>>>> =C2=A0=C2=A0=C2=A0 "compression_type": "zip", >>>>>> =C2=A0=C2=A0=C2=A0 "internal_path": "/codeql/", >>>>>> =C2=A0=C2=A0=C2=A0 "flags": ["set_shell_var", ], >>>>>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>>>>> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>>>>> index 5b4a919f1de4..536322f2b331 100644 >>>>>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>>>>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml >>>>>> @@ -14,9 +14,9 @@ >>>>>> =C2=A0=C2=A0=C2=A0 "scope": "codeql-linux-ext-dep", >>>>>> =C2=A0=C2=A0=C2=A0 "type": "web", >>>>>> =C2=A0=C2=A0=C2=A0 "name": "codeql_linux_cli", >>>>>> -=C2=A0 "source": "https://github.com/github/codeql-cli- >>>>>> binaries/releases/download/v2.16.1/codeql-linux64.zip", >>>>>> -=C2=A0 "version": "2.16.1", >>>>>> -=C2=A0 "sha256": >>>>>> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171", >>>>>> +=C2=A0 "source": "https://github.com/github/codeql-cli- >>>>>> binaries/releases/download/v2.17.3/codeql-linux64.zip", >>>>>> +=C2=A0 "version": "2.17.3", >>>>>> +=C2=A0 "sha256": >>>>>> "9fba000c4b821534d354bc16821aa066fdb1304446226ea449870e64a8ad3c7a", >>>>>> =C2=A0=C2=A0=C2=A0 "compression_type": "zip", >>>>>> =C2=A0=C2=A0=C2=A0 "internal_path": "/codeql/", >>>>>> =C2=A0=C2=A0=C2=A0 "flags": ["set_shell_var", ], >>>>>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>>>>> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>>>>> index c0c018c9538f..93a81ffd5020 100644 >>>>>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>>>>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml >>>>>> @@ -14,9 +14,9 @@ >>>>>> =C2=A0=C2=A0=C2=A0 "scope": "codeql-windows-ext-dep", >>>>>> =C2=A0=C2=A0=C2=A0 "type": "web", >>>>>> =C2=A0=C2=A0=C2=A0 "name": "codeql_windows_cli", >>>>>> -=C2=A0 "source": "https://github.com/github/codeql-cli- >>>>>> binaries/releases/download/v2.16.1/codeql-win64.zip", >>>>>> -=C2=A0 "version": "2.16.1", >>>>>> -=C2=A0 "sha256": >>>>>> "9ebe5ea8a7d0a77425428d50d49912319117fccee24ecb62f6219c12584f4f28", >>>>>> +=C2=A0 "source": "https://github.com/github/codeql-cli- >>>>>> binaries/releases/download/v2.17.3/codeql-win64.zip", >>>>>> +=C2=A0 "version": "2.17.3", >>>>>> +=C2=A0 "sha256": >>>>>> "4c6fbf2ea2eaf0f47bf0347eacf54c6b9d6bdf7acb6b63e17f9e6f2dd83b34e7", >>>>>> =C2=A0=C2=A0=C2=A0 "compression_type": "zip", >>>>>> =C2=A0=C2=A0=C2=A0 "internal_path": "/codeql/", >>>>>> =C2=A0=C2=A0=C2=A0 "flags": ["set_shell_var", ], >>>>>> -- >>>>>> 2.45.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119094): https://edk2.groups.io/g/devel/message/119094 Mute This Topic: https://groups.io/mt/106161774/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-