From: Julien Grall <julien.grall@linaro.org>
To: "Zeng, Star" <star.zeng@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode
Date: Wed, 23 Jan 2019 12:15:51 +0000 [thread overview]
Message-ID: <0706b59a-cf39-04ea-ff78-e4b6b0275d57@linaro.org> (raw)
In-Reply-To: <308fdc60-d9ba-4852-31da-c18cbcd22ebf@intel.com>
On 23/01/2019 01:41, Zeng, Star wrote:
> Hi Julien,
Hi Star,
> On 2019/1/22 12:30, Zeng, Star wrote:
>> On 2019/1/22 3:40, Ard Biesheuvel wrote:
>>> On Mon, 21 Jan 2019 at 14:36, Julien Grall <julien.grall@linaro.org> wrote:
>>> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>> index a8bb9cf25ebd..adaf6ccb48b0 100644
>>> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
>>> @@ -236,14 +236,16 @@ VariableClassAddressChangeEvent (
>>> {
>>> UINTN Index;
>>>
>>> - EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->GetBlockSize);
>>> - EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->GetPhysicalAddress);
>>> - EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->GetAttributes);
>>> - EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->SetAttributes);
>>> - EfiConvertPointer (0x0, (VOID **) &mVariableModuleGlobal->FvbInstance->Read);
>>> - EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->Write);
>>> - EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->EraseBlocks);
>>> - EfiConvertPointer (0x0, (VOID **) &mVariableModuleGlobal->FvbInstance);
>>> + if (mVariableModuleGlobal->FvbInstance != NULL) {
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->GetBlockSize);
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->GetPhysicalAddress);
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->GetAttributes);
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->SetAttributes);
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->Read);
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->Write);
>>> + EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->FvbInstance->EraseBlocks);
>>> + EfiConvertPointer (0x0, (VOID **) &mVariableModuleGlobal->FvbInstance);
>>> + }
>>> EfiConvertPointer (0x0, (VOID **)
>>> &mVariableModuleGlobal->PlatformLangCodes);
>>> EfiConvertPointer (0x0, (VOID **) &mVariableModuleGlobal->LangCodes);
>>> EfiConvertPointer (0x0, (VOID **) &mVariableModuleGlobal->PlatformLang);
>>
>> Thanks Ard. I integrated it into the patch 10 of V4.
>> Repo: git@github.com:lzeng14/edk2.git
>> Branch: MergedVariableDriver_EmuNvMode_V4
>>
>> Julien, could you help take a try?
>
> Sorry for a little push. Are you able to have a quick try? :)
Sorry for the late, I didn't have time yesterday to test at it.
I tried the new branch and was able to boot a Linux guest using UEFI.
Feel free to add my tags to the series:
Tested-by: Julien Grall <julien.grall@arm.com>
Acked-by: Julien Grall <julien.grall@arm.com>
Many thanks to you, Ard and Laszlo for the feedback.
Best regards,
--
Julien Grall
next prev parent reply other threads:[~2019-01-23 12:15 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 15:19 [PATCH V2 00/15] Merge EmuVariable and Real variable driver Star Zeng
2019-01-14 15:19 ` [PATCH V2 01/15] MdeModulePkg Variable: Add some missing changes for 9b18845 Star Zeng
2019-01-15 6:36 ` Wu, Hao A
2019-01-15 8:06 ` Laszlo Ersek
2019-01-14 15:19 ` [PATCH V2 02/15] MdeModulePkg Variable: Abstract InitRealNonVolatileVariableStore Star Zeng
2019-01-15 6:37 ` Wu, Hao A
2019-01-14 15:19 ` [PATCH V2 03/15] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize Star Zeng
2019-01-15 5:48 ` Wu, Hao A
2019-01-15 5:53 ` Zeng, Star
2019-01-15 6:37 ` Wang, Jian J
2019-01-15 10:13 ` Zeng, Star
2019-01-14 15:19 ` [PATCH V2 04/15] MdeModulePkg Variable: Abstract VariableWriteServiceInitializeDxe/Smm Star Zeng
2019-01-15 6:37 ` Wu, Hao A
2019-01-15 8:05 ` Wang, Jian J
2019-01-14 15:19 ` [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec Star Zeng
2019-01-15 5:05 ` Wang, Jian J
2019-01-15 5:55 ` Zeng, Star
2019-01-15 6:37 ` Wu, Hao A
2019-01-14 15:19 ` [PATCH V2 06/15] MdeModulePkg Variable: Remove CacheOffset in UpdateVariable() Star Zeng
2019-01-15 6:37 ` Wu, Hao A
2019-01-15 8:04 ` Wang, Jian J
2019-01-15 9:58 ` Laszlo Ersek
2019-01-15 10:10 ` Zeng, Star
2019-01-15 8:15 ` Laszlo Ersek
2019-01-14 15:19 ` [PATCH V2 07/15] MdeModulePkg Variable: type case VolatileBase to UINTN directly Star Zeng
2019-01-15 6:37 ` Wu, Hao A
2019-01-15 8:06 ` Wang, Jian J
2019-01-15 8:18 ` Laszlo Ersek
2019-01-14 15:19 ` [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support Star Zeng
2019-01-15 6:01 ` Wang, Jian J
2019-01-15 6:16 ` Zeng, Star
2019-01-15 9:53 ` Laszlo Ersek
2019-01-15 9:33 ` Laszlo Ersek
2019-01-15 9:52 ` Zeng, Star
2019-01-14 15:19 ` [PATCH V2 09/15] MdeModulePkg VariablePei: Don't check BOOT_IN_RECOVERY_MODE Star Zeng
2019-01-14 15:19 ` [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode Star Zeng
2019-01-15 9:37 ` Laszlo Ersek
2019-01-16 14:26 ` Julien Grall
2019-01-17 1:26 ` Zeng, Star
2019-01-17 18:59 ` Julien Grall
2019-01-21 10:46 ` Zeng, Star
2019-01-21 13:36 ` Julien Grall
2019-01-21 19:40 ` Ard Biesheuvel
2019-01-22 4:30 ` Zeng, Star
2019-01-23 1:41 ` Zeng, Star
2019-01-23 12:15 ` Julien Grall [this message]
2019-01-23 14:20 ` Zeng, Star
2019-01-21 21:15 ` Laszlo Ersek
2019-01-21 21:22 ` Ard Biesheuvel
2019-01-21 21:25 ` Ard Biesheuvel
2019-01-14 15:19 ` [PATCH V2 11/15] ArmVirtXen: Link VarCheckUefiLib NULL class library instance Star Zeng
2019-01-15 9:39 ` Laszlo Ersek
2019-01-14 15:19 ` [PATCH V2 12/15] BeagleBoardPkg: Use merged variable driver for emulated NV mode Star Zeng
2019-01-14 22:11 ` Leif Lindholm
2019-01-15 1:32 ` Zeng, Star
2019-01-15 9:48 ` Leif Lindholm
2019-01-14 15:19 ` [PATCH V2 13/15] QuarkMin: " Star Zeng
2019-01-14 15:19 ` [PATCH V2 14/15] CorebootPayloadPkg: " Star Zeng
2019-01-14 15:19 ` [PATCH V2 15/15] MdeModulePkg: Remove EmuVariableRuntimeDxe Star Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0706b59a-cf39-04ea-ff78-e4b6b0275d57@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox