From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C61B4AC0A13 for ; Mon, 4 Sep 2023 03:29:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iIklB63QEOGYMSUrpGrBjPndc9EkNdEbS9uELPf+iPI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1693798165; v=1; b=Pt0a1IXaSBOThI+FSE3CFsojwDFfz1qmMAKmCyrqGVCxDRNXoGhBpo7zNDndizbS5KOLCA/k PZA9TPUBokf9+Ub4kN8XiPhiUDzdblMg964876uCE2R4oRmc+5aYSBVcdA6/LB5W7/0qgSp/ZCV 0lpoAUYjvWOfipg5tEnUsUcE= X-Received: by 127.0.0.2 with SMTP id Pty4YY7687511xbxQajE0RBL; Sun, 03 Sep 2023 20:29:25 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.41346.1693798163059480407 for ; Sun, 03 Sep 2023 20:29:24 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 1B512DDA7AF for ; Mon, 4 Sep 2023 11:29:20 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 16EDDDDA792 for ; Mon, 4 Sep 2023 11:29:20 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 70713DDA7AC for ; Mon, 4 Sep 2023 11:29:16 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 04 Sep 2023 11:29:01 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Abner Chang'" , "'Alexei Fedorov'" , "'Ard Biesheuvel'" , "'Gerd Hoffmann'" , "'Igor Kulchytskyy'" , "'Jian J Wang'" , "'Jiewen Yao'" , "'Jordan Justen'" , "'Leif Lindholm'" , "'Michael D Kinney'" , "'Nickle Wang'" , "'Pierre Gondois'" , "'Sami Mujawar'" , "'Sean Brogan'" References: <177B5B086FA2671E.12117@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDAvN10gQWRkIERlYnVnTWFjcm9DaGVjaw==?= Date: Mon, 4 Sep 2023 11:29:02 +0800 Message-ID: <071101d9dedf$f37fe9e0$da7fbda0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKvKZnJ9jt3RgQHnhKfyq393VMuHQKvM/Y5rknysTA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VYQyAqbHpQUWOeOBF0gpVwabx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Pt0a1IXa; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Michael: I think this change is helpful. For this patch set, Acked-by: Liming Gao = Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Michael > Kubacki > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B48=E6=9C=8830=E6=97=A5 = 7:27 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Abner Chang ; Alexei Fedorov > ; Ard Biesheuvel ; > Gerd Hoffmann ; Igor Kulchytskyy ; > Jian J Wang ; Jiewen Yao ; > Jordan Justen ; Leif Lindholm > ; Liming Gao ; > Michael D Kinney ; Nickle Wang > ; Pierre Gondois ; Sami > Mujawar ; Sean Brogan > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 0/7] Add DebugMacroCheck >=20 > Hi all, >=20 > Now that the stable tag is out, I would appreciate reviews for this serie= s. >=20 > Thanks, > Michael >=20 > On 8/14/2023 4:48 PM, Michael Kubacki wrote: > > From: Michael Kubacki > > > > Adds a new script and build plugin called DebugMacroCheck. > > > > The script verifies that the number of print specifiers match the > > number of arguments in DEBUG() calls. > > > > Overview: > > > > - Build plugin: BuildPlugin/DebugMacroCheckBuildPlugin.py > > - Runs on any build target that is not NO-TARGET > > - Standalone script: DebugMacroCheck.py > > - Run `DebugMacroCheck.py --help` to see command line options > > - Unit tests: > > - Tests/test_DebugMacroCheck.py > > - Can be run with: > > `python -m unittest discover > -s ./.pytool/Plugin/DebugMacroCheck/tests -v` > > - Also visible in VS Code Test Explorer > > > > Background: > > > > The tool has been constantly run against edk2 derived code for about > > a year now. During that time, its found over 20 issues in edk2, over > > 50 issues in various vendor code, and numerous other issues specific > > to Project Mu. > > > > See the following series for a batch of issues previously fixed in > > edk2 discovered by the tool: > > > > https://edk2.groups.io/g/devel/message/93104 > > > > I've received interest from vendors to place it in edk2 to > > immediately find issues in the upstream and make it easier for edk2 > > consumers to directly acquire it. That led to this patch series. > > > > This would run in edk2 as a build plugin. All issues in the edk2 > > codebase have been resolved so this would find new issues before > > they are merged into the codebase. > > > > The script is meant to be portable so it can be run as a build plugin > > or dropped as a standalone script into other environments alongside > > the unit tests. > > > > Series Overview: > > > > - Fixes outstanding issues in RedfishPkg > > - Adds the `regex` PIP module to pip-requirements.txt > > - Adds exceptions for debug macro usage in ArmVirtPkg, > > DynamicTablesPkg, and SecurityPkg > > - Disables the plugin in OvmfPkg per maintainer's previous > > preferences > > - Adds the plugin > > > > The plugin (this series) is running with passing CI results as shown > > in this PR: > > https://github.com/tianocore/edk2/pull/4736 > > > > Cc: Abner Chang > > Cc: Alexei Fedorov > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Igor Kulchytskyy > > Cc: Jian J Wang > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Leif Lindholm > > Cc: Liming Gao > > Cc: Michael D Kinney > > Cc: Nickle Wang > > Cc: Pierre Gondois > > Cc: Sami Mujawar > > Cc: Sean Brogan > > > > Michael Kubacki (7): > > RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix DEBUG macro > args > > pip-requirements.txt: Add regex > > SecurityPkg.ci.yaml: Add debug macro exception > > ArmVirtPkg.ci.yaml: Add debug macro exception > > DynamicTablesPkg.ci.yaml: Add debug macro exception > > OvmfPkg/PlatformCI: Disable DebugMacroCheck > > .pytool/Plugin: Add DebugMacroCheck > > > > > RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfa > ceBmcUsbNicLib.c | 8 +- > > .pytool/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPl > ugin.py | 127 +++ > > .pytool/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheck_plug_ > in.yaml | 11 + > > .pytool/Plugin/DebugMacroCheck/DebugMacroCheck.py > | 859 ++++++++++++++++++++ > > .pytool/Plugin/DebugMacroCheck/Readme.md > | 253 ++++++ > > .pytool/Plugin/DebugMacroCheck/tests/DebugMacroDataSet.py > | 674 +++++++++++++++ > > .pytool/Plugin/DebugMacroCheck/tests/MacroTest.py > | 131 +++ > > .pytool/Plugin/DebugMacroCheck/tests/__init__.py > | 0 > > .pytool/Plugin/DebugMacroCheck/tests/test_DebugMacroCheck.py > | 201 +++++ > > ArmVirtPkg/ArmVirtPkg.ci.yaml > | 8 + > > DynamicTablesPkg/DynamicTablesPkg.ci.yaml > | 8 + > > OvmfPkg/PlatformCI/PlatformBuildLib.py > | 1 + > > SecurityPkg/SecurityPkg.ci.yaml > | 9 + > > pip-requirements.txt > | 2 +- > > 14 files changed, 2287 insertions(+), 5 deletions(-) > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuil > dPlugin.py > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheck_pl > ug_in.yaml > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/DebugMacroCheck.py > > create mode 100644 .pytool/Plugin/DebugMacroCheck/Readme.md > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/tests/DebugMacroDataSet.py > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/tests/MacroTest.py > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/tests/__init__.py > > create mode > 100644 .pytool/Plugin/DebugMacroCheck/tests/test_DebugMacroCheck.py > > >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108247): https://edk2.groups.io/g/devel/message/108247 Mute This Topic: https://groups.io/mt/101142278/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-