From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web08.1371.1605740423878195619 for ; Wed, 18 Nov 2020 15:00:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=bIVi/Atr; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AIMYoI0023527; Wed, 18 Nov 2020 18:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=jRisVA/vPkUlhHVTvooB1szVaw+vmoABy5InjcjOBR0=; b=bIVi/AtrKiC24Wp/mnXYb3Shewmbefzi9QJ0IBi+323znpMlSjtUpiU+TK5SnKezmVob tC4142waT6FKkiz4fEji0QmScsMTw/kcb5G0sM7x49kTiBqOCWD61iXRez6SXVNaZhrD Qg6BRW8fS6sv54ePY67gF1m6KxzudRE3NKpy7lIC2S8/MhrxIeCqylTgZ2yA4QlS78Ub uUIomscaivtFKeWyGTZODPhsrNCittGGRytWI/KQlXdnSMvmWlRWwnmOjxRbECLts9d0 4DKFGvvQGuHLVsdxnAtf/CNHhSPmzsPcO+oTuGI/uBzron+vy/zLypLmr4FTCPxyXdIi rA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 34wc6mgwkk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Nov 2020 18:00:21 -0500 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AIMjLQD062355; Wed, 18 Nov 2020 18:00:20 -0500 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 34wc6mgwk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Nov 2020 18:00:20 -0500 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AIMumA9023473; Wed, 18 Nov 2020 23:00:19 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01dal.us.ibm.com with ESMTP id 34uttrq2be-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Nov 2020 23:00:19 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AIN0GDX54198760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Nov 2020 23:00:16 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E57978063; Wed, 18 Nov 2020 23:00:16 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E67C37807E; Wed, 18 Nov 2020 23:00:13 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.179.241]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 18 Nov 2020 23:00:13 +0000 (GMT) Message-ID: <0716c83736d9786a2d3257a06582a2c7221edc3e.camel@linux.ibm.com> Subject: Re: [edk2-devel] [PATCH 2/4] OvmfPkg/AmdSev: add Grub Firmware Volume Package From: James Bottomley Reply-To: jejb@linux.ibm.com To: Laszlo Ersek , devel@edk2.groups.io Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" Date: Wed, 18 Nov 2020 15:00:12 -0800 In-Reply-To: <64377f9f-da65-d0ca-e473-c14a69e16a66@redhat.com> References: <20201112001316.11341-1-jejb@linux.ibm.com> <20201112001316.11341-3-jejb@linux.ibm.com> <64377f9f-da65-d0ca-e473-c14a69e16a66@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-18_08:2020-11-17,2020-11-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 mlxlogscore=872 priorityscore=1501 phishscore=0 clxscore=1015 adultscore=0 mlxscore=0 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011180151 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2020-11-16 at 21:42 +0100, Laszlo Ersek wrote: > On 11/12/20 01:13, James Bottomley wrote: [...] > > +## > > +# different distributions have different names for grub-mkimage, > > so > > +# search all the known ones > > +## > > +for b in grub2-mkimage grub-mkimage; do > > + if which $b > /dev/null 2>&1; then I did everything except this: > (11) s/which/command -v/ The problem with command -v is that it picks up aliases, which we definitely don't want (in the incredibly unlikely case that grub- mkimage has an alias). You can see the effects with ls which I've got aliased: jejb@jarvis:~> command -v ls alias ls='ls -F' jejb@jarvis:~> which ls /bin/ls We definitely want the latter behaviour in the script above ... I need the absolute path to the command, so I kept the which. James