From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3347F21B02822 for ; Wed, 21 Nov 2018 09:22:58 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59146C049D7A; Wed, 21 Nov 2018 17:22:57 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-240.rdu2.redhat.com [10.10.120.240]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63E7460FD9; Wed, 21 Nov 2018 17:22:53 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, philmd@redhat.com, hongbo.zhang@linaro.org, nariman.poushin@linaro.org, thomas.abraham@arm.com References: <20181121115828.3026-1-ard.biesheuvel@linaro.org> <20181121115828.3026-6-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <0727f732-53e6-91f7-dc81-b78b5525ca93@redhat.com> Date: Wed, 21 Nov 2018 18:22:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181121115828.3026-6-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 21 Nov 2018 17:22:57 +0000 (UTC) Subject: Re: [PATCH v2 5/5] ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from struct X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 17:22:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/21/18 12:58, Ard Biesheuvel wrote: > We no longer use per-instance GUIDs to identify NOR flash banks so > there is no longer a need to define them. Drop the Guid member from > the NOR_FLASH_DESCRIPTION type. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > This patch should not be merged before users in edk2-platforms have been > updated. > > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h b/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > index e9e1c060787d..e99a217c3a51 100644 > --- a/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > +++ b/ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > @@ -20,7 +20,6 @@ typedef struct { > UINTN RegionBaseAddress; // Start address of one single region > UINTN Size; > UINTN BlockSize; > - EFI_GUID Guid; > } NOR_FLASH_DESCRIPTION; > > EFI_STATUS > Reviewed-by: Laszlo Ersek