* [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
@ 2016-10-10 15:43 Bruce Cran
2016-10-10 16:27 ` Laszlo Ersek
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Cran @ 2016-10-10 15:43 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Laszlo Ersek, Yonghong Zhu
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: 0001-Add-NOOPT-build-targets-to-OvmfPkg-for-source-level-.patch --]
[-- Type: text/plain, Size: 2191 bytes --]
From ef7b3dfe26bb7748d838974af57cd73e40e24c94 Mon Sep 17 00:00:00 2001
From: Bruce Cran <Bruce.Cran@sandisk.com>
Date: Mon, 10 Oct 2016 09:35:50 -0600
Subject: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Bruce Cran <bruce.cran@sandisk.com>
---
OvmfPkg/OvmfPkgIa32.dsc | 2 +-
OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
OvmfPkg/OvmfPkgX64.dsc | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index 7213197..41500ca 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -26,7 +26,7 @@
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/OvmfIa32
SUPPORTED_ARCHITECTURES = IA32
- BUILD_TARGETS = DEBUG|RELEASE
+ BUILD_TARGETS = NOOPT|DEBUG|RELEASE
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32.fdf
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index c27024a..1bd4b21 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -26,7 +26,7 @@
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/Ovmf3264
SUPPORTED_ARCHITECTURES = IA32|X64
- BUILD_TARGETS = DEBUG|RELEASE
+ BUILD_TARGETS = NOOPT|DEBUG|RELEASE
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32X64.fdf
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index c34b266..460f7bb 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -26,7 +26,7 @@
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/OvmfX64
SUPPORTED_ARCHITECTURES = X64
- BUILD_TARGETS = DEBUG|RELEASE
+ BUILD_TARGETS = NOOPT|DEBUG|RELEASE
SKUID_IDENTIFIER = DEFAULT
FLASH_DEFINITION = OvmfPkg/OvmfPkgX64.fdf
--
2.10.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
2016-10-10 15:43 [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging Bruce Cran
@ 2016-10-10 16:27 ` Laszlo Ersek
2016-10-10 16:29 ` Laszlo Ersek
0 siblings, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2016-10-10 16:27 UTC (permalink / raw)
To: Bruce Cran; +Cc: edk2-devel@lists.01.org, Yonghong Zhu
On 10/10/16 17:43, Bruce Cran wrote:
>
>
> 0001-Add-NOOPT-build-targets-to-OvmfPkg-for-source-level-.patch
>
>
> From ef7b3dfe26bb7748d838974af57cd73e40e24c94 Mon Sep 17 00:00:00 2001
> From: Bruce Cran <Bruce.Cran@sandisk.com>
> Date: Mon, 10 Oct 2016 09:35:50 -0600
> Subject: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Bruce Cran <bruce.cran@sandisk.com>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 2 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
> OvmfPkg/OvmfPkgX64.dsc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 7213197..41500ca 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -26,7 +26,7 @@
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/OvmfIa32
> SUPPORTED_ARCHITECTURES = IA32
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32.fdf
>
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index c27024a..1bd4b21 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -26,7 +26,7 @@
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/Ovmf3264
> SUPPORTED_ARCHITECTURES = IA32|X64
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32X64.fdf
>
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index c34b266..460f7bb 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -26,7 +26,7 @@
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/OvmfX64
> SUPPORTED_ARCHITECTURES = X64
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = OvmfPkg/OvmfPkgX64.fdf
>
> -- 2.10.0
>
Looks good to me:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
but we should hold it until Yonghong's v4 is posted / reviewed / pushed.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
2016-10-10 16:27 ` Laszlo Ersek
@ 2016-10-10 16:29 ` Laszlo Ersek
2016-10-10 20:27 ` Bruce Cran
2016-10-11 0:51 ` Zhu, Yonghong
0 siblings, 2 replies; 6+ messages in thread
From: Laszlo Ersek @ 2016-10-10 16:29 UTC (permalink / raw)
To: Bruce Cran; +Cc: edk2-devel@lists.01.org, Yonghong Zhu
On 10/10/16 18:27, Laszlo Ersek wrote:
> On 10/10/16 17:43, Bruce Cran wrote:
>>
>>
>> 0001-Add-NOOPT-build-targets-to-OvmfPkg-for-source-level-.patch
>>
>>
>> From ef7b3dfe26bb7748d838974af57cd73e40e24c94 Mon Sep 17 00:00:00 2001
>> From: Bruce Cran <Bruce.Cran@sandisk.com>
>> Date: Mon, 10 Oct 2016 09:35:50 -0600
>> Subject: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Bruce Cran <bruce.cran@sandisk.com>
>> ---
>> OvmfPkg/OvmfPkgIa32.dsc | 2 +-
>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
>> OvmfPkg/OvmfPkgX64.dsc | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
>> index 7213197..41500ca 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -26,7 +26,7 @@
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/OvmfIa32
>> SUPPORTED_ARCHITECTURES = IA32
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32.fdf
>>
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>> index c27024a..1bd4b21 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -26,7 +26,7 @@
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/Ovmf3264
>> SUPPORTED_ARCHITECTURES = IA32|X64
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32X64.fdf
>>
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
>> index c34b266..460f7bb 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -26,7 +26,7 @@
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/OvmfX64
>> SUPPORTED_ARCHITECTURES = X64
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = OvmfPkg/OvmfPkgX64.fdf
>>
>> -- 2.10.0
>>
>
> Looks good to me:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> but we should hold it until Yonghong's v4 is posted / reviewed / pushed.
(maybe the subject can be rewritten as
OvmfPkg: add NOOPT build target for source level debugging
but I can do that later when I commit the patch.)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
2016-10-10 16:29 ` Laszlo Ersek
@ 2016-10-10 20:27 ` Bruce Cran
2016-10-12 7:38 ` Laszlo Ersek
2016-10-11 0:51 ` Zhu, Yonghong
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Cran @ 2016-10-10 20:27 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel@lists.01.org, Yonghong Zhu
On 10/10/2016 4:29 PM, Laszlo Ersek wrote:
>
> (maybe the subject can be rewritten as
>
> OvmfPkg: add NOOPT build target for source level debugging
>
> but I can do that later when I commit the patch.)
Oh, good point!
--
Bruce
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
2016-10-10 16:29 ` Laszlo Ersek
2016-10-10 20:27 ` Bruce Cran
@ 2016-10-11 0:51 ` Zhu, Yonghong
1 sibling, 0 replies; 6+ messages in thread
From: Zhu, Yonghong @ 2016-10-11 0:51 UTC (permalink / raw)
To: Laszlo Ersek, Bruce Cran; +Cc: edk2-devel@lists.01.org, Zhu, Yonghong
Looks good to me.
When the BaseTools' support for NOOPT is reviewed and pushed, I will inform to you. Thanks.
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Tuesday, October 11, 2016 12:30 AM
To: Bruce Cran <bruce@cran.org.uk>
Cc: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
On 10/10/16 18:27, Laszlo Ersek wrote:
> On 10/10/16 17:43, Bruce Cran wrote:
>>
>>
>> 0001-Add-NOOPT-build-targets-to-OvmfPkg-for-source-level-.patch
>>
>>
>> From ef7b3dfe26bb7748d838974af57cd73e40e24c94 Mon Sep 17 00:00:00
>> 2001
>> From: Bruce Cran <Bruce.Cran@sandisk.com>
>> Date: Mon, 10 Oct 2016 09:35:50 -0600
>> Subject: [PATCH] Add NOOPT build targets to OvmfPkg for source level
>> debugging
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Bruce Cran <bruce.cran@sandisk.com>
>> ---
>> OvmfPkg/OvmfPkgIa32.dsc | 2 +-
>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
>> OvmfPkg/OvmfPkgX64.dsc | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index
>> 7213197..41500ca 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -26,7 +26,7 @@
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/OvmfIa32
>> SUPPORTED_ARCHITECTURES = IA32
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32.fdf
>>
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>> index c27024a..1bd4b21 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -26,7 +26,7 @@
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/Ovmf3264
>> SUPPORTED_ARCHITECTURES = IA32|X64
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32X64.fdf
>>
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index
>> c34b266..460f7bb 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -26,7 +26,7 @@
>> DSC_SPECIFICATION = 0x00010005
>> OUTPUT_DIRECTORY = Build/OvmfX64
>> SUPPORTED_ARCHITECTURES = X64
>> - BUILD_TARGETS = DEBUG|RELEASE
>> + BUILD_TARGETS = NOOPT|DEBUG|RELEASE
>> SKUID_IDENTIFIER = DEFAULT
>> FLASH_DEFINITION = OvmfPkg/OvmfPkgX64.fdf
>>
>> -- 2.10.0
>>
>
> Looks good to me:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> but we should hold it until Yonghong's v4 is posted / reviewed / pushed.
(maybe the subject can be rewritten as
OvmfPkg: add NOOPT build target for source level debugging
but I can do that later when I commit the patch.)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging
2016-10-10 20:27 ` Bruce Cran
@ 2016-10-12 7:38 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2016-10-12 7:38 UTC (permalink / raw)
To: Bruce Cran; +Cc: edk2-devel@lists.01.org
On 10/10/16 22:27, Bruce Cran wrote:
> On 10/10/2016 4:29 PM, Laszlo Ersek wrote:
>
>>
>> (maybe the subject can be rewritten as
>>
>> OvmfPkg: add NOOPT build target for source level debugging
>>
>> but I can do that later when I commit the patch.)
>
> Oh, good point!
>
Commit 272142289dbb.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-12 7:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-10 15:43 [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging Bruce Cran
2016-10-10 16:27 ` Laszlo Ersek
2016-10-10 16:29 ` Laszlo Ersek
2016-10-10 20:27 ` Bruce Cran
2016-10-12 7:38 ` Laszlo Ersek
2016-10-11 0:51 ` Zhu, Yonghong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox