From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 822E31A1E05 for ; Mon, 10 Oct 2016 09:27:23 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E2747A4B1; Mon, 10 Oct 2016 16:27:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-14.phx2.redhat.com [10.3.116.14]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9AGRLMw010228; Mon, 10 Oct 2016 12:27:22 -0400 To: Bruce Cran References: <0716680f-f33a-4afc-9780-8c16dce8d375@cran.org.uk> Cc: "edk2-devel@lists.01.org" , Yonghong Zhu From: Laszlo Ersek Message-ID: <072d84fd-ea5e-080d-bc18-aa4cb9fb68de@redhat.com> Date: Mon, 10 Oct 2016 18:27:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0716680f-f33a-4afc-9780-8c16dce8d375@cran.org.uk> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 10 Oct 2016 16:27:23 +0000 (UTC) Subject: Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 16:27:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 10/10/16 17:43, Bruce Cran wrote: > > > 0001-Add-NOOPT-build-targets-to-OvmfPkg-for-source-level-.patch > > > From ef7b3dfe26bb7748d838974af57cd73e40e24c94 Mon Sep 17 00:00:00 2001 > From: Bruce Cran > Date: Mon, 10 Oct 2016 09:35:50 -0600 > Subject: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging > > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Yonghong Zhu > Cc: Laszlo Ersek > Signed-off-by: Bruce Cran > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 7213197..41500ca 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -26,7 +26,7 @@ > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/OvmfIa32 > SUPPORTED_ARCHITECTURES = IA32 > - BUILD_TARGETS = DEBUG|RELEASE > + BUILD_TARGETS = NOOPT|DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32.fdf > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index c27024a..1bd4b21 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -26,7 +26,7 @@ > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/Ovmf3264 > SUPPORTED_ARCHITECTURES = IA32|X64 > - BUILD_TARGETS = DEBUG|RELEASE > + BUILD_TARGETS = NOOPT|DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = OvmfPkg/OvmfPkgIa32X64.fdf > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index c34b266..460f7bb 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -26,7 +26,7 @@ > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/OvmfX64 > SUPPORTED_ARCHITECTURES = X64 > - BUILD_TARGETS = DEBUG|RELEASE > + BUILD_TARGETS = NOOPT|DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = OvmfPkg/OvmfPkgX64.fdf > > -- 2.10.0 > Looks good to me: Reviewed-by: Laszlo Ersek but we should hold it until Yonghong's v4 is posted / reviewed / pushed. Thanks! Laszlo