From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.1537.1571131620021289756 for ; Tue, 15 Oct 2019 02:27:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cj4Qkoze; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571131619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OR9fgAjEN2OTP0PdydmYiJTapfOQ1oNy0qDgi915h4g=; b=cj4Qkozem+UsA1r4Z6J1h8r54cjHCcWh5ifyOeWc+XRPtW0qYL8TY+3ENvqECmBnq2W1OT zycyVeSSuIHYwohn5mCBNFN0jrTey+yIWxaK0q2cCnNpLU0eY5/7ASls8wARAscQlTyDqs LcX23zPxI7Hxdg1y6/gslQpaD88kaTI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-rXoJnHmEPlKAfzZx48o6zA-1; Tue, 15 Oct 2019 05:26:57 -0400 Received: by mail-wr1-f69.google.com with SMTP id h4so4048825wrx.15 for ; Tue, 15 Oct 2019 02:26:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0qAdF2t9A6k9ZG3jZFo+5uK/mKdF25VaTcp/2zlxHKw=; b=D3VNjxzGp0qxgUgWlcGTLideIRrIjX1ejtsA68s6HEyCYt78CFBQQ1W3h41JNpBI5+ X1DJgSc87RgZ9n2UuhpSOLyhQ/eAuGnrlrbaB82ZG0BCQ9Yn708LcgUQCkA38KI5RGiL xfnVe5TEPikCudxQMrC2+gQMaFfnzVu3YuTRO0ifsksiWoZdDZ63UpEAkErPAlV4YzAk vIzhSKjX9cO+keASDuPPtNolq85gLBE9M7SmHKZXhE+DPcsXP4FUVJiXDZKIsBVAfjAe bceKJwMsX9CC4h8j04AnUI5043WV6hJL9TSgtI2UXLpqG9aaogcC43TjkdD0WZd7tUtL 6hOw== X-Gm-Message-State: APjAAAUWgWKSt5+aOzA9EN4ii/HhbOWgOvrvV+zwyLkCMSbEBHTNEUgp MprwGeITHfFDTk6Dz57qXH769derI6u0hVG7GeVLHbd6SRXFxpz5DFHwpIMJHfnF0ubbO0+1+lS A4rEH46hnpFgUwQ== X-Received: by 2002:a7b:c8c5:: with SMTP id f5mr633370wml.170.1571131616063; Tue, 15 Oct 2019 02:26:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwm7OZbEUmReOOqCmnyqqGCj9uDit87+DLZdUexFKhxBMQkK6/Efar3F/qtewEqBKiMvgMQHw== X-Received: by 2002:a7b:c8c5:: with SMTP id f5mr633351wml.170.1571131615739; Tue, 15 Oct 2019 02:26:55 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id w125sm48796237wmg.32.2019.10.15.02.26.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2019 02:26:54 -0700 (PDT) Subject: Re: [edk2-devel] [Patch v2 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions To: devel@edk2.groups.io, liming.gao@intel.com References: <1571099210-12432-1-git-send-email-liming.gao@intel.com> <1571099210-12432-6-git-send-email-liming.gao@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <074bd375-70ed-3dbc-5b5c-bda1dd0c77f0@redhat.com> Date: Tue, 15 Oct 2019 11:26:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <1571099210-12432-6-git-send-email-liming.gao@intel.com> X-MC-Unique: rXoJnHmEPlKAfzZx48o6zA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/15/19 2:26 AM, Liming Gao wrote: > __inline__ has no functional difference effect with the GCC48 / GCC49 / G= CC5 > toolchains, but it breaks the build with CLANG9. Remove __inline__. I never understod how the compiler can optimize inlining such functions,=20 and always considered this behavior buggy. Either declare a function as=20 inlined in the header exposing it and define it here, or do not declare=20 it as inlinable. Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Liming Gao > Acked-by: Laszlo Ersek > --- > MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c b/MdePkg/Librar= y/BaseIoLibIntrinsic/IoLibGcc.c > index 055f0a947e..b3a1a20256 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c > +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c > @@ -32,7 +32,6 @@ > @return The value read. > =20 > **/ > -__inline__ > UINT8 > EFIAPI > IoRead8 ( > @@ -60,7 +59,6 @@ IoRead8 ( > @return The value written the I/O port. > =20 > **/ > -__inline__ > UINT8 > EFIAPI > IoWrite8 ( > @@ -87,7 +85,6 @@ IoWrite8 ( > @return The value read. > =20 > **/ > -__inline__ > UINT16 > EFIAPI > IoRead16 ( > @@ -117,7 +114,6 @@ IoRead16 ( > @return The value written the I/O port. > =20 > **/ > -__inline__ > UINT16 > EFIAPI > IoWrite16 ( > @@ -145,7 +141,6 @@ IoWrite16 ( > @return The value read. > =20 > **/ > -__inline__ > UINT32 > EFIAPI > IoRead32 ( > @@ -175,7 +170,6 @@ IoRead32 ( > @return The value written the I/O port. > =20 > **/ > -__inline__ > UINT32 > EFIAPI > IoWrite32 ( >=20