From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.41]) by mx.groups.io with SMTP id smtpd.web11.20707.1621265564161978037 for ; Mon, 17 May 2021 08:32:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ekJknCE5; spf=pass (domain: arm.com, ip: 40.107.8.41, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfoVdHnEjWfwNw25OKVI0zEtXUxzPPTrBjZ4i7ph2Nc=; b=ekJknCE56LI+4WOn34sfU1RludERmepKYpuUHIVvGlRa5tW0OmZ4ToV1yLMqGTqcEt7Szn21hjN7Rem8EybSItnj8VCXhjXiuN/VjCXh9eRGf1q3ItGgpEujwsfAYIpiJ599xgMLvoA/HgFK9BOz2IOPQSD5mv6cZD6CecmoSFA= Received: from DBBPR09CA0021.eurprd09.prod.outlook.com (2603:10a6:10:c0::33) by AM0PR08MB3218.eurprd08.prod.outlook.com (2603:10a6:208:5b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.31; Mon, 17 May 2021 15:32:38 +0000 Received: from DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::dc) by DBBPR09CA0021.outlook.office365.com (2603:10a6:10:c0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 17 May 2021 15:32:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT007.mail.protection.outlook.com (10.152.20.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:32:38 +0000 Received: ("Tessian outbound 504317ef584c:v92"); Mon, 17 May 2021 15:32:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b4c58a389a5423ee X-CR-MTA-TID: 64aa7808 Received: from 0b464997eaaf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 833B426B-19BB-4F19-897C-262256453319.1; Mon, 17 May 2021 15:32:28 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b464997eaaf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 May 2021 15:32:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bR6Oazz0h1174oj1oe2o9RmapSm23IzOiKj4q0Lt1Jud5Nb82a2TSAYeLw8daDfW6bEtGBKZwr/eHRvvt7fQWFhgXq77Wd23onhT+QmEvatYSlSxnaGXNg5HhV6Iu1NtFLLc+ZIBC9JoyBsVkUh/SzohjpxnJlliIeNT1vXJ1rQBl5ejfmjGV8jOr5HzGIWIxmFePPek63FewkQaUL4w2wUBkLS5jiMsJpMsgOjACkG+tKwX+OLVdnrJokczzxZe1uwIAfkPzNin0R2xisDMwx6Bz8hxY2TUYZqVhkE3CozKv3qfv4joaep9L5C4J+CrLlj2v5B2m4ZSLIwQ0lJInA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfoVdHnEjWfwNw25OKVI0zEtXUxzPPTrBjZ4i7ph2Nc=; b=a5itHmkf5PfKX4DOeCcD3NxDbmYZwtLKbL7ZYXp16AfE24tXapu9RvIW4Vphz/cstEJLbK7+PtFGrWEKxyyg7CBWQPvDeV0yFKFjxhkQjfvpv2jG3kJS3d4uTgfJk7tAcHpqOsQ0b5h10U+BBWqES+uCajYBN8UXkJptJKvLvMOg4utewKwaFstzdR5dvwWAGgTXudEvqP5QJrEOgRzsU0mwtYHNkc2ISUWLK8lPLsFwBuu8YQpb9PE+wDrfOEQSB3YpS4LhUI0CIgGOEyJvPAMDH0eMChoZTabJk88db0TQKjT45e2Ui8ij5GcR4RWp6la7lznLmt4dtYb8kDticg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfoVdHnEjWfwNw25OKVI0zEtXUxzPPTrBjZ4i7ph2Nc=; b=ekJknCE56LI+4WOn34sfU1RludERmepKYpuUHIVvGlRa5tW0OmZ4ToV1yLMqGTqcEt7Szn21hjN7Rem8EybSItnj8VCXhjXiuN/VjCXh9eRGf1q3ItGgpEujwsfAYIpiJ599xgMLvoA/HgFK9BOz2IOPQSD5mv6cZD6CecmoSFA= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6294.eurprd08.prod.outlook.com (2603:10a6:20b:29a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Mon, 17 May 2021 15:32:27 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.031; Mon, 17 May 2021 15:32:27 +0000 Subject: Re: [edk2-platforms][PATCH V2 01/11] Platform/Sgi: Define RD-N2 platform id values To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210516092917.21124-1-pranav.madhu@arm.com> <20210516092917.21124-2-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: <0752e2b9-6911-da81-4dcf-bdd95458df33@arm.com> Date: Mon, 17 May 2021 16:32:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210516092917.21124-2-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO2P265CA0347.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0347.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.32 via Frontend Transport; Mon, 17 May 2021 15:32:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 389f516c-8c4c-4236-5346-08d9194900a4 X-MS-TrafficTypeDiagnostic: AS8PR08MB6294:|AM0PR08MB3218: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3383;OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: azRWJMyTLWf3xq/QrswGahhEWIniG03/XeiSSfTVwlzegXVZ3fg4Pru2aZOvjpEJfMzhVoqsiV8J//lrxOf+Bn08OjmscaxoimaNmI5MZBitmEb2XtqEJtp8SfR6AdEB2wLZW7gWzoFowaqsbrBvuThYyaJgys8QDbHyI6U5uUY7XiY7LbtUNBnO0NzG2H0/zPMx40BuFMhlTYTcuBLRs7lhjZ1pGEYc02zOpIYPd/s9vIMLw++f25+GSjM1UV5aSLKNF9VKFVrSqnM8SNSsE0ckF7YpU45WnDHUgP09/ADhHLUic1sTpeV2+X4x6zpRj/slDnukH+Vz8MJVMWJXwONaMoP9WP3aL/EpsknylJm5KO0iQf99skqw6Lu7wM8q1GAe/97Ndg3oartztPdtNKqpt4ykIsCKazrUGgB49bhT6xYCMHY/4HyIZyPYKyxc+2X4EmMbT3f0tEIbi2QL/4zT0BRWFllbYrmcI0jLzOdNnufZ4unJsfeMskUhO72I0VTG0b2YAdUADFDsecCV5KvjnPvk/Z2SRqN34LZ7Gy9p+xZGGrC7fwa1tOVCMz7lsKAT0cShlgyka1S6++nmegD8ccZrjZ9vT8a0bQlTUUlylOFp6XZP3qQr+Fo7ah4jgETCiupwZ3q2LW/wKvyrmn67fOD5Gzz37bfP8oesZij3bZVwdenBQIbMjxaEtc2aDyDInQuoEI10esXrU+aLGw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(956004)(44832011)(4326008)(16576012)(186003)(66556008)(66946007)(8936002)(498600001)(52116002)(26005)(86362001)(2616005)(8676002)(31686004)(53546011)(5660300002)(38100700002)(38350700002)(2906002)(36756003)(83380400001)(66476007)(16526019)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bkZYT2hYV0h6WGpHWEVpTVNkdmFGSWhaV2lXd3NnbmVWb0JOWGZsVldMajV5?= =?utf-8?B?VnI4YjJCWEs3ZFhPY1RFWWtwaEROektLeE1GbkZyMVA4NWFqWFExdm5NZ25v?= =?utf-8?B?R2tTeS8zbmFZbWJWNjN1VXdBMkphK0FYMzBOOXM4dGR4bEUwc080QlZXZC9I?= =?utf-8?B?V0hFbXJRaHdHRXVsY3VRcFc1TFFadXNRY05pbmVwa1lTUjRNU3NUMi9vWk8y?= =?utf-8?B?b3h3aHN6VVJmaEZGM1lldlJLUW8rOXhiSzdMalB5WC9Xdk0wd1JMaHExaVF2?= =?utf-8?B?cjVENVB3ck9tRk5wcHpuYWMyM0tjMEFUam1rb2dRWVFRRy85Y0xadnhHTG0y?= =?utf-8?B?N28remo2NDlDQWg2RlF2a3NQZWhaK2ZlZ1d0RHNIZENzbUd3QmtkOXI2aFlr?= =?utf-8?B?QmZlMFNuQTg1RE9ValAraFRCeWR5Ukl6NGpUV25ZclBtalZqd2FmeURZaUNB?= =?utf-8?B?SDJ3RDdNaG42NlQzNHZSVlR3VXpiVTNXRXYwYm0xRGlEWHZWZmhNQ1lYcmgw?= =?utf-8?B?V1U0VGV4L0s5TmxkU3c4VkNvQktHRWQwN3lLWE4xcUlOWGpuMURpK0VOTk9w?= =?utf-8?B?RW1GR1pJYWkxZTczQzdwSTRrWm9Rc0pJcVhpRUsra1VmYmduckhRN1dlYzU4?= =?utf-8?B?NVh6QndWYkY5djByRHFja1NuTjYyU2ZWalRUUW8wNnQ5QUcxSHRLWFdpV29i?= =?utf-8?B?Z2ZuWDdEamVpeUVobWxHMndMZjlpYkJzamhTMEpZVGs4dzBBSUVkODlSaWMy?= =?utf-8?B?WWFFNXg3MERvNDdQYWZSVWQrVUZSYnZSYzRTUWZsZk1NbXhrWGdSYzRobkVt?= =?utf-8?B?ZEtRTUtUbVFEWHdVUHY5ZFFrYXFFVnIwYS8rQXFnK2Q3R2E4TlFLbnh6NkI4?= =?utf-8?B?SER4WStycnFra0pQUEpDbW05QUtLa2xqRC9FanpYeUg1b1lPQ1BYL011aWxp?= =?utf-8?B?OXA0a1ZoaDhiWWtuc1dlVHh4WlhGSWhRc1gray9xd3lzZW12cHNpczE3TTRJ?= =?utf-8?B?ejhhUWVYRDFjS0tGVWxEM0p3Sy80cFk0VnVhcGdBVHh3anpyVzFuTUpoeGpC?= =?utf-8?B?TWxWTmMraDRWcVhhMGtuU1dhR1BjY0hhUGFxd3F6VzRLc2pLZG9zU0FPRU1y?= =?utf-8?B?akRJVjVZVG5uZjZyMnlML3pBWkkwTFVXVVliR1dRUzd3bGdlVmN0VTI5NGNF?= =?utf-8?B?cm0xcTdjY0wxMjFSRjdEWTdFMGlNbnUxU2hiczNCaWZPWmE1a3lxUHQzT3Zy?= =?utf-8?B?S0hxY2wwcmt0MFFGUzFBTnZOSDRTNklWNVJnbFQ2SXNEUTNMQVZPaHdUQlB0?= =?utf-8?B?Vk9GeU1HQ25SeVFML09jYXF1VU82ckJPc1V1c1MvRUtydmhjWGlKdVh5VWUv?= =?utf-8?B?V0daTXhWVHpodm1wVkJKcVdVSUtBcTMzcjZGa2JMckVmd3dya2FuenRPM1c2?= =?utf-8?B?MElZSlNqbEVjcUEyK2t4VEgzZjBOTS9sZVRjT0RxdlJRY2VQVXdTbCs3UXBP?= =?utf-8?B?KzQ3OStkLzBHS00vejdSZ1NNU0xxc2txU1huejc2N0V4SU1na3VjRWk3WDFo?= =?utf-8?B?bEZXWnpZZkYyQ3JLc1J3M0hRM1RDMHNiT0xud2xYR1JOM1RoVVNVbmpLK3VR?= =?utf-8?B?aWQvemhqbGxGWVY1SVN4QTlKcUY5S05CL01vc2RwRTBIK3JvUWJhQXk4bWs0?= =?utf-8?B?WHozSHBZWm11Nm5XanVZTVdyelFTcG1TNHBUOHZGU1daRUhUeWEwZjhtRURQ?= =?utf-8?Q?runO4TMPui3JMb66gloqOh3qdbuG0SXUihumFlh?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6294 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0848d3fd-75c6-419e-b4d9-08d91948f9b6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c4p3pSa/mI9URs3VGFyfJO42BykLzG1S8yxSaGbNUxJelOruh5opnVutzU+64NrC/ajoQIjbPLLmipVM51s7QZzWcn0YxtAvqLfpPrndnQlE3hVCCGdfHc8qypoQXG9tl1CbdkFahV64gKLZ+hduPnl89U1pM0ldJryrvBqxRbMgj3G5R0rtqj3lDVGOJ32iPmJIxARZsVNaHiDkhOQhfEc+WmlsqSFrohlt0sVy4kaJLHgkYP/OlbqwLyRbIptIr6L7xxCzyblGG3P7jNH81XRItThdH3f0r7dge1rQzxt93GL2K+T2vA3xWWVP/FdpDnePYzbUcjvpYUGhNeoQpNNfAf2h76J9QZUYz6RR7yJ2ZQKwjnzf7aAPcigeHtrGKrzHe3euOYaHoeXfpXaznm/RrwY4SxTbbPHiLRi1IVuqimIHcP+Yen4jUgg1diy+RWfHqfrjEKZc4sdTay215toO0bt84fjjZOFDQiiWg1o9uYNB2VXpmx/exaZvKWn0X6ywtyTkeRXvPxBA9XopcPNj4b3CKF+VH1gAdOd46RdzCekQM9iI7z+LQyaR6WvYuwCIwfI4IxeqbM0vBFiMrlR3SYIghMRwdknpI0fjEKMzYQxFl3iI5Ft8nP9f5cwCEhUniFs77Mx8+KEjmhio/6dwrcYaMH5OX1SDMLUvMuplnTf8NKMihwCnSKCGBzbx X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(396003)(39850400004)(376002)(136003)(36840700001)(46966006)(47076005)(316002)(82310400003)(8676002)(36860700001)(70586007)(478600001)(44832011)(2906002)(336012)(26005)(36756003)(2616005)(53546011)(5660300002)(16576012)(31686004)(81166007)(86362001)(6486002)(356005)(70206006)(8936002)(82740400003)(31696002)(83380400001)(16526019)(4326008)(956004)(186003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2021 15:32:38.3642 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 389f516c-8c4c-4236-5346-08d9194900a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3218 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pranav, Thank you for this patch. This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: > Add RD-N2 platform identification values including the part number > and configuration number. This information will be used in populating > the SMBIOS tables. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index 818879b5f81e..1c5366878712 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2018-2020, ARM Limited. All rights reserved. > +* Copyright (c) 2018-2021, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -39,6 +39,10 @@ > #define RD_V1_CONF_ID 0x1 > #define RD_V1_MC_CONF_ID 0x2 > > +// RD-N2 Platform Identification values > +#define RD_N2_PART_NUM 0x7B7 > +#define RD_N2_CONF_ID 0x1 > + > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > #define SGI_PART_NUM_MASK 0xFFF