From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.71]) by mx.groups.io with SMTP id smtpd.web10.29152.1620637977172265004 for ; Mon, 10 May 2021 02:12:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Wr1SGLCc; spf=pass (domain: arm.com, ip: 40.107.2.71, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwrsB8pc8KkdK3bG/mC8aRTxCx/+bTiO2LycNHtvOTY=; b=Wr1SGLCcVEXyDQUjVJACeaw8r20/n5xD8MWOAj0doEbD1qSYC9DauTIXGkLexyiV048nmnBA40IMU0pYxJQmviuxZJ57O2Knr3H8rBrLB5EkXym8o79NULnpQZaxb/kcxFvmqA0ZCYp/GSRjOH/ooFvm9IwahCup+UBu1ivdrwk= Received: from DB9PR01CA0012.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::17) by AM8PR08MB6435.eurprd08.prod.outlook.com (2603:10a6:20b:317::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Mon, 10 May 2021 09:12:54 +0000 Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::1c) by DB9PR01CA0012.outlook.office365.com (2603:10a6:10:1d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 09:12:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 09:12:53 +0000 Received: ("Tessian outbound 1e34f83e4964:v91"); Mon, 10 May 2021 09:12:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c8eeec0e6de32ee X-CR-MTA-TID: 64aa7808 Received: from bdd867d691dc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93BD63BE-70F4-4EAA-8D53-4168DE90A6FF.1; Mon, 10 May 2021 09:12:41 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bdd867d691dc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 10 May 2021 09:12:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyyO/8vETS9GvNlQ7UjKPADxQJPP/fdCCynuxcO2KWbCE2CgT9fvcQxJ6KYULZ5lM3deasMEfgyoGLve9Pz/O/euUhOArfq0Lf5P5iTXIjm+tNGCXz76uQ1rY0/oiI8Oy3ysSokRcN99QV/MpU7SWjPlIAhXgUAt15zsZhfr/lDNBuov2d2ShmbH1C6MqKtFYdcZoTQnkE2t5cmobnm3Zi8I6ErDcmq52LMAK6YVEej/mf5Y3pLPYDKqaz3O8iP/7N/QHLTzC45Z4hzXJvZqG+j5KKm9TwPAQjCEOjIBg1Z6HaVMwoVJVSSqlwDads4HNsHuWwLUQtuhnfIb30sguA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwrsB8pc8KkdK3bG/mC8aRTxCx/+bTiO2LycNHtvOTY=; b=RMbW7RkyQkg0Zp0Oro/OjpBPgVfm1IypbgHNj4SPdVkZyLO/p+vEW0ENfkeR+UcyDzLgQmRXtekMwHx0jsf5JvhxblF/m03wKsQ1qNaL/RihB9GzBNBUYfg/KClgx8c20dQdV9zvmcoQDyI/UTWak00cwefr4OPah2yMebYEUYa9bd3HwVnQrG5hsYkuLGbzB3uYTORWt4uGbkLHijgIIzVhPANN4qWmi/msVnHjzPMrkEyzPegzBYs/k+u17Hc3SvU6GAhXQWEfxSjyQp3+NjlyO4hJxnrd3ZcGs+mxuZ1wQeWX8EzCus5N1tSk2ZVUJ4yyWsP086/QxsMPonQv7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwrsB8pc8KkdK3bG/mC8aRTxCx/+bTiO2LycNHtvOTY=; b=Wr1SGLCcVEXyDQUjVJACeaw8r20/n5xD8MWOAj0doEbD1qSYC9DauTIXGkLexyiV048nmnBA40IMU0pYxJQmviuxZJ57O2Knr3H8rBrLB5EkXym8o79NULnpQZaxb/kcxFvmqA0ZCYp/GSRjOH/ooFvm9IwahCup+UBu1ivdrwk= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4851.eurprd08.prod.outlook.com (2603:10a6:20b:c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 09:12:32 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4108.031; Mon, 10 May 2021 09:12:32 +0000 Subject: Re: [edk2-platforms][PATCH V1 10/17] Platform/Sgi: Macro definitions for ACPI CPPC To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210428123600.2385-1-pranav.madhu@arm.com> <20210428123600.2385-11-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: <075667e8-b943-1e5e-2a7a-e81f4ed12d1c@arm.com> Date: Mon, 10 May 2021 10:12:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210428123600.2385-11-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO2P123CA0020.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::32) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO2P123CA0020.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 09:12:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c6b6d51-5a5a-4754-74b6-08d91393cab6 X-MS-TrafficTypeDiagnostic: AM6PR08MB4851:|AM8PR08MB6435: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /0XD688Q2mBwkPPPBcINB5JhZzPPtEp0vfJH+14XJq9uTEpv1+hQVOCCuFYV/E9O9gFHbIoJKZjuUu0virItjbyQeC1wHvYIRdSwd3Qsscoq0i1pMKQ9pJRSyNTnd1qvK0RTyue0ZIPFjUed8G2HeKCGT+G4ZmBrmUANdVdcuf0GkCt8cgNLrhN0lqUEkC5xNy1eABt6Qbi8d1oL/HwJduDkHM+rM3zzulgXwvZfTwgRanGx3Y1qk5t//GbM1TS7QPLsH7yqKsFY1qJ7plrnLVZ7mI4qc1dThV3mb4xFumqgzo2iPyUL/vdGHPoRWWqmlLAl6OJNdaFb3sWEpnWjGLnInoZ8g8mXaEhfJIt1Xl3NuNAKnKNB9dVq0va1W12Dhzi/1MB2WxjmgXJ7uOZ8a2uiREmVrQeus6rP7bdm0/K5J1o0z/SjMwmHGTMXoKWqehdFe1baFSC+4NGktaU3wl2H6cb+efhKRMMmX6OaOa5HMunIYsaZ3h9Mt74q7aUe0X6L/2N/h6Efa1t3fk8WMPwR4oKed9GC44cxGNYYVTf2MJ5tW8miAC4l20EtKBtL1uopop2n0lQQ+TfG1clQYw2lU+/nE/QEH0yRDD5TPd3EySrfrWQOCLEa72EcFGthD5eHzDBG3agDtkK8jJFuB+20Yo0LuKVhv+NVqNhs3UUZ8GYcY/0Ba1HGUVfOCenRw93KHH9oWMduXzAOFZuEg2YdSu0hKb8ZV4G/zGRVT70= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(53546011)(2906002)(26005)(31686004)(52116002)(31696002)(83380400001)(38100700002)(38350700002)(186003)(8936002)(66946007)(66556008)(8676002)(6486002)(66476007)(16576012)(4326008)(316002)(44832011)(86362001)(956004)(2616005)(16526019)(5660300002)(36756003)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?dm0wYVpxSW5lTWo5U2VuRnQ5clBqOFZWbkFSSUthMUJ5SVdoY0RWWUtZSFl6?= =?utf-8?B?SGs0SzIzdnhReU1heTNIdWtnOWRmNnlrUVl5UWcvTTJYcTRKa2pwWmZ3V1BU?= =?utf-8?B?Qll3R1c1aFNWVExFNldzT1hyTHFIeExiWmdCamJNZG1tblNuM3R6RTd3bDhR?= =?utf-8?B?YW1ZOE9uNmZpQkZOQkg2SUJRL1JhVGUxeGVhSVdMWFJvdDl0OWFYWEszbldB?= =?utf-8?B?NXkvV3JJZ0taZ1dnMmY0TXQrMWJ3N1BjakVBRm9kd0Z0ODRFQW90R0RncUhi?= =?utf-8?B?TW9IdzhyVlhSQ0FYQTFWWW9DQTh6QU41TE0xRUNkbGRkZ280aE5wK2xIeTk1?= =?utf-8?B?V0pUcjVCalNZM0w3VjFzR29ISWdrQ3lVSDdBZUZYREgvRXhXYnFRclBwalJG?= =?utf-8?B?TjJBQ1c5NEE0RzVwS055K2QzU1FKclZ6ZVVITWNzYVo2L2FnemgvVklHWHBJ?= =?utf-8?B?djZHTERYdUtEai8yUTNSQ04rdnhmZ2MyUk9zbGdaNjJkQ2hmbWZaRm5kTnE1?= =?utf-8?B?N0hIRmRXTUkzckk4ZXYzL1RVZlNub2VsK0p1NEtIYUhGWGtwc2NEN3pmREJV?= =?utf-8?B?MCs2VGZzR3pUekptQnF1c0RhT2FkVDRKd3pYdWdrb3F3UlNObDgxbEJIL09s?= =?utf-8?B?L1htaXhXNGdkeVRIOFMybjNNS2h6akQ0WjZiYTdlZWxmUXJMeHUwZmRGNGYx?= =?utf-8?B?bW4ySmw4ZTE4UmlDZ0FWTlZlWFRvenFEZUFCSVpHcFpRZkIzQldlTHYvYVZv?= =?utf-8?B?ZVFnNFZ2M3ZPZFc3OUd2WUN3YXBZL3J2Q0lnZkJXWGdxYnluUlBaVElQRVFp?= =?utf-8?B?Wnk3WktRVlNRdFNvalZmS0lLR1Z6RG9qVWtyZU04V1hPeFNaODhaY1F3VWZp?= =?utf-8?B?VFZSK21ZY1BrNlBHUnNTRklscHlaQk1GQXppbDJJL0R3RGVyamtXRWUyUkhH?= =?utf-8?B?L3BPNjFxMlNheGRTRm5UcUFNR2tmclY3VkVKVURmbm0zMEN0S3IyeDVCRWM5?= =?utf-8?B?NjdNakdSYXMzSXZuckUvQ0NrOEdWL1hZNVorckNZd1EyQUdIVTBFaFdHRnhN?= =?utf-8?B?WjN1Y0xCYmQvZW9yVG14T3VGUnlSZ2YyZkRmY1BVYmtOZHRKWXdvaWlmMFkz?= =?utf-8?B?QU13T0hsMEhCK1YvdUExYUxHY3dPWFRwdjR2SHk0TkxnSi9VZDZHQkgzQ2pM?= =?utf-8?B?YVJWUmZocTNtdzJMT2ova2o5NHZ2SlBwSGhET0QvVTJlZWs2dlRXTGJpWG83?= =?utf-8?B?Z1AvbFQ4bFNpVFk3MjVTYStzbU1WbU1TVmNNaW5lVGNXVUVEVlBvaGQ4WlFx?= =?utf-8?B?ajZqNU1BdFMwRVRqaVhZNS8yRW9rUGdPK29QT25pWTZWZ3Y0S3l3Z0VNTjQ0?= =?utf-8?B?YTd5MHR5SzNaYlV5Zk5lSnlOTzNhdW1STkFjVWxqTmNhbFcxckNqaVE0Nk0w?= =?utf-8?B?eCtpbzZiTmdWYmNKSUg1Q1RXTXBtV3RUdS9sSWV2U1o2ODJHTnRKY1dJVFBN?= =?utf-8?B?bnh1ZU8rVVdFQ1J1clNOeHRKOGZJa3BrYTJUZG44dUQ1My9wRndMWTB0TDQ4?= =?utf-8?B?d2RxVCthV3ZNRGx4UGFHZkU0T1J0cU9zeHVRa0lwMG15cXFBOHBPMm1pRUZp?= =?utf-8?B?eTF3eFk4VllaWWhqdDhQQk9tand1M0VMZzZtZXNWTStlQmtZT1VDRHZzS2Jl?= =?utf-8?B?L29hTDRTTXptdEVpd25Oc1VhREd1QktmUDlXRTc5NHpjbStFalRqZHUrY1VE?= =?utf-8?Q?6RFkb03GhMSpB7MkShhPGN6hzUNCRbVxkBSEik2?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4851 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 868e67ce-af03-4b60-6234-08d91393be88 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FucUMwBckuYQMzc8VehHLrWlEOvRL8R3ARJEsylRmkHyBbI50wlVDK3IwpAzucjk1dzRT+aiFhsk40JfLR7M1eEumkaaZjujFJte/V26Dk2TutzOLWiJeBfUV8pmSPL4B6bQqspKcqICUr8i63Iu7tqoteftt/qR/TlDJ2aXKZXOa25nn790l725akqD+ujF4LVUwAqoQPvPEYcj8vBlQHvXU0CWXe1pttEJlm0E/abKawTkwT8ECgrDEk5+cO0BwpzYLQUjC5bcHg8islE41Fk2V1YezCqJBzSP5GLivmWQdMvw1Qkq1G92/R5PCTaW9M71yQ7PKmyY0nioo+VPL3AAQr9P1AMwFSJkjhcLsIiJKhfuC5Mj7zAuRtPyBFSOZGkGnN2KqxKjMo5nrp3r7BLsxk50mL3KqHuWABFCGiRH5SNouESMldSDquirFRf/VxWzGY3/BvIF935q58bNQkZsvZ+ygFW78Vc/gxaxyDYYchs7XsHJe31RyuXNEQKzyIua++nBCd3+UtfaOjAs5o2COJmfL7ybAQYAj8LtnwnEPJnw0bhOcWKh1rxnOgujkW2/XqAlP/xt27qdG9qPA2Iuru/4tTOp0ZaHGcePweodUnSI4N9U0dMmupa2gaHl1nTviXxGnRewmpb3zOjD1zLH2l4s6SWWAtZCQxLYoLkfMKEmnNNOR7lp2jyVfmnl X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(70206006)(36860700001)(4326008)(8676002)(26005)(70586007)(2906002)(16526019)(53546011)(2616005)(336012)(186003)(83380400001)(47076005)(81166007)(44832011)(36756003)(478600001)(82740400003)(31696002)(86362001)(5660300002)(956004)(8936002)(6486002)(31686004)(16576012)(316002)(356005)(82310400003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 09:12:53.1631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6b6d51-5a5a-4754-74b6-08d91393cab6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6435 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pranav, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/04/2021 01:35 PM, Pranav Madhu wrote: > Add helper macros required for use with ACPI collaborative processor > performance control (CPPC). This patch adds macros for initializing ACPI > _CPC and _PSD control method. The CPC initializer macro initializes _CPC > control method with revision 3 as specified in Arm FFH specification > 1.1. The CPC initilizer exposes the reference performance counter and > delivered perfrmance counter (AMU registers) as FFixedHW registers. The > initilizer also expose the fastchannel memories for performance level > set performance limit set protocols as desired performance register and > performance limited register respectively. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 53 ++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h > index 4977d4d898aa..1b5305f15fb8 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h > +++ b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h > @@ -423,4 +423,57 @@ typedef struct { > LineSize /* Line size in bytes */ \ > } > > +// CPPC _CPC object initialization > +#define CPPC_PACKAGE_INIT(DesiredPerfReg, PerfLimitedReg, GranularityMHz, \ > + HighestPerf, NominalPerf, LowestNonlinearPerf, LowestPerf, RefPerf) \ [SAMI] I think it would be good to add a coment in the macro header clarifying that this macro is intended to be used in ASL definitition. The same would apply for the following macro. Alternatively, you could introduce a new header file for the ASL macro definitions SgiAslHeader.h. What do you think ? [/SAMI] > + { \ > + 23, /* NumEntries */ \ > + 3, /* Revision */ \ > + HighestPerf, /* Highest Performance */ \ > + NominalPerf, /* Nominal Performance */ \ > + LowestNonlinearPerf, /* Lowest Nonlinear Performance */ \ > + LowestPerf, /* Lowest Performance */ \ > + /* Guaranteed Performance Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Desired Performance Register */ \ > + ResourceTemplate () { Register (SystemMemory, 32, 0, DesiredPerfReg, 3) }, \ > + /* Minimum Performance Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Maximum Performance Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Performance Reduction Tolerance Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Time Window Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Counter Wraparound Time */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Reference Performance Counter Register */ \ > + ResourceTemplate () { Register (FFixedHW, 64, 0, 1, 4) }, \ > + /* Delivered Performance Counter Register */ \ > + ResourceTemplate () { Register (FFixedHW, 64, 0, 0, 4) }, \ > + /* Performance Limited Register */ \ > + ResourceTemplate () { Register (SystemMemory, 32, 0, PerfLimitedReg, 3) }, \ > + /* CPPC Enable Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Autonomous Selection Enable Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Autonomous Activity Window Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + /* Energy Performance Preference Register */ \ > + ResourceTemplate () { Register (SystemMemory, 0, 0, 0, 0) }, \ > + RefPerf, /* Reference Performance */ \ > + (LowestPerf * GranularityMHz), /* Lowest Frequency */ \ > + (NominalPerf * GranularityMHz), /* Nominal Frequency */ \ > + } > + > +// Power state dependancy (_PSD) for CPPC > +#define PSD_INIT(Domain) \ > + { \ > + 5, /* Entries */ \ > + 0, /* Revision */ \ > + Domain, /* Domain */ \ > + 0xFD, /* Coord Type- SW_ANY */ \ > + 1 /* Processors */ \ > + } > + > #endif /* __SGI_ACPI_HEADER__ */